[GitHub] incubator-spark pull request: Spark 1095 : Adding explicit return ...

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/610#issuecomment-35480180 @aarondav With this last commit i suppose i have completed the issue.(Spark-1095) --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-spark pull request: Spark 1095 : Adding explicit return ...

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/610#issuecomment-35469655 Thanks @rxin !! This will be helpful !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To

[GitHub] incubator-spark pull request: Spark 1095 : Adding explicit return ...

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/610#issuecomment-35469237 @aarondav I reflected the syntax you suggested in the code i changed but i can still find many places where the return types are on the new line, how will

[GitHub] incubator-spark pull request: Optimized imports

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/613#issuecomment-35434195 @aarondav @rxin Thanks !! All the comments addressed !! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-spark pull request: Optimized imports

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/613#issuecomment-35430115 @aarondav Now is it all ok to merge ?? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do

[GitHub] incubator-spark pull request: Optimized imports

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/613#discussion_r9834422 Ya that is a clarification for me as i left of 2 newlines in many cases as i am not sure .. will complete all those in my next commit !! Thanks !! --- If

[GitHub] incubator-spark pull request: Optimized imports

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/613#discussion_r9834239 I dint get it !! Where the extra whitespace ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-spark pull request: Optimized imports

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/613#discussion_r9834035 Ohh sure will change it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top

[GitHub] incubator-spark pull request: Optimized imports

GitHub user NirmalReddy opened a pull request: https://github.com/apache/incubator-spark/pull/613 Optimized imports Optimized imports and arranged according to scala style guide @ https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide

[GitHub] incubator-spark pull request: Spark 1095 : Adding explicit return ...

GitHub user NirmalReddy opened a pull request: https://github.com/apache/incubator-spark/pull/610 Spark 1095 : Adding explicit return types to all public methods Its still wip and i am doing them in chunks. You can merge this pull request into a Git repository by running

[GitHub] incubator-spark pull request: Added Java API for AsyncRDDActions w...

GitHub user NirmalReddy opened a pull request: https://github.com/apache/incubator-spark/pull/607 Added Java API for AsyncRDDActions with tests Implemented countAsync() , foreachAsync() and foreachPartitionAsync() in java API . But couldn't find a way to convert FutureAction[

[GitHub] incubator-spark pull request: added missing saveHadoopFile methods...

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/403#issuecomment-35244753 @aarondav Previously this branch was not in sync with master, now i rebased it with master. Please comment on it now. Thanks!! (The problem was scalasytle

[GitHub] incubator-spark pull request: Java-api completeness

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/475#issuecomment-35234000 @pwendell Can you please verify this patch. Thanks !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-spark pull request: added missing saveHadoopFile methods...

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/403#issuecomment-35233963 @pwendell Can you please verify this patch. Thanks !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-spark pull request: Java-api completeness

Github user NirmalReddy commented on the pull request: https://github.com/apache/incubator-spark/pull/475#issuecomment-34736734 @tdas Can you please verify this patch. Thanks !!