[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread qqsun8819
Github user qqsun8819 closed the pull request at: https://github.com/apache/incubator-spark/pull/551

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34588354 LGTM. Merging this now. Thanks!

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34581811 @rxin look good to you?

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34575031 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12646/

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34575030 Merged build finished.

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34574306 Merged build triggered.

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34574307 Merged build started.

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread qqsun8819
Github user qqsun8819 commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34569840 @rxin Thank you very much for your review. And 2 test case failed becuase I hard code a Date string . I 'll find out why because all case are passed in my own

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34568219 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12640/

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34568218 Merged build finished.

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34567984 Thanks. I left some comments to improve readability of the code.

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34567877 Merged build started.

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-08 Thread qqsun8819
Github user qqsun8819 commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34567873 I update the diff , using hard-coded json string for json data verification. @pwendell @rxin and @aarondav Please reivew it again. Thanks very much!

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34567876 Merged build triggered.