Github user asfgit closed the pull request at:
https://github.com/apache/incubator-spark/pull/638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user xoltar commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35857946
Thanks, last change should address all code review comments. Also cleaned
up some imports in PairRDDFunctionsSuite that weren't needed.
---
If your project is se
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35856428
We should put this fix in 0.9 as well once it's ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35856419
Thanks a lot for tracking this down, fixing it, and adding tests! I added
some minor style comments, modulo those comments LGTM.
---
If your project is set up
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/638#discussion_r9980747
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -330,4 +335,74 @@ class PairRDDFunctionsSuite extends FunSuite
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/638#discussion_r9980751
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -330,4 +335,74 @@ class PairRDDFunctionsSuite extends FunSuite
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/638#discussion_r9980734
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -26,6 +26,11 @@ import com.google.common.io.Files
im
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/638#discussion_r9980719
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -617,6 +617,10 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](s
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/638#discussion_r9980723
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -617,6 +617,10 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](s
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35854652
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35854654
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12823/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35852729
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35852730
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/638#discussion_r9979453
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -617,6 +617,10 @@ class PairRDDFunctions[K: ClassTag, V: ClassTag](
Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35851045
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/638#issuecomment-35850754
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To
GitHub user xoltar opened a pull request:
https://github.com/apache/incubator-spark/pull/638
For outputformats that are Configurable, call setConf before sending data
to them.
This allows us to use, e.g. HBase's TableOutputFormat with
PairRDDFunctions.saveAsNewAPIHadoopFile, which
17 matches
Mail list logo
