[GitHub] incubator-spark pull request: Graph primitives2

2014-02-18 Thread semihsalihoglu
Github user semihsalihoglu commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35462304 I had written two comments to this but didn't get a reply yet: https://github.com/apache/incubator-spark/pull/580#issuecomment-34731728 So just

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread semihsalihoglu
Github user semihsalihoglu commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35026015 Just to clarify, here's what happened exactly. I had forgotten to delete those comments before committing the first time by mistake. Then I fixed them and

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread semihsalihoglu
Github user semihsalihoglu commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35025243 GraphOpsSuite.scala? Are you looking at the version of the last commits? The first commit had some stuff, which I deleted. I don't see them anymore.

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread Mistobaan
Github user Mistobaan commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35022812 I see a bunch of commented tests in the patch ...

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread semihsalihoglu
Github user semihsalihoglu commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35020911 I see. OK, I downloaded scalastyle and fixed the style problems. Can we try again? Thank you, semih On Thu, Feb 13, 2014

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35006955 The errors are from scalastyle - the style checking plugin we are using. The relevant lines seem to be ``` error file=/root/workspace/SparkPullRequestB

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread semihsalihoglu
Github user semihsalihoglu commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35006091 Hi guys, Apparently something failed. I looked at the console, there's one error early on about the file ending with a new line but don't have

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35005270 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12706/

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35005269 Merged build finished.

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35005143 Merged build triggered.

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35005144 Merged build started.

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-13 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-35004818 Jenkins, test this please. cc/ @ankurdave

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/580#issuecomment-34731728 Can one of the admins verify this patch?

[GitHub] incubator-spark pull request: Graph primitives2

2014-02-10 Thread semihsalihoglu
GitHub user semihsalihoglu opened a pull request: https://github.com/apache/incubator-spark/pull/580 Graph primitives2 Hi guys, I'm following Joey and Ankur's suggestions to add collectEdges and pickRandomVertex. I'm also adding the tests for collectEdges and refactoring o