Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35954244
Looks good to me! Will merge soon, if no one else has comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35930342
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35930343
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12831/
---
If you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35923428
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35923427
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35920859
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35919353
Let's just try it again - Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35887433
I'm not able to reproduce [this
failure](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12819/testReport/)
locally (either with my patch atop 4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35849112
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35849113
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12820/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847834
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847835
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847506
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847507
One or more automated tests failed
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12819/
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35845761
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35845760
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please t
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35837078
Yes, I'll make the changes today. Thanks, Aaron!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. T
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35817227
There is some desire to get this change in as we have a PR in the pipeline
that will use our JSON serialization library more heavily to serialize and log
SparkL
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34931526
Thanks for the review, Aaron! After others have weighed in, I'll amend my
branch to catch the right exception (and correct my email address).
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34922638
This looks good to me, only significant change is correcting the thrown
exception. I am somewhat underwhelmed by json4s's documentation. For instance,
this file
Sounds good, now that we are all clear on what we mean. Didn't mean to be
a dick, just was a little confused on what you meant.
On Tue, Feb 11, 2014 at 8:08 PM, Patrick Wendell wrote:
> I think Aaron just meant 1.0.0 by "the next minor release".
>
> On Tue, Feb 11, 2014 at 7:56 PM, Mark Hamstr
I think Aaron just meant 1.0.0 by "the next minor release".
On Tue, Feb 11, 2014 at 7:56 PM, Mark Hamstra wrote:
>>
>> The situation sounds fine for the next minor release...
>
>
> I don't understand what you mean by this. According to my current
> understanding, the next release of Spark other
My apologies, my intention was that it is fine for the next minor
*or*major release, regardless of what comes next. I only wanted to
distinguish
that from the next maintenance release, since my understanding is that we
wish to avoid changing dependencies during maintenance releases.
On Tue, Feb 1
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34836430
Thanks for looking into it! The situation sounds fine for the next minor
release, and I don't think this patch needs to be included in the next
maintenance rele
>
> The situation sounds fine for the next minor release...
I don't understand what you mean by this. According to my current
understanding, the next release of Spark other than maintenance releases on
0.9.x is intended to be a major release, 1.0.0, and there are no plans for
an intervening mino
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34834423
The current version of json4s-jackson depends on paranamer 2.6, while the
current version of lift-json depends on 2.4.1. That's the only difference that
winds up
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34829822
Does json4s-jackson include any dependencies that lift-json doesn't? Does
the versioning match?
It seems that this version of json4s-jackson pulls in ja
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34804701
Merged build finished.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34804702
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12680/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34801416
Merged build started.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34801415
Merged build triggered.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34801246
Jenkins, add to whitelist.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34799861
Can one of the admins verify this patch?
GitHub user willb opened a pull request:
https://github.com/apache/incubator-spark/pull/582
SPARK-1078: Replace lift-json with json4s-jackson.
The aim of the Json4s project is to provide a common API for
Scala JSON libraries. It is Apache-licensed, easier for
downstream dis
34 matches
Mail list logo