Review Request 23047: SQOOP-1138 incremental lastmodified should re-use output directory

2014-06-26 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23047/ --- Review request for Sqoop. Bugs: HUE-1138 https://issues.apache.org/jira/bro

Re: Review Request 23047: SQOOP-1138 incremental lastmodified should re-use output directory

2014-06-26 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23047/#review46767 --- Ship it! THANK YOU!!! This bug was so annoying. Thanks for nailing

[jira] [Created] (SQOOP-1343) Sqoop2: Provide validation utilities

2014-06-26 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-1343: --- Summary: Sqoop2: Provide validation utilities Key: SQOOP-1343 URL: https://issues.apache.org/jira/browse/SQOOP-1343 Project: Sqoop Issue Type: Bug

Re: Review Request 23047: SQOOP-1138 incremental lastmodified should re-use output directory

2014-06-26 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23047/ --- (Updated June 26, 2014, 6:23 p.m.) Review request for Sqoop. Bugs: SQOOP-1138

[jira] [Updated] (SQOOP-1138) incremental lastmodified should re-use output directory

2014-06-26 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-1138: Attachment: SQOOP-1138.0.patch > incremental lastmodified should re-use output directory >

[jira] [Assigned] (SQOOP-1138) incremental lastmodified should re-use output directory

2014-06-26 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek reassigned SQOOP-1138: --- Assignee: Abraham Elmahrek > incremental lastmodified should re-use output directory

Re: Review Request 23047: SQOOP-1138 incremental lastmodified should re-use output directory

2014-06-26 Thread Kathleen Ting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23047/#review46813 --- Thanks Abe for picking this up. I suspect the incremental lastmodifi

Re: Review Request 18452: Add high performance Oracle connector into Sqoop

2014-06-26 Thread David Robson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18452/ --- (Updated June 27, 2014, 12:24 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 18452: Add high performance Oracle connector into Sqoop

2014-06-26 Thread David Robson
> On June 26, 2014, 4:54 a.m., Venkat Ranganathan wrote: > > Thanks for this large contribution. Even though I would love more > > integration as I mentioned in the earlier review, I think this is ready for > > committing as we have already made it part of the --direct option. > > > > One

[jira] [Created] (SQOOP-1344) Add documentation for Oracle connector

2014-06-26 Thread David Robson (JIRA)
David Robson created SQOOP-1344: --- Summary: Add documentation for Oracle connector Key: SQOOP-1344 URL: https://issues.apache.org/jira/browse/SQOOP-1344 Project: Sqoop Issue Type: Task

[jira] [Created] (SQOOP-1345) Merge the two Oracle connectors into one

2014-06-26 Thread David Robson (JIRA)
David Robson created SQOOP-1345: --- Summary: Merge the two Oracle connectors into one Key: SQOOP-1345 URL: https://issues.apache.org/jira/browse/SQOOP-1345 Project: Sqoop Issue Type: Task

Re: Review Request 18452: Add high performance Oracle connector into Sqoop

2014-06-26 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18452/#review46826 --- +1 on committing as is and leaving more work in separate JIRAs. The

Re: Review Request 18452: Add high performance Oracle connector into Sqoop

2014-06-26 Thread David Robson
> On June 27, 2014, 1:52 a.m., Gwen Shapira wrote: > > +1 on committing as is and leaving more work in separate JIRAs. > > The implementation as is adds value and won't cause regressions. I have raised one issue in regards to merging the connectors / refactoring: https://issues.apache.org/jira/

Re: Review Request 18452: Add high performance Oracle connector into Sqoop

2014-06-26 Thread David Robson
> On Feb. 26, 2014, 6:37 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/ConnFactory.java, lines 74-76 > > > > > > I would like to eventually see the OraOopManagerFactory merged into the > > DefaultManagerFactor