Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/ --- (Updated Oct. 19, 2017, 10:25 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

> On Oct. 19, 2017, 9:10 a.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java > > Line 86 (original), 91 (patched) > > > > > > This is an example of "shown as changed" because of

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

> On Sept. 29, 2017, 9:41 a.m., Szabolcs Vasas wrote: > > Hi Chris, > > > > Thank you for improving the patch and the description of the datasets! > > I have left few more comments and I can see that there are still some > > whitespace changes (they are shown by ReviewBoard as well) can you ple

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

> On Sept. 29, 2017, 10:27 a.m., Boglarka Egyed wrote: > > Hi Chris, > > > > Thanks for your patch! > > > > I ran unit tests with your patch and TestMainframeDatasetInputFormat test > > case failed for me with the following error message: > > > > [ERROR - > > org.apache.sqoop.util.MainframeF

Re: Review Request 62653: SQOOP-3225: Mainframe module FTP listing parser should cater for larger datasets on disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review188652 --- Hi Chris, Thanks for addressing review findinds in your new patch