Re: Review Request 66300: Upgrade to Hadoop 3.0.0

> On March 28, 2018, 3:44 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/mapreduce/hcat/DerbyPolicy.java > > Lines 69 (patched) > > > > > > Can we use List interface and diamond operator here? Fixed, pleas

Re: Review Request 66353: Connection resource related issues in DBOutputFormat and OracleManager

> On March 29, 2018, 9:32 a.m., Fero Szabo wrote: > > src/java/org/apache/sqoop/manager/OracleManager.java > > Lines 334-336 (patched) > > > > > > You probably missed some spaces here :) > > Fero Szabo wrote: >

Re: Review Request 66353: Connection resource related issues in DBOutputFormat and OracleManager

> On April 3, 2018, 9:13 a.m., Szabolcs Vasas wrote: > > Hi László, > > > > Thank you for submitting this improvement, it is a nice catch! > > It looks good to me however it would be great if you could create a couple > > of unit test cases to cover the code you have added. > > > > Thanks, > >

Re: Review Request 66353: Connection resource related issues in DBOutputFormat and OracleManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66353/#review200344 --- Hi László, Thank you for submitting this improvement, it is a nic