Re: Review Request 55132: support for DB2 XML data type when importing to hdfs

2017-02-08 Thread Abraham Elmahrek
/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (lines 218 - 220) <https://reviews.apache.org/r/55132/#comment236578> Is this necessary? - Abraham Elmahrek On Feb. 6, 2017, 3:19 a.m., Ying Cao wrote: > > --- > This is an automatically

Re: Release 1.5 (maybe 1.4.7 ? ), CI, build system, etc.

2016-12-05 Thread Abraham Elmahrek
Attila, I think improving build infrastructure for Sqoop makes a lot of sense. I think focusing on build system and tests works. Please be cognizant of the following: - Docs for Sqoop1 and Sqoop2 are built in different ways. It might be interesting to update how docs are built in Sqoop1.

[jira] [Commented] (SQOOP-2349) Transaction isolation level for metadata queries should be mutable

2016-11-21 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684526#comment-15684526 ] Abraham Elmahrek commented on SQOOP-2349: - [~maugli] Patch seems good except

Re: Review Request 53423: SQOOP-2349 Transaction isolation level for metadata queries should be mutable

2016-11-21 Thread Abraham Elmahrek
ases (PDW and SQL Server for example). I haven't looked recently, but is this a problem with other databases other than SQL Server esque DBs? You could probably move forward with this patch and think about this later. - Abraham Elmahrek On Nov. 10, 2016,

Re: [ANNOUNCE] New Sqoop PMC member - Abe Fine

2016-11-10 Thread Abraham Elmahrek
Awesome Abe! On Thu, Nov 10, 2016 at 10:50 AM Boglarka Egyed wrote: > Congratulations Abe, nice work! > > 2016. nov. 10. du. 4:47 ezt írta ("Szabolcs Vasas" ): > > > Congratulations, Abe, well done! > > > > > > > > On Thu, Nov 10, 2016 at 3:39 PM, Attila Szabo wrote: > > > >> Congrats Abe! > >>

Re: New Sqoop Committer - Attila Szabo

2016-08-10 Thread Abraham Elmahrek
Congrats Attila. On Tue, Aug 9, 2016 at 2:37 PM Markus Kemper wrote: > Awesome news Attila, congrats! > > > Markus Kemper > Customer Operations Engineer > [image: www.cloudera.com] > > > On Tue, Aug 9, 2016 at 2:46 PM, Boglarka Egyed wrote: > > > Congratulations, Attil

Re: Sqoop 1.99.7

2016-05-20 Thread Abraham Elmahrek
+1 for a new release. On Fri, May 20, 2016 at 7:08 AM Jarek Jarcec Cecho wrote: > Any volunteers to drive that release? :) > > Jarcec > > > On May 18, 2016, at 1:49 PM, Abraham Fine wrote: > > > > I agree. > > > > > >> On May 18, 2016, at 11:24, Jarek Jarcec Cecho > wrote: > >> > >> +dev@sqoop

Re: New Sqoop Committer - Abraham Fine

2016-03-02 Thread Abraham Elmahrek
Congrats man! On Tue, Mar 1, 2016, 12:08 Jarek Jarcec Cecho wrote: > On behalf of Apache Sqoop PPMC, I am excited to welcome Abraham Fine as a > new committer on Apache Sqoop. Please join me in gratulations! > > Abe has added several new features, most notably Parquet support to HDFS > connector

[jira] [Commented] (SQOOP-1493) Add ability to import/export true decimal in Avro instead of serializing it to String

2016-01-29 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124184#comment-15124184 ] Abraham Elmahrek commented on SQOOP-1493: - Thanks for committing this [~ja

[jira] [Commented] (SQOOP-1493) Add ability to import/export true decimal in Avro instead of serializing it to String

2016-01-27 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120074#comment-15120074 ] Abraham Elmahrek commented on SQOOP-1493: - Please take it [~jarcec]! &

Re: New Sqoop Committer - Dian Fu

2016-01-13 Thread Abraham Elmahrek
Congratulations Dian :). On Tue, Jan 12, 2016 at 7:47 AM Jarek Jarcec Cecho wrote: > On behalf of Apache Sqoop PPMC, I am excited to welcome Dian Fu as a new > committer on Apache Sqoop. Please join me in gratulations! > > Dian has been contributing since early June last year. He have a lot of >

Re: New Sqoop Committer - Colin Ma

2016-01-13 Thread Abraham Elmahrek
Congratulations Colin! -Abe On Tue, Jan 12, 2016 at 7:46 AM Jarek Jarcec Cecho wrote: > On behalf of Apache Sqoop PPMC, I am excited to welcome Colin Ma as a new > committer on Apache Sqoop. Please join me in gratulations! > > Colin has started contributing to Sqoop project last August and he p

[jira] [Commented] (SQOOP-2651) Do not dump data on error in TextExportMapper by default

2015-11-08 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995557#comment-14995557 ] Abraham Elmahrek commented on SQOOP-2651: - Generally +1. Should the flag b

Re: Review Request 40049: SQOOP-2670 Sqoop2: RESTiliency: Allow getting links by connector only for all

2015-11-07 Thread Abraham Elmahrek
ent164229> 404? test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java (line 220) <https://reviews.apache.org/r/40049/#comment164230> 400? - Abraham Elmahrek On Nov. 7, 2015, 11:25 p.m.,

[jira] [Commented] (SQOOP-2672) Sqoop2: Remove double dependency on mockito in shell module

2015-11-07 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995550#comment-14995550 ] Abraham Elmahrek commented on SQOOP-2672: - +1. Thanks [~jarcec]. >

Re: Sqoop developer meetup

2015-10-13 Thread Abraham Elmahrek
t;>>> > >>>>>> On Mon, Oct 5, 2015 at 8:31 AM, Jarek Jarcec Cecho > >>>>>> > >>>>>> wrote: > >>>>>> > >>>>>>> I’ve dropped a ball on this discuss a bit, so my apologies for &g

Re: Sqoop developer meetup

2015-09-17 Thread Abraham Elmahrek
Sounds good to me as well :). On Thu, Sep 17, 2015 at 10:38 AM SenthilBharani Bogana Vijay < bvsent...@gmail.com> wrote: > Sounds very good. I am newbie to the group, it will be useful for several > of the newbies like me to meet other developers and understand the > community better. > Thanks >

Re: About switch Tomcat to Jetty

2015-09-09 Thread Abraham Elmahrek
+1 to jetty. There was also a patch to add a jetty minicluster: https://issues.apache.org/jira/browse/SQOOP-2104. -Abe On Wed, Sep 9, 2015 at 12:33 AM Jarek Jarcec Cecho wrote: > I’m supportive of the idea to migrate from Tomcat to Jetty - +1 and thank > you for picking it up Colin! > > Jarcec

Re: SQOOP2 : delimter option for JDBC connector

2015-09-04 Thread Abraham Elmahrek
Hey there, These features hasn't been implemented yet, but it definitely can be implemented (https://issues.apache.org/jira/browse/SQOOP-1522 to start). If you're interested, I'd ask Richard if you could pick up this Jira. -Abe On Thu, Sep 3, 2015 at 8:20 PM Adline Dsilva wrote: > Hi, > >I

[jira] [Updated] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory and provider

2015-08-28 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2543: Attachment: (was: SQOOP-2543.patch) > Sqoop2: Create sqoop mini cluster factory

[jira] [Updated] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory and provider

2015-08-28 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2543: Attachment: SQOOP-2543.patch > Sqoop2: Create sqoop mini cluster factory and provi

[jira] [Updated] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory and provider

2015-08-28 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2543: Summary: Sqoop2: Create sqoop mini cluster factory and provider (was: Sqoop2: Create sqoop

[jira] [Created] (SQOOP-2543) Sqoop2: Create sqoop mini cluster factory

2015-08-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2543: --- Summary: Sqoop2: Create sqoop mini cluster factory Key: SQOOP-2543 URL: https://issues.apache.org/jira/browse/SQOOP-2543 Project: Sqoop Issue Type

[jira] [Created] (SQOOP-2541) Sqoop2: Provide test infrastructure base class for upgrade tests

2015-08-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2541: --- Summary: Sqoop2: Provide test infrastructure base class for upgrade tests Key: SQOOP-2541 URL: https://issues.apache.org/jira/browse/SQOOP-2541 Project: Sqoop

[jira] [Created] (SQOOP-2542) Sqoop2: Provide test infrastructure base class for connector tests

2015-08-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2542: --- Summary: Sqoop2: Provide test infrastructure base class for connector tests Key: SQOOP-2542 URL: https://issues.apache.org/jira/browse/SQOOP-2542 Project

[jira] [Created] (SQOOP-2535) Add error handling to HiveConf

2015-08-27 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2535: --- Summary: Add error handling to HiveConf Key: SQOOP-2535 URL: https://issues.apache.org/jira/browse/SQOOP-2535 Project: Sqoop Issue Type: Bug

[jira] [Commented] (SQOOP-2507) Sqoop2: Do not use default Tomcat handlers for unsupported HTTP methods

2015-08-26 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715403#comment-14715403 ] Abraham Elmahrek commented on SQOOP-2507: - [~jarcec] the patch needs reba

Re: Review Request 37599: SQOOP-2507 Sqoop2: Do not use default Tomcat handlers for unsupported HTTP methods

2015-08-26 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37599/#review96584 --- Ship it! Ship It! - Abraham Elmahrek On Aug. 19, 2015, 1:15 a.m

Re: Review Request 37596: SQOOP-2441 Sqoop2: Generic JDBC: Drop support for specifying custom query when exporting data

2015-08-24 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37596/#review96206 --- Ship it! Ship It! - Abraham Elmahrek On Aug. 20, 2015, 4:21 p.m

Re: Review Request 37718: SQOOP-2505 Sqoop2: Add ability to specify custom configuration properties for HDFS connector

2015-08-24 Thread Abraham Elmahrek
s.java#L308). - Abraham Elmahrek On Aug. 24, 2015, 5:19 p.m., Jarek Cecho wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 37672: SQOOP-2516: Sqoop2: Findbugs: Fix warning in execution module

2015-08-24 Thread Abraham Elmahrek
> On Aug. 21, 2015, 9 p.m., Abraham Elmahrek wrote: > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java, > > line 94 > > <https://reviews.apache.org/r/37672/diff/1/?file=1046557#file1046557line94> > > > > Charset.

[jira] [Commented] (SQOOP-2505) Sqoop2: Add ability to specify custom configuration properties for HDFS connector

2015-08-21 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707481#comment-14707481 ] Abraham Elmahrek commented on SQOOP-2505: - Manually submitted precommit

Re: Review Request 37596: SQOOP-2441 Sqoop2: Generic JDBC: Drop support for specifying custom query when exporting data

2015-08-21 Thread Abraham Elmahrek
(line 35) <https://reviews.apache.org/r/37596/#comment151307> Maybe add a test here to show that the removal works. - Abraham Elmahrek On Aug. 20, 2015, 4:21 p.m., Jarek Cecho wrote: > > --- > This is an automatically g

Re: Review Request 37674: SQOOP-2518: Sqoop2: Findbugs: Fix warning in repository-derby module

2015-08-21 Thread Abraham Elmahrek
for development: http://sqoop.apache.org/docs/1.99.6/DevEnv.html#java. - Abraham Elmahrek On Aug. 21, 2015, 8:04 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 37675: SQOOP-2519: Sqoop2: Findbugs: Fix warning in repository-postgresql module

2015-08-21 Thread Abraham Elmahrek
for development: http://sqoop.apache.org/docs/1.99.6/DevEnv.html#java. - Abraham Elmahrek On Aug. 21, 2015, 8:07 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 37673: SQOOP-2517: Sqoop2: Findbugs: Fix resource leak problem in CommonRepositoryHandler

2015-08-21 Thread Abraham Elmahrek
Java 6 should be supported for development: http://sqoop.apache.org/docs/1.99.6/DevEnv.html#java. - Abraham Elmahrek On Aug. 21, 2015, 7:59 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 37672: SQOOP-2516: Sqoop2: Findbugs: Fix warning in execution module

2015-08-21 Thread Abraham Elmahrek
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java (line 76) <https://reviews.apache.org/r/37672/#comment151299> Might not be necessary if we create a constructor that consumes a partition? Also, error handling is missing.

[jira] [Updated] (SQOOP-2364) Sqoop2: Provide test infrastructure base class for server tests

2015-08-20 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2364: Attachment: SQOOP-2364.patch > Sqoop2: Provide test infrastructure base class for ser

Re: Review Request 34509: Sqoop2: Provide test infrastructure base class for server tests

2015-08-20 Thread Abraham Elmahrek
--- Precommit passes, but need one more patch to reduce the number of tests running. Bugs: SQOOP-2364 https://issues.apache.org/jira/browse/SQOOP-2364 Repository: sqoop-sqoop2 Description --- commit d5117886e7be68c6a40fb28cd4c0020fab977052 Author: Abraham Elmahrek Date: Fri May 15

[jira] [Commented] (SQOOP-2480) Sqoop2: Provide ability to add entire Map instance to our MutableMapContext

2015-08-20 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1470#comment-1470 ] Abraham Elmahrek commented on SQOOP-2480: - +1 > Sqoop2: Provide ability

[jira] [Commented] (SQOOP-2460) Sqoop2: Refactor repository-common to use methods

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704258#comment-14704258 ] Abraham Elmahrek commented on SQOOP-2460: - +1. Thanks [~colin_mjj] and [~dia

[jira] [Commented] (SQOOP-2460) Sqoop2: Refactor repository-common to use methods

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704255#comment-14704255 ] Abraham Elmahrek commented on SQOOP-2460: - Oy... sorry folks. I pulled the w

[jira] [Updated] (SQOOP-2460) Sqoop2: Refactor repository-common to use methods

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2460: Summary: Sqoop2: Refactor repository-common to use methods (was: Sqoop2: Refactor

[jira] [Updated] (SQOOP-2460) Sqoop2: Refactor repository-common for external DB as repository

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2460: Summary: Sqoop2: Refactor repository-common for external DB as repository (was: Sqoop2

[jira] [Updated] (SQOOP-2460) Sqoop2: Refactor repository-common to make sqoop2 easy to use external DB as repository

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2460: Summary: Sqoop2: Refactor repository-common to make sqoop2 easy to use external DB as

Re: Review Request 37120: SQOOP-2460: Refactor repository-common to make sqoop2 easy to use external DB as repository

2015-08-19 Thread Abraham Elmahrek
SelectQuery. Seems like an interface for no reason. - Abraham Elmahrek On Aug. 10, 2015, 8:08 a.m., Colin Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

[jira] [Commented] (SQOOP-2461) Sqoop2: Add MySQL support for the metadata repository

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703880#comment-14703880 ] Abraham Elmahrek commented on SQOOP-2461: - [~colin_mjj], I'm ok shippin

Re: Review Request 37121: SQOOP-2461: Add sqoop-repository-mysql to support MySql for the metadata repository

2015-08-19 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37121/#review95890 --- Ship it! Ship It! - Abraham Elmahrek On Aug. 14, 2015, 6:35 a.m

Re: Review Request 37121: SQOOP-2461: Add sqoop-repository-mysql to support MySql for the metadata repository

2015-08-19 Thread Abraham Elmahrek
> On Aug. 13, 2015, 8:41 p.m., Abraham Elmahrek wrote: > > repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java, > > line 84 > > <https://reviews.apache.org/r/37121/diff/2/?file=1035984#file1035984line84> >

Re: [ANNOUNCE] Change in Apache Sqoop PMC Chair

2015-08-19 Thread Abraham Elmahrek
Congrats Jarcec! Thanks for your hard work over the years Arvind! On Wed, Aug 19, 2015 at 3:39 PM Arvind Prabhakar wrote: > Dear Sqoop Users and Developers, > > I have had the pleasure of serving as the PMC Chair of Apache Sqoop since > its graduation three years ago. I sincerely thank you and

[jira] [Commented] (SQOOP-2364) Sqoop2: Provide test infrastructure base class for server tests

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703825#comment-14703825 ] Abraham Elmahrek commented on SQOOP-2364: - [~jarcec] updated the patch. Hopef

Re: Review Request 34509: Sqoop2: Provide test infrastructure base class for server tests

2015-08-19 Thread Abraham Elmahrek
-2364 https://issues.apache.org/jira/browse/SQOOP-2364 Repository: sqoop-sqoop2 Description --- commit d5117886e7be68c6a40fb28cd4c0020fab977052 Author: Abraham Elmahrek Date: Fri May 15 16:10:17 2015 -0700 SQOOP-2364: Sqoop2: Provide test infrastructure base class for server tests

[jira] [Updated] (SQOOP-2364) Sqoop2: Provide test infrastructure base class for server tests

2015-08-19 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2364: Attachment: SQOOP-2364.patch > Sqoop2: Provide test infrastructure base class for ser

[jira] [Updated] (SQOOP-2461) Sqoop2: Add MySQL support for the metadata repository

2015-08-17 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2461: Summary: Sqoop2: Add MySQL support for the metadata repository (was: Add sqoop-repository

Re: Review Request 37463: SQOOP-2480 Sqoop2: Provide ability to add entire Map instance to our MutableMapContext

2015-08-17 Thread Abraham Elmahrek
/TestMutableMapContext.java (line 80) <https://reviews.apache.org/r/37463/#comment150744> One other test that might be useful is one that performs "setAll", except on a map that has some of the keys set. The current implementation should overwrite those keys it seems. - Abrah

[jira] [Updated] (SQOOP-2491) Sqoop2: Common external JAR handling in configuration

2015-08-17 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2491: Attachment: SQOOP-2491.patch > Sqoop2: Common external JAR handling in configurat

Re: Review Request 37539: SQOOP-2491: Sqoop2: Common external JAR handling in configuration

2015-08-17 Thread Abraham Elmahrek
Thanks, Abraham Elmahrek

Re: Review Request 37539: SQOOP-2491: Sqoop2: Common external JAR handling in configuration

2015-08-17 Thread Abraham Elmahrek
Thanks, Abraham Elmahrek

Re: Review Request 37539: SQOOP-2491: Sqoop2: Common external JAR handling in configuration

2015-08-17 Thread Abraham Elmahrek
out getting set of string for given key. Let's perhaps rename it as such? True! Changed to getArrayOfUniqueStrings! - Abraham --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37539/#review95614

Re: Review Request 34509: Sqoop2: Provide test infrastructure base class for server tests

2015-08-17 Thread Abraham Elmahrek
-2364 https://issues.apache.org/jira/browse/SQOOP-2364 Repository: sqoop-sqoop2 Description --- commit d5117886e7be68c6a40fb28cd4c0020fab977052 Author: Abraham Elmahrek Date: Fri May 15 16:10:17 2015 -0700 SQOOP-2364: Sqoop2: Provide test infrastructure base class for server tests

[jira] [Updated] (SQOOP-2364) Sqoop2: Provide test infrastructure base class for server tests

2015-08-17 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2364: Attachment: SQOOP-2364.patch > Sqoop2: Provide test infrastructure base class for ser

[jira] [Updated] (SQOOP-2491) Sqoop2: Common external JAR handling in configuration

2015-08-17 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2491: Attachment: SQOOP-2491.patch > Sqoop2: Common external JAR handling in configurat

Review Request 37539: SQOOP-2491: Sqoop2: Common external JAR handling in configuration

2015-08-17 Thread Abraham Elmahrek
fc722c0 common/src/test/java/org/apache/sqoop/common/TestMapContext.java 2a27c0c core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 58c4c34 Diff: https://reviews.apache.org/r/37539/diff/ Testing --- mvn test Thanks, Abraham Elmahrek

[jira] [Commented] (SQOOP-2492) Sqoop2: getNestedProperties() in MapContext puts key instead of value

2015-08-14 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697757#comment-14697757 ] Abraham Elmahrek commented on SQOOP-2492: - This works. Could you change the t

[jira] [Created] (SQOOP-2491) Sqoop2: Common external JAR handling in configuration

2015-08-14 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2491: --- Summary: Sqoop2: Common external JAR handling in configuration Key: SQOOP-2491 URL: https://issues.apache.org/jira/browse/SQOOP-2491 Project: Sqoop

[jira] [Commented] (SQOOP-2488) Sqoop2: Precommit hook is using incorrect string insertion

2015-08-14 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697385#comment-14697385 ] Abraham Elmahrek commented on SQOOP-2488: - +1 > Sqoop2: Precommit hook i

[jira] [Created] (SQOOP-2490) Sqoop2: Add extra jars to job

2015-08-14 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2490: --- Summary: Sqoop2: Add extra jars to job Key: SQOOP-2490 URL: https://issues.apache.org/jira/browse/SQOOP-2490 Project: Sqoop Issue Type: Improvement

[jira] [Created] (SQOOP-2489) Sqoop2: Hive with Parquet in Kite Connector

2015-08-14 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2489: --- Summary: Sqoop2: Hive with Parquet in Kite Connector Key: SQOOP-2489 URL: https://issues.apache.org/jira/browse/SQOOP-2489 Project: Sqoop Issue Type

Review Request 37459: SQOOP-2479: Sqoop2: Pass configuration objects to Intermediate Data Format

2015-08-13 Thread Abraham Elmahrek
https://issues.apache.org/jira/browse/SQOOP-2479 Repository: sqoop-sqoop2 Description --- commit 51d6814242ef8ea15998bde5b067a2409e326f33 Author: Abraham Elmahrek Date: Thu Feb 26 13:34:34 2015 -0800 SQOOP-2479: Sqoop2: Pass configuration objects to Intermediate Data Format :100644

[jira] [Updated] (SQOOP-2479) Sqoop2: Pass configuration objects to Intermediate Data Format

2015-08-13 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2479: Attachment: SQOOP-2479.patch > Sqoop2: Pass configuration objects to Intermediate D

[jira] [Created] (SQOOP-2479) Sqoop2: Pass configuration objects to Intermediate Data Format

2015-08-13 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2479: --- Summary: Sqoop2: Pass configuration objects to Intermediate Data Format Key: SQOOP-2479 URL: https://issues.apache.org/jira/browse/SQOOP-2479 Project: Sqoop

[jira] [Commented] (SQOOP-2478) Sqoop2: Downgrade cobertura plugin to version 2.6

2015-08-13 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696127#comment-14696127 ] Abraham Elmahrek commented on SQOOP-2478: - +1 > Sqoop2: Downgrade co

Re: Review Request 34509: Sqoop2: Provide test infrastructure base class for server tests

2015-08-13 Thread Abraham Elmahrek
-2364 https://issues.apache.org/jira/browse/SQOOP-2364 Repository: sqoop-sqoop2 Description --- commit d5117886e7be68c6a40fb28cd4c0020fab977052 Author: Abraham Elmahrek Date: Fri May 15 16:10:17 2015 -0700 SQOOP-2364: Sqoop2: Provide test infrastructure base class for server tests

[jira] [Commented] (SQOOP-2469) Sqoop2: Custom HTTP requests test base class

2015-08-13 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695927#comment-14695927 ] Abraham Elmahrek commented on SQOOP-2469: - +1. Thanks [~jarcec] for the code

[jira] [Updated] (SQOOP-2469) Sqoop2: Custom HTTP requests test base class

2015-08-13 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2469: Summary: Sqoop2: Custom HTTP requests test base class (was: Sqoop2: Provide base

[jira] [Commented] (SQOOP-2477) Sqoop2: Add protection for HTTP error 404 to precommit hook

2015-08-13 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695920#comment-14695920 ] Abraham Elmahrek commented on SQOOP-2477: - Seems cool: +1. > Sqoo

Re: Review Request 37121: SQOOP-2461: Add sqoop-repository-mysql to support MySql for the metadata repository

2015-08-13 Thread Abraham Elmahrek
va (lines 31 - 39) <https://reviews.apache.org/r/37121/#comment150228> This info isn't necessary any more given we have it in the repository docs. Maybe we need a separate Jira to remove from the other places as well? - Abraham Elmahrek On Aug. 10, 2015, 8:35 a.m., Colin Ma

[jira] [Commented] (SQOOP-2476) Sqoop2: Fix failing precommit hook

2015-08-13 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695830#comment-14695830 ] Abraham Elmahrek commented on SQOOP-2476: - +1 > Sqoop2: Fix failing pr

[jira] [Updated] (SQOOP-2364) Sqoop2: Provide test infrastructure base class for server tests

2015-08-12 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2364: Attachment: SQOOP-2364.patch > Sqoop2: Provide test infrastructure base class for ser

Re: Review Request 34509: Sqoop2: Provide test infrastructure base class for server tests

2015-08-12 Thread Abraham Elmahrek
-2364 https://issues.apache.org/jira/browse/SQOOP-2364 Repository: sqoop-sqoop2 Description --- commit d5117886e7be68c6a40fb28cd4c0020fab977052 Author: Abraham Elmahrek Date: Fri May 15 16:10:17 2015 -0700 SQOOP-2364: Sqoop2: Provide test infrastructure base class for server tests

[jira] [Commented] (SQOOP-2443) Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-12 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694241#comment-14694241 ] Abraham Elmahrek commented on SQOOP-2443: - Test failures don't seem rele

Re: Review Request 37380: SQOOP-2443 Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-12 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37380/#review95184 --- Ship it! Ship It! - Abraham Elmahrek On Aug. 12, 2015, 8:10 p.m

Re: Review Request 37380: SQOOP-2443 Sqoop2: Generic JDBC: Properly detect compound primary keys in GenericJdbcExecutor

2015-08-12 Thread Abraham Elmahrek
(line 145) <https://reviews.apache.org/r/37380/#comment149982> Wondering if we can add debug logging about which primary key column was used specifically. - Abraham Elmahrek On Aug. 12, 2015, 2:18 a.m., Jarek Cecho wrote: > > -

[jira] [Commented] (SQOOP-2450) Sqoop2: Precommit: Introduce findbugs checks

2015-08-12 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693800#comment-14693800 ] Abraham Elmahrek commented on SQOOP-2450: - +1. Thanks man. > Sqoop2: Pr

Re: Review Request 37015: SQOOP-2450 Sqoop2: Precommit: Introduce findbugs checks

2015-08-11 Thread Abraham Elmahrek
> On Aug. 11, 2015, 1:05 a.m., Abraham Elmahrek wrote: > > dev-support/test-patch.py, line 422 > > <https://reviews.apache.org/r/37015/diff/1/?file=1027096#file1027096line422> > > > > A note on python style: > >if not summary: > >

Re: Review Request 37015: SQOOP-2450 Sqoop2: Precommit: Introduce findbugs checks

2015-08-10 Thread Abraham Elmahrek
ch.py (line 422) <https://reviews.apache.org/r/37015/#comment149471> A note on python style: if not summary: ... Would also work! - Abraham Elmahrek On Aug. 1, 2015, 5:26 p.m., Jarek

Re: Review Request 36918: SQOOP-2244 Sqoop2: Generic JDBC: Automatically escape table and column names from configuration objects

2015-08-10 Thread Abraham Elmahrek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36918/#review94794 --- Ship it! Ship It! - Abraham Elmahrek On July 31, 2015, 3:17 p.m

[jira] [Commented] (SQOOP-2446) Sqoop2: Fix incorrect notification URL for execution engine

2015-08-10 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680719#comment-14680719 ] Abraham Elmahrek commented on SQOOP-2446: - Also +1. Thanks [~jarcec]

[jira] [Commented] (SQOOP-1256) Sqoop2: Tool: Load repository dump into a different repository

2015-07-29 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647255#comment-14647255 ] Abraham Elmahrek commented on SQOOP-1256: - +1. Thanks man! > Sqoop2: Too

[jira] [Commented] (SQOOP-2452) Sqoop2: Findbugs: Convert anonymous class in ResourceRequest to static inner class

2015-07-29 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647057#comment-14647057 ] Abraham Elmahrek commented on SQOOP-2452: - +1 > Sqoop2: Findbugs:

Re: Review Request 36923: SQOOP-2449 Sqoop2: Findbugs: Fix smaller-ish warnings in common module

2015-07-29 Thread Abraham Elmahrek
/validators/CSVURIValidator.java (line 34) <https://reviews.apache.org/r/36923/#comment147924> I think we have a cool class for this: StringUtils.isNullOrEmpty(). - Abraham Elmahrek On July 29, 2015, 10:27 p.m., Jarek Cecho

[jira] [Commented] (SQOOP-2447) Sqoop2: Precommit: Improve cobertura test coverage reporting

2015-07-29 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647049#comment-14647049 ] Abraham Elmahrek commented on SQOOP-2447: - +1 > Sqoop2: Precommit:

Re: Review Request 36918: SQOOP-2244 Sqoop2: Generic JDBC: Automatically escape table and column names from configuration objects

2015-07-29 Thread Abraham Elmahrek
reviews.apache.org/r/36918/#comment147921> Doesn't seem like escaping per-say, but quoting? - Abraham Elmahrek On July 29, 2015, 5:11 p.m., Jarek Cecho wrote: > > --- > This is an automatically generated e-mail. To reply,

[jira] [Updated] (SQOOP-2437) Use hive configuration to connect to secure metastore

2015-07-28 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2437: Attachment: SQOOP-2437.patch > Use hive configuration to connect to secure metast

Re: Review Request 36901: SQOOP-2437: Use hive configuration to connect to secure metastore

2015-07-28 Thread Abraham Elmahrek
-2437 https://issues.apache.org/jira/browse/SQOOP-2437 Repository: sqoop-trunk Description --- commit c7d17c641e01cbe55eceec294c2f34d7fe91f8c4 Author: Abraham Elmahrek Date: Tue Jul 28 17:35:45 2015 -0700 SQOOP-2437: Use hive configuration to connect to secure metastore :00

[jira] [Created] (SQOOP-2438) Use Class.cast when creating HiveConf object in ParquetJob

2015-07-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2438: --- Summary: Use Class.cast when creating HiveConf object in ParquetJob Key: SQOOP-2438 URL: https://issues.apache.org/jira/browse/SQOOP-2438 Project: Sqoop

[jira] [Updated] (SQOOP-2437) Use hive configuration to connect to secure metastore

2015-07-28 Thread Abraham Elmahrek (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Elmahrek updated SQOOP-2437: Attachment: SQOOP-2437.patch > Use hive configuration to connect to secure metast

Review Request 36901: SQOOP-2437: Use hive configuration to connect to secure metastore

2015-07-28 Thread Abraham Elmahrek
/browse/SQOOP-2437 Repository: sqoop-trunk Description --- commit c7d17c641e01cbe55eceec294c2f34d7fe91f8c4 Author: Abraham Elmahrek Date: Tue Jul 28 17:35:45 2015 -0700 SQOOP-2437: Use hive configuration to connect to secure metastore :00 100644 000... 3d08176... A src

[jira] [Created] (SQOOP-2437) Use hive configuration to connect to secure metastore

2015-07-28 Thread Abraham Elmahrek (JIRA)
Abraham Elmahrek created SQOOP-2437: --- Summary: Use hive configuration to connect to secure metastore Key: SQOOP-2437 URL: https://issues.apache.org/jira/browse/SQOOP-2437 Project: Sqoop

Re: Dropping support for JDK6

2015-07-28 Thread Abraham Elmahrek
+1 On Tue, Jul 28, 2015 at 9:00 AM, Venkat Ranganathan < vranganat...@hortonworks.com> wrote: > +1 > > > > > On 7/28/15, 8:24 AM, "Jarek Jarcec Cecho" jar...@apache.org> wrote: > > >Hi All, > >JDK6 has been officially put end of life by Oracle more then 2 years ago > (February 2013). Other proje

  1   2   3   4   5   6   7   8   9   10   >