Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-07-01 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- Remove unused imports. Bugs: SQOOP-675 https://issues.apache.org/jira/browse/SQOOP-675 Repository: sqoop-sqoop2 Description (updated) --- commit 93eeb1225d6be0d95783ce6da5b8fd6e3d9fe986 Author: Mengwei Ding Date: Wed Jun 19 17

Re: Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for transferred data

2013-07-01 Thread Mengwei Ding
> On July 1, 2013, 4:36 p.m., Mengwei Ding wrote: > > common/src/main/java/org/apache/sqoop/schema/Schema.java, line 20 > > <https://reviews.apache.org/r/12092/diff/2/?file=313292#file313292line20> > > > > Hi, Jarce, I find a tiny error her

Re: Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for transferred data

2013-07-01 Thread Mengwei Ding
tps://reviews.apache.org/r/12092/#comment46307> Hi, Jarce, I find a tiny error here. I think the StringUtils in the org.apache.commons.utils package rather than the lang package. - Mengwei Ding On June 29, 2013, 9:11 p.m., Jarek Cecho

Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-07-01 Thread Mengwei Ding
I update this code review. Now, fixed. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11983/#review22541 ------

Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-28 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- improved the documentation. Bugs: SQOOP-675 https://issues.apache.org/jira/browse/SQOOP-675 Repository: sqoop-sqoop2 Description (updated) --- commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7 Author: Mengwei Ding Date: Wed Jun

[jira] [Updated] (SQOOP-1100) Sqoop2: Missing setBoolean() method for MutableContext interface

2013-06-26 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1100: Attachment: SQOOP-1100.1.patch > Sqoop2: Missing setBoolean() method for MutableCont

Review Request 12113: SQOOP-1100 SQOOP2: Add missing setBoolean() method for MutableContext

2013-06-26 Thread Mengwei Ding
. Bugs: SQOOP-1100 https://issues.apache.org/jira/browse/SQOOP-1100 Repository: sqoop-sqoop2 Description --- commit 85198e81fafabd03bbbdbd93b517a808c00bfda0 Author: Mengwei Ding Date: Tue Jun 25 13:27:07 2013 -0700 SQOOP-1100 SQOOP2: Add missing setBoolean() method for

[jira] [Updated] (SQOOP-675) Sqoop2: Substitute submission command with top level commands start, stop and status

2013-06-26 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-675: --- Attachment: SQOOP-675.3.patch > Sqoop2: Substitute submission command with top level comma

Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-26 Thread Mengwei Ding
/client/shell/SubmissionStopFunction.java c407d01 client/src/main/resources/client-resource.properties 8a570a1 docs/src/site/sphinx/CommandLineClient.rst a14898f Diff: https://reviews.apache.org/r/11983/diff/ Testing --- Done several manual test for all these 3 commands and their options. Thanks, Mengwei Ding

[jira] [Updated] (SQOOP-1099) Sqoop2: Missing hadoop jar exceptions should be logged in sqoop.log

2013-06-25 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1099: Assignee: Mengwei Ding > Sqoop2: Missing hadoop jar exceptions should be logged in sqoop.

[jira] [Created] (SQOOP-1100) Sqoop2: Missing setBoolean() method for MutableContext interface

2013-06-25 Thread Mengwei Ding (JIRA)
Mengwei Ding created SQOOP-1100: --- Summary: Sqoop2: Missing setBoolean() method for MutableContext interface Key: SQOOP-1100 URL: https://issues.apache.org/jira/browse/SQOOP-1100 Project: Sqoop

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-24 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Attachment: SQOOP-971.4.patch > Sqoop2: Component reconfigurabil

[jira] [Updated] (SQOOP-1088) Sqoop2: Submission history API

2013-06-21 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1088: Attachment: SQOOP-1088.3.patch > Sqoop2: Submission history

Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-21 Thread Mengwei Ding
r the future. Cool. I wat thinking about this too. And your suggestions make thing easier. :) - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11983/#review22281 --- On June 21, 2013,

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-21 Thread Mengwei Ding
, Hari Shreedharan, and Abraham Elmahrek. Changes --- add more unit test cases for TestSubmissionBean. Description (updated) --- commit 7e11dd64165daae5297c843055041edb2803f5da Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-21 Thread Mengwei Ding
t; > "--details"?) yes, that's exactly what I mean. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11952/#review22263 ------- On June 19, 2013, 6:59 p.m., Mengwei Ding wr

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-21 Thread Mengwei Ding
sit: https://reviews.apache.org/r/11952/#review22263 --- On June 19, 2013, 6:59 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To re

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-21 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Attachment: SQOOP-971.3.patch > Sqoop2: Component reconfigurabil

[jira] [Updated] (SQOOP-675) Sqoop2: Substitute submission command with top level commands start, stop and status

2013-06-21 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-675: --- Attachment: SQOOP-675.2.patch > Sqoop2: Substitute submission command with top level comma

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-21 Thread Mengwei Ding
ea52e9 server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 1c40fc1 Diff: https://reviews.apache.org/r/11920/diff/ Testing --- Thanks, Mengwei Ding

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-21 Thread Mengwei Ding
t's ok to apply the new configuration changes to the repository at this time. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11920/#review22137 --------

Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-21 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Changes --- Move parseOptions() and getLong() static methods to a new created util class "OptionParser". Description (updated) --- commit 5cc954a0e8594a1ddd667d06cc438100b44fe234 Author: Mengwei Ding Date: Wed Jun 19 17:56:57

Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-20 Thread Mengwei Ding
ility class? Yes, I do think so! Thank you, Abe. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11983/#review22190 --- On June

[jira] [Updated] (SQOOP-675) Sqoop2: Substitute submission command with top level commands start, stop and status

2013-06-20 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-675: --- Attachment: SQOOP-675.1.patch > Sqoop2: Substitute submission command with top level comma

Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-19 Thread Mengwei Ding
. Description --- commit a8f82e64b4787ae48aa5b1b1beeb10214cc1e175 Author: Mengwei Ding Date: Wed Jun 19 17:56:57 2013 -0700 SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds. :100644 100644 056fcc8... 1020209... M clie

[jira] [Updated] (SQOOP-1088) Sqoop2: Submission history API

2013-06-19 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1088: Attachment: SQOOP-1088.2.patch > Sqoop2: Submission history

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-19 Thread Mengwei Ding
t;--jid" option for `show submission` command Description (updated) --- commit 2800218fb1e6336b635e6ae85071f344d4a8a3dd Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`) :100644 100644 9c7b35

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-19 Thread Mengwei Ding
tion (updated) --- commit 445bb5ec9c96f363f1c586d9ff534726c049a1cc Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`) :100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClie

[jira] [Updated] (SQOOP-675) Sqoop2: Substitute submission command with top level commands start, stop and status

2013-06-19 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-675: --- Assignee: Mengwei Ding > Sqoop2: Substitute submission command with top level commands st

[jira] [Updated] (SQOOP-1092) Sqoop2: Submission history API - provide client shell function `show submission`

2013-06-18 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1092: Description: Make the shell environment support looking up all submissions, like job, connection

[jira] [Created] (SQOOP-1091) Sqoop2: Submission history API - provide SqoopClient programming API

2013-06-18 Thread Mengwei Ding (JIRA)
Mengwei Ding created SQOOP-1091: --- Summary: Sqoop2: Submission history API - provide SqoopClient programming API Key: SQOOP-1091 URL: https://issues.apache.org/jira/browse/SQOOP-1091 Project: Sqoop

[jira] [Created] (SQOOP-1092) Sqoop2: Submission history API - provide client shell function `show submission`

2013-06-18 Thread Mengwei Ding (JIRA)
Mengwei Ding created SQOOP-1092: --- Summary: Sqoop2: Submission history API - provide client shell function `show submission` Key: SQOOP-1092 URL: https://issues.apache.org/jira/browse/SQOOP-1092 Project

[jira] [Updated] (SQOOP-1091) Sqoop2: Submission history API - provide SqoopClient programming API

2013-06-18 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1091: Description: Provide the SqoopClient programming APIs to lookup all job submission history

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Changes --- Sorry, just remove several useless imports. Description (updated) --- commit 7fc5ae741cbe74e3f9aa50138dadfc3fdb594cbd Author: Mengwei Ding Date: Wed Jun 12 15:47:26 2013 -0700 SQOOP-971 Add dynamic reconfiguration ability to

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-18 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Attachment: (was: SQOOP-971.2.patch) > Sqoop2: Component reconfigurabil

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-18 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Attachment: SQOOP-971.2.patch > Sqoop2: Component reconfigurabil

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-18 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Attachment: SQOOP-971.2.patch > Sqoop2: Component reconfigurabil

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
, Hari Shreedharan, and Abraham Elmahrek. Changes --- Made improvements according to Jarcec's comments. Thank you, Jarcec. Description (updated) --- commit 934b7a7a860fdfffabe2f06ca89530fe2d083d7f Author: Mengwei Ding Date: Wed Jun 12 15:47:26 2013 -0700 SQOOP-971 Add dy

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/11920/#review22027 ------- On June 17, 2013, 10:33 p.m., Mengwei Ding wrote: > > --- > This is an automatically genera

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
-- > > (Updated June 17, 2013, 10:33 p.m.) > > > Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek. > > > Description > --- > > commit 719aeaab2cd74338399f43c411f7dccd95089c7b > Author: Mengwei Ding &g

[jira] [Updated] (SQOOP-1088) Sqoop2: Submission history API

2013-06-18 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1088: Attachment: SQOOP-1088.1.patch > Sqoop2: Submission history

Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-18 Thread Mengwei Ding
. Description --- commit 6367bd9781040a77a355a2728c0e365338eb497e Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`) :100644 100644 9c7b351... 0c5a596... M client/src/main/java/org/apache

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-17 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Attachment: SQOOP-971.1.patch > Sqoop2: Component reconfigurabil

Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-17 Thread Mengwei Ding
. Description --- commit 719aeaab2cd74338399f43c411f7dccd95089c7b Author: Mengwei Ding Date: Wed Jun 12 15:47:26 2013 -0700 SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager :100644 100644 500189a... 5ea1ab3... M core/src/main

[jira] [Updated] (SQOOP-1088) Sqoop2: Submission history API

2013-06-17 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1088: Assignee: Mengwei Ding > Sqoop2: Submission history

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-14 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Attachment: SQOOP-971.1.pdf > Sqoop2: Component reconfigurabil

Re: Review Request: SQOOP-1006 Update year in the notice file to 2013

2013-06-13 Thread Mengwei Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10692/#review21892 --- Ship it! Ship It! - Mengwei Ding On April 21, 2013, 8:38 p.m

[jira] [Updated] (SQOOP-1081) destroy() method of ConnectorManager has not been implemented yet.

2013-06-13 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1081: Attachment: SQOOP-1081.1.patch > destroy() method of ConnectorManager has not been implemen

Review Request: SQOOP-1081 implement destroy() function for ConnectorManager in sqoop-core

2013-06-13 Thread Mengwei Ding
. Description --- commit fe17874e419a328ad16d21b541d9c919c91d9e95 Author: Mengwei Ding Date: Thu Jun 13 17:37:03 2013 -0700 SQOOP-1081 implement destroy() function for ConnectorManager in sqoop-core :100644 100644 27ec754... 500189a... M core/src/main/java/org/apache/sqoop/connector

[jira] [Created] (SQOOP-1081) destroy() method of ConnectorManager has not been implemented yet.

2013-06-13 Thread Mengwei Ding (JIRA)
Mengwei Ding created SQOOP-1081: --- Summary: destroy() method of ConnectorManager has not been implemented yet. Key: SQOOP-1081 URL: https://issues.apache.org/jira/browse/SQOOP-1081 Project: Sqoop

[jira] [Updated] (SQOOP-971) Sqoop2: Component reconfigurability

2013-06-10 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-971: --- Assignee: Mengwei Ding > Sqoop2: Component reconfigurabil

[jira] [Updated] (SQOOP-1069) Incorrect error message from FrameworkValidator

2013-06-06 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1069: Attachment: SQOOP-1069.1.patch > Incorrect error message from FrameworkValida

Review Request: correct an error message from FrameworkValidator

2013-06-06 Thread Mengwei Ding
--- commit 511f5c15595f9292056bec1718087a166abd637e Author: Mengwei Ding Date: Thu Jun 6 16:05:30 2013 -0700 correct an error message from FrameworkValidator :100644 100644 a42363d... d72b9f8... M core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java This addresses bug

[jira] [Created] (SQOOP-1069) Incorrect error message from FrameworkValidator

2013-06-06 Thread Mengwei Ding (JIRA)
Mengwei Ding created SQOOP-1069: --- Summary: Incorrect error message from FrameworkValidator Key: SQOOP-1069 URL: https://issues.apache.org/jira/browse/SQOOP-1069 Project: Sqoop Issue Type: Bug

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11561/#review21495 --- On June 5, 2013, 5:27 p.m., Mengwei Ding wrote: > >

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-05 Thread Mengwei Ding
-mail. To reply, visit: https://reviews.apache.org/r/11535/#review21496 --- On June 5, 2013, 6:01 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail.

[jira] [Updated] (SQOOP-973) Sqoop2: Merge host, port and app to single server URL in Sqoop shell

2013-06-05 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-973: --- Attachment: (was: SQOOP-1028.2.patch) > Sqoop2: Merge host, port and app to single server

[jira] [Updated] (SQOOP-973) Sqoop2: Merge host, port and app to single server URL in Sqoop shell

2013-06-05 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-973: --- Attachment: SQOOP-973.2.patch SQOOP-1028.2.patch > Sqoop2: Merge host, port

[jira] [Updated] (SQOOP-1028) Remove poll timeout parameter from Sqoop shell synchronous submission

2013-06-05 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1028: Attachment: SQOOP-1028.3.patch > Remove poll timeout parameter from Sqoop shell synchron

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-05 Thread Mengwei Ding
plications. For example, 'set server --url http://localhost:12000/sqoop' Description (updated) --- commit 31a39620c4f102f0eb23958a571d220ee5aa721d Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enab

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Changes --- Add a more specific description for "poll-timeout" option. Description (updated) --- commit d7787293082b398511b7d331fdd12c7ca682dc03 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove po

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
ted) --- commit d7787293082b398511b7d331fdd12c7ca682dc03 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constan

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-05 Thread Mengwei Ding
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11535/#review21450 ------- On June 4, 2013, 11:22 p.m., Mengwei Ding wrote: > > -

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
a default value, why not simply return? That way, the > > default value will not be hard coded in multiple files. > > Mengwei Ding wrote: > Yeah, this is a good one. I had another thought about this issue, Abe. The reason why I did not directly return is that for any new va

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
----- On June 4, 2013, 11:46 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11561/ > ---

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-04 Thread Mengwei Ding
default and notify the user by one line output. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11561/#review21449 ------- On June 4, 2013, 11:46 p.m., Mengwei Ding wrote: > > ---

[jira] [Updated] (SQOOP-973) Sqoop2: Merge host, port and app to single server URL in Sqoop shell

2013-06-04 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-973: --- Attachment: SQOOP-973.1.patch > Sqoop2: Merge host, port and app to single server URL in Sq

[jira] [Updated] (SQOOP-1028) Remove poll timeout parameter from Sqoop shell synchronous submission

2013-06-04 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1028: Attachment: SQOOP-1028.2.patch > Remove poll timeout parameter from Sqoop shell synchron

[jira] [Updated] (SQOOP-973) Sqoop2: Merge host, port and app to single server URL in Sqoop shell

2013-06-04 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-973: --- Attachment: (was: SQOOP-973.1.batch) > Sqoop2: Merge host, port and app to single server

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-04 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description (updated) --- commit 6d2a4bb0331210cda99d571579705084b12fb357 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop :100644 100644 979b892.

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-04 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description (updated) --- commit 67ccd56d492ac4910c28376f7be0bcaad4e5cbdb Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more cons

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-04 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description --- commit 67ccd56d492ac4910c28376f7be0bcaad4e5cbdb Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistan

Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://loca

2013-06-04 Thread Mengwei Ding
. Description --- commit 67ccd56d492ac4910c28376f7be0bcaad4e5cbdb Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For exam

Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://loca

2013-06-04 Thread Mengwei Ding
. Description --- commit b15c944cc52937d5c51c7f921ab685db7fb59a2b Author: Mengwei Ding Date: Tue Jun 4 15:10:03 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For exam

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-03 Thread Mengwei Ding
ort number constant? If not, I think it should be > > so that it can be referenced by other methods. > > Mengwei Ding wrote: > At the very first beginning of this file, the default port and webapp are > also set in this way. I checked the references of default port,

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-03 Thread Mengwei Ding
ot; command. > > > > Jarcec Sure, I will definitely do this. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11535/#review21297 ----

Re: Review Request: SQOOP-1062: correct a misspell error

2013-05-30 Thread Mengwei Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11562/#review21223 --- Ship it! Ship It! - Mengwei Ding On May 30, 2013, 11:55 p.m

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-05-30 Thread Mengwei Ding
imeout(); - Mengwei Ding On May 30, 2013, 11:42 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-05-30 Thread Mengwei Ding
tps://reviews.apache.org/r/11561/#review21216 ------- On May 30, 2013, 11:42 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail.

[jira] [Updated] (SQOOP-973) Sqoop2: Merge host, port and app to single server URL in Sqoop shell

2013-05-30 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-973: --- Attachment: SQOOP-973.1.batch > Sqoop2: Merge host, port and app to single server URL in Sq

[jira] [Updated] (SQOOP-1028) Remove poll timeout parameter from Sqoop shell synchronous submission

2013-05-30 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1028: Attachment: SQOOP-1028.1.patch > Remove poll timeout parameter from Sqoop shell synchron

[jira] [Updated] (SQOOP-1062) Misspell in "isVerboose()" method, it should be "isVerbose()"

2013-05-30 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1062: Attachment: SQOOP-1062.1.patch > Misspell in "isVerboose()" method, it should

Review Request: SQOOP-1062: correct a misspell error

2013-05-30 Thread Mengwei Ding
. Description --- commit 311e87f170ded0ff365027358e7909b6a24427ff Author: Mengwei Ding Date: Thu May 30 16:45:53 2013 -0700 SQOOP-1062: correct a misspell error 'isVerboose()' :100644 100644 f6d1267... 5dbcef5... M client/src/main/java/org/apache/sqoop/cl

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-05-30 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description --- commit 4e011751033d565b8817edfe04757d9104e2f3a0 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop :100644 100644 979b892... 86

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-05-30 Thread Mengwei Ding
in the Constants.java or even in property files. However, there is no similar constant variable existing in any of these 2 files. So I really have no idea which way, these 2 or some other ways, is better. - Mengwei Ding On May 30, 2013, 11:36 p.m., Mengwei Ding

Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-05-30 Thread Mengwei Ding
. Description --- commit 4e011751033d565b8817edfe04757d9104e2f3a0 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop :100644 100644 979b892... 866f3b8... M client/src/main/java/org/ap

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-05-30 Thread Mengwei Ding
gt; (Updated May 30, 2013, 3:14 a.m.) > > > Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek. > > > Description > --- > > commit 42577e8b5e2de3c987dfd99d462a4e766f617729 > Author: Mengwei Ding > Date: Wed May 29 18:04:53 2013

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-05-30 Thread Mengwei Ding
;s been referenced in no other place. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11535/#review21175 ------

[jira] [Updated] (SQOOP-1028) Remove poll timeout parameter from Sqoop shell synchronous submission

2013-05-30 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1028: Assignee: Mengwei Ding > Remove poll timeout parameter from Sqoop shell synchronous submiss

[jira] [Created] (SQOOP-1062) Misspell in "isVerboose()" method, it should be "isVerbose()"

2013-05-30 Thread Mengwei Ding (JIRA)
Mengwei Ding created SQOOP-1062: --- Summary: Misspell in "isVerboose()" method, it should be "isVerbose()" Key: SQOOP-1062 URL: https://issues.apache.org/jira/browse/SQOOP-1062

[jira] [Updated] (SQOOP-1062) Misspell in "isVerboose()" method, it should be "isVerbose()"

2013-05-30 Thread Mengwei Ding (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mengwei Ding updated SQOOP-1062: Remaining Estimate: (was: 24h) Original Estimate: (was: 24h) > Misspell

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-05-29 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description --- commit 42577e8b5e2de3c987dfd99d462a4e766f617729 Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way

Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://loca

2013-05-29 Thread Mengwei Ding
. Description --- commit 42577e8b5e2de3c987dfd99d462a4e766f617729 Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For exam

Review Request: SQOOP-1039 ShowVersionFunction default action for 'show version'

2013-05-23 Thread Mengwei Ding
. Description --- commit 445fc43b8a451fc968adbd956cd5cc62d26c46e2 Author: Mengwei Ding Date: Thu May 23 17:47:12 2013 -0700 SQOOP-1039 ShowVersionFunction default action for 'show version' :100644 100644 1038116... 7586e13... M client/src/main/java/org/apache/sqoop/cl

<    1   2   3