://github.com/apache/sqoop/pull/42
> Removing com.cloudera.sqoop packages
>
>
> Key: SQOOP-3273
> URL: https://issues.apache.org/jira/browse/SQOOP-3273
> Project: Sqoop
> Is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195572
---
Ship it!
Hi Szabi,
Thanks for removing these deprecated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195323
---
Ship it!
Hi Szabi,
Thanks for correcting my findings on the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195227
---
Ship it!
Hi Szabi,
This is great, it helps a lot with the
Hi Attila,
Thank you for reviewing this patch so quickly!
I have talked to Anna, she is going to review it very soon and post on
ReviewBoard.
Yes, I wanted to push this as one commit to trunk using the patch file, the
small commits were only for reviewing.
Szabolcs
On Tue, Jan 9, 2018 at 3:46
Hey Szabi,
Souds great!
Two comments:
AFAIR Anna Szonyi was also planning to do something similar last January
(when she was busy around the build system, tests, gradle, etc.). It would
make sense on my side, to reach out to her, maybe she's got some useful
feedbacks for you too.
I've opened an
[
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szabolcs Vasas updated SQOOP-3273:
--
Attachment: SQOOP-3273.patch
> Removing com.cloudera.sqoop packa
> On Jan. 9, 2018, 1:46 p.m., Attila Szabo wrote:
> > IMHO build.xml line 1098 (after this patch applied) should be also removed
> > (this is an entry for the src/com/cloudera/sqoop directory to be included
> > in the javadoc generation).
> >
> > Otherwise the patch looks okay, but please let
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/
---
(Updated Jan. 9, 2018, 2:25 p.m.)
Review request for Sqoop.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/#review195030
---
IMHO build.xml line 1098 (after this patch applied) should be
[
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szabolcs Vasas updated SQOOP-3273:
--
Attachment: SQOOP-3273.patch
> Removing com.cloudera.sqoop packa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/
---
(Updated Jan. 9, 2018, 12:52 p.m.)
Review request for Sqoop.
Changes
---
Hi Szabi,
I believe this is a great idea.
By removing these packages we will get rid of a great deal of technical
debt that will simplify future change. I will also help to avoid
unnecessary conversions like the ones I had to use in my recent
SqoopOptions related change.
So, also +1 from me!
Hi Szabolcs,
I really welcome this initiative, it would be a huge clean up on this
project!
I already took a look at your pull request and it indeed looks pretty
straightforward.
I will perform a deeper review and publish it on the Review Board otherwise
+1 from my side for the idea in general,
Hi All,
As you probably know we still have dozens of classes in com.cloudera.sqoop
packages which most of the cases just extend their corresponding class in
org.apache.sqoop package without adding extra functionality.
These classes make the code harder to read and navigate, they are already
[
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szabolcs Vasas updated SQOOP-3273:
--
Attachment: SQOOP-3273.patch
> Removing com.cloudera.sqoop packa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65017/
---
Review request for Sqoop.
Bugs: SQOOP-3273
t used anymore.
commit 406817dadebb41433bc7ae21420bc9aff30f9891
Author: Szabolcs Vasas <vasas@...>
Date: 2017-12-18T12:57:30Z
com.cloudera.sqoop.lib.SqoopRecord is not used anymore.
commit feacaf3ad09e0c33f5b2b3bc3f7dc067bf7ae50e
Author: S
Szabolcs Vasas created SQOOP-3273:
-
Summary: Removing com.cloudera.sqoop packages
Key: SQOOP-3273
URL: https://issues.apache.org/jira/browse/SQOOP-3273
Project: Sqoop
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SQOOP-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szabolcs Vasas reassigned SQOOP-3273:
-
Assignee: Szabolcs Vasas
> Removing com.cloudera.sqoop packa
20 matches
Mail list logo
