Re: Review Request: import tool for mysql direct mode reports wrong record number

2012-05-04 Thread Cheolsoo Park
> On 2012-05-04 18:36:37, Cheolsoo Park wrote: > > Nemon's fix seems to be right to me. The write() method should be called > > only once per record. I also verified that his patch addresses the problem. > > > > @Nemon > > I am no commiter, so I cannot commit your patch. But you've got my vote!

Re: Review Request: import tool for mysql direct mode reports wrong record number

2012-05-04 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4988/#review7580 --- Ship it! Nemon's fix seems to be right to me. The write() method shou

Re: Review Request: import tool for mysql direct mode reports wrong record number

2012-05-04 Thread Kathleen Ting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4988/#review7581 --- Ship it! +1 Nemon, thanks for the patch. Noticed that the timestamp

Re: Review Request: import tool for mysql direct mode reports wrong record number

2012-05-04 Thread nemon lou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4988/ --- (Updated 2012-05-04 07:33:48.277299) Review request for Sqoop, Jarek Cecho and C

Re: Review Request: import tool for mysql direct mode reports wrong record number

2012-05-03 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4988/#review7546 --- Thank you very much for your patch. It looks good, but there are two m

Re: Review Request: import tool for mysql direct mode reports wrong record number

2012-05-03 Thread nemon lou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4988/ --- (Updated 2012-05-04 01:02:58.521635) Review request for Sqoop, Jarek Cecho and C

Re: Review Request: import tool for mysql direct mode reports wrong record number

2012-05-03 Thread nemon lou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4988/#review7500 --- - nemon On 2012-05-03 10:57:29, nemon lou wrote: > > --

Review Request: import tool for mysql direct mode reports wrong record number

2012-05-03 Thread nemon lou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4988/ --- Review request for Sqoop and Jarek Cecho. Summary --- I simply change the w