---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
---
(Updated Aug. 14, 2013, 5:32 p.m.)
Review request for Sqoop, Abraham Elmahrek,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review25180
---
Hi Mengwei,
thank you for incorporating all the changes! It seems
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
---
(Updated Aug. 14, 2013, 8:42 p.m.)
Review request for Sqoop, Abraham Elmahrek,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review25190
---
Ship it!
Ship It!
- Jarek Cecho
On Aug. 14, 2013, 8:42 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review25108
---
Hi Mengwei,
would you mind rebasing the patch on current HEAD of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
---
(Updated Aug. 2, 2013, 9:36 p.m.)
Review request for Sqoop, Abraham Elmahrek,
On July 28, 2013, 3:43 p.m., Jarek Cecho wrote:
common/src/main/java/org/apache/sqoop/common/EventContext.java, line 18
https://reviews.apache.org/r/12713/diff/4/?file=327466#file327466line18
This class seems to be strictly related to server component and as a
result should not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review24060
---
Hi Mengwei,
thank you very much for incorporating my feedback. I do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
---
(Updated July 23, 2013, 6:44 p.m.)
Review request for Sqoop, Abraham Elmahrek,
On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
common/src/main/java/org/apache/sqoop/json/ConnectionBean.java, line 107
https://reviews.apache.org/r/12713/diff/2/?file=323233#file323233line107
Nit: The other constants seems to be created with underscore, so I
would suggest to
On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
common/src/main/java/org/apache/sqoop/json/ConnectionBean.java, line 109
https://reviews.apache.org/r/12713/diff/2/?file=323233#file323233line109
Nit: The other constants seems to be create with underscore, so I would
suggest to
On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java, line 41
https://reviews.apache.org/r/12713/diff/2/?file=323237#file323237line41
Nit: The phrase last update by seems weird. I would either suggest to
say last
On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
core/src/main/java/org/apache/sqoop/framework/JobManager.java, line 265
https://reviews.apache.org/r/12713/diff/2/?file=323241#file323241line265
I do have concern that adding new parameter each time we will need to
add new
On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java,
lines 258-276
https://reviews.apache.org/r/12713/diff/2/?file=323244#file323244line258
This is backward incompatible change that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
---
Hi Mengwei,
thank you very much for looking into this! I do have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
---
(Updated July 18, 2013, 5:09 p.m.)
Review request for Sqoop, Abraham Elmahrek,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
---
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
17 matches
Mail list logo
