Review Request 13338: SQOOP-921: Sqoop2: Create standalone shell package

2013-08-06 Thread Mengwei Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13338/ --- Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.

Re: Review Request 13338: SQOOP-921: Sqoop2: Create standalone shell package

2013-08-06 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13338/#review24760 --- Ship it! This looks good, though I'd like to revisit some of the er

Re: Review Request 13338: SQOOP-921: Sqoop2: Create standalone shell package

2013-08-07 Thread Mengwei Ding
> On Aug. 6, 2013, 11:19 p.m., Hari Shreedharan wrote: > > This looks good, though I'd like to revisit some of the error code > > separation between the client module and the shell module. I think some of > > those in Shell needs to move to client and also that any duplicates should > > be rem