Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/#review108429 --- Ship it! Ship It! - Dian Fu On Dec. 1, 2015, 12:25 a.m., Jarek

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/#review108426 --- Ship it! Ship It! - Abraham Fine On Dec. 1, 2015, 12:25 a.m., J

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/ --- (Updated Dec. 1, 2015, 12:25 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Jarek Cecho
> On Nov. 30, 2015, 8:51 p.m., Mike Yoder wrote: > > Thanks for the review Mike! Good point, we definitely don't want to be leaking sensitive data. I've actually got the idea of logging the delegation token from Hadoop code base where it seems we're doing that a lot. I had the same concern, b

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Jarek Cecho
> On Nov. 30, 2015, 5:58 p.m., Abraham Fine wrote: > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java, > > line 62 > > > > > > creating the proxy user and then generatin

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Aaron Myers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/#review108412 --- Ship it! Looks good to me, pending addressing my one comment (and

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/#review108409 --- connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Mike Yoder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/#review108347 --- connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Jarek Cecho
> On Nov. 25, 2015, 3:33 a.m., Dian Fu wrote: > > > > Dian Fu wrote: > For the integration test, I'm currently working on SQOOP-2704 to enable > kerberos in the integration tests. I will add tests for this scenario under > that JIRA. You're awesome, thank you Dian! > On Nov. 25, 2015, 3

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-30 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/#review108340 --- connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-24 Thread Dian Fu
> On Nov. 25, 2015, 3:33 a.m., Dian Fu wrote: > > For the integration test, I'm currently working on SQOOP-2704 to enable kerberos in the integration tests. I will add tests for this scenario under that JIRA. - Dian --- This is an aut

Re: Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-24 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/#review107910 --- connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/

Review Request 40625: SQOOP-2709 Sqoop2: HDFS: Impersonation on secured cluster doesn't work

2015-11-23 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40625/ --- Review request for Sqoop. Bugs: SQOOP-2709 https://issues.apache.org/jira/b