Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-03 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/#review117756 --- Ship it! Provided precommmit hook will be happy. - Jarek Cecho

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-03 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/ --- (Updated Feb. 4, 2016, 3:02 a.m.) Review request for Sqoop and Colin Ma. Bugs

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-03 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/#review117752 --- Thanks for updating the JIRA description to correspond to "new" sc

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-03 Thread Jarek Cecho
> On Feb. 2, 2016, 8:54 p.m., Jarek Cecho wrote: > > common/src/main/java/org/apache/sqoop/schema/type/Blob.java, line 20 > > > > > > What is the difference between Blob and Binary? Aren't they the same? > > Colin Ma

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-02 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/ --- (Updated Feb. 3, 2016, 7:54 a.m.) Review request for Sqoop and Colin Ma. Bugs

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-02 Thread Colin Ma
> On Feb. 2, 2016, 8:54 p.m., Jarek Cecho wrote: > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java, > > lines 343-344 > > > > > > Why are we skipping Blob? For the skipping Blob, b

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-02 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/ --- (Updated Feb. 3, 2016, 7:11 a.m.) Review request for Sqoop and Colin Ma. Bugs

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-02-02 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/#review117465 --- common-test/src/main/java/org/apache/sqoop/common/test/asserts/Pr

Re: Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-01-25 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/ --- (Updated Jan. 26, 2016, 4:55 a.m.) Review request for Sqoop and Colin Ma. Bug

Review Request 42776: SQOOP-2797: Sqoop2: Datatypes: Add Blob data type support for Derby

2016-01-25 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42776/ --- Review request for Sqoop and Colin Ma. Bugs: SQOOP-2797 https://issues.apac