Re: Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

2016-12-08 Thread Anna Szonyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54540/#review158582 --- Ship it! Hey Attila, Thanks for the clarification! I've ran

Re: Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

2016-12-08 Thread Attila Szabo
> On Dec. 8, 2016, 9:34 p.m., Anna Szonyi wrote: > > Hi Attila, > > > > Thanks for finding this! Generally I prefer to leave comments out of code, > > however as this is a very particular use-case and the solution is > > non-trivial, in my opinion it would be useful to add a line or two of >

Re: Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

2016-12-08 Thread Attila Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54540/ --- (Updated Dec. 8, 2016, 9:53 p.m.) Review request for Sqoop and Anna Szonyi.

Re: Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

2016-12-08 Thread Anna Szonyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54540/#review158574 --- Hi Attila, Thanks for finding this! Generally I prefer to leave

Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale

2016-12-08 Thread Attila Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54540/ --- Review request for Sqoop and Anna Szonyi. Bugs: SQOOP-3074