Review Request 57576: SQOOP-3152 - --map-column-hive to support DECIMAL(xx, xx)

2017-03-13 Thread Eric Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57576/ --- Review request for Sqoop, Attila Szabo and Szabolcs Vasas. Repository: sqoop-tr

Re: Review Request 57576: SQOOP-3152 - --map-column-hive to support DECIMAL(xx, xx)

2017-03-18 Thread Boglarka Egyed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57576/#review169366 --- Ship it! Hi Eric, Your change looks good to me, however, could

Re: Review Request 57576: SQOOP-3152 - --map-column-hive to support DECIMAL(xx, xx)

2017-03-20 Thread Eric Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57576/ --- (Updated March 20, 2017, 8:25 a.m.) Review request for Sqoop, Attila Szabo and

Re: Review Request 57576: SQOOP-3152 - --map-column-hive to support DECIMAL(xx, xx)

2017-03-20 Thread Eric Lin
> On March 18, 2017, 1:46 p.m., Boglarka Egyed wrote: > > Hi Eric, > > > > Your change looks good to me, however, could you please add a Hive import > > test case too for your change for example in TestHiveImport class? > > > > Many thanks, > > Bogi Test case added in class TestHiveImport -

Re: Review Request 57576: SQOOP-3152 - --map-column-hive to support DECIMAL(xx, xx)

2017-03-20 Thread Attila Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57576/#review169451 --- Ship it! Hey Eric, It's a great thing you've spot this issue,