Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review201413 --- Ship it! Ship It! - Fero Szabo On April 17, 2018, 10:14 a.m.

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/ --- (Updated April 17, 2018, 10:14 a.m.) Review request for Sqoop. Changes --

Re: Review Request 66361: Implement HiveServer2 client

> On April 16, 2018, 12:51 p.m., Fero Szabo wrote: > > src/java/org/apache/sqoop/hive/HiveClientFactory.java > > Lines 54 (patched) > > > > > > I think you mentioned that this is package-private visibility so it can

Re: Review Request 66361: Implement HiveServer2 client

> On April 16, 2018, 12:51 p.m., Fero Szabo wrote: > > src/java/org/apache/sqoop/hive/HiveServer2Client.java > > Lines 88 (patched) > > > > > > Why not put this into a finally statement? No need to clean up after > >

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review201208 --- Ship it! Thanks for fixing my findigs! I left one comment regar

Re: Review Request 66361: Implement HiveServer2 client

> On April 16, 2018, 12:51 p.m., Fero Szabo wrote: > > src/java/org/apache/sqoop/tool/BaseSqoopTool.java > > Lines 136 (patched) > > > > > > I'm fine with abbreviations, however these might confuse those reading > >

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review201202 --- Ship it! Ship It! - daniel voros On April 16, 2018, 9:12 a.m

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review201189 --- src/java/org/apache/sqoop/hive/HiveClientFactory.java Lines 54 (p

Re: Review Request 66361: Implement HiveServer2 client

> On April 6, 2018, 3:49 p.m., Fero Szabo wrote: > > src/java/org/apache/sqoop/hive/HiveServer2Client.java > > Lines 75 (patched) > > > > > > Is the package private visibility intentional? > > > > Also applie

Re: Review Request 66361: Implement HiveServer2 client

> On April 13, 2018, 2:33 p.m., daniel voros wrote: > > Hey Szabolcs, > > > > I'm trying to run the latest patch on a (non-kerberized) cluster, but I get > > the following: > > > > ``` > > 18/04/13 13:50:47 INFO hive.HiveServer2ConnectionFactory: Creating > > connection to HiveServer2 as: hdf

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/ --- (Updated April 16, 2018, 9:12 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 66361: Implement HiveServer2 client

> On April 13, 2018, 2:33 p.m., daniel voros wrote: > > Hey Szabolcs, > > > > I'm trying to run the latest patch on a (non-kerberized) cluster, but I get > > the following: > > > > ``` > > 18/04/13 13:50:47 INFO hive.HiveServer2ConnectionFactory: Creating > > connection to HiveServer2 as: hdf

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review201101 --- Hey Szabolcs, I'm trying to run the latest patch on a (non-kerber

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/ --- (Updated April 12, 2018, 2:10 p.m.) Review request for Sqoop. Changes ---

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/ --- (Updated April 12, 2018, 1:51 p.m.) Review request for Sqoop. Changes ---

Re: Review Request 66361: Implement HiveServer2 client

> On April 6, 2018, 3:49 p.m., Fero Szabo wrote: > > src/java/org/apache/sqoop/hive/HiveServer2Client.java > > Lines 75 (patched) > > > > > > Is the package private visibility intentional? > > > > Also applie

Re: Review Request 66361: Implement HiveServer2 client

> On April 6, 2018, 1:39 p.m., Boglarka Egyed wrote: > > src/java/org/apache/sqoop/hive/HiveServer2ConnectionFactory.java > > Lines 55 (patched) > > > > > > Why did you include only the message here not the exception

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/ --- (Updated April 10, 2018, 9:40 a.m.) Review request for Sqoop. Changes ---

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review200554 --- src/java/org/apache/sqoop/hive/HiveServer2Client.java Lines 75 (p

Re: Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/#review200552 --- src/java/org/apache/sqoop/hive/HiveServer2ConnectionFactory.java

Review Request 66361: Implement HiveServer2 client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66361/ --- Review request for Sqoop. Bugs: SQOOP-3309 https://issues.apache.org/jira/b