Martin Sebor wrote:
Travis Vitek wrote:
Martin Sebor wrote:
Eric Lemings wrote:
Travis,
If you could, give the following patch a whirl (or quick review
at least).
Is there an easier way to silence the warning than by adding
all these loops? E.g., by assigning the address of the first
me
Travis Vitek wrote:
Martin Sebor wrote:
Eric Lemings wrote:
Travis,
If you could, give the following patch a whirl (or quick review
at least).
Is there an easier way to silence the warning than by adding
all these loops? E.g., by assigning the address of the first
member to a local point
>Martin Sebor wrote:
>
>Eric Lemings wrote:
>>
>> Travis,
>>
>> If you could, give the following patch a whirl (or quick review
>> at least).
>
>Is there an easier way to silence the warning than by adding
>all these loops? E.g., by assigning the address of the first
>member to a local pointe
Travis Vitek wrote:
Martin Sebor wrote:
PING? Should I open an issue for this or is it something you're
already working on or planning to?
Well if we want 100% compatibility with the shell, then it should be
implemented.
I don't expect rw_shell_expand() to necessarily behave exactly
the
Eric Lemings wrote:
Travis,
If you could, give the following patch a whirl (or quick review
at least).
Is there an easier way to silence the warning than by adding
all these loops? E.g., by assigning the address of the first
member to a local pointer? (Or is the compiler too smart for
that?)
Eric Lemings wrote:
-Original Message-
From: Martin Sebor [mailto:[EMAIL PROTECTED]
Sent: Thursday, April 03, 2008 1:02 PM
To: dev@stdcxx.apache.org
Subject: Re: svn commit: r644364 - in /stdcxx/trunk:
src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp
...
__rw_se
Travis,
If you could, give the following patch a whirl (or quick review
at least).
-
$ svn diff
Index: tests/src/new.cpp
===
--- tests/src/new.cpp (revision 64)
+++ tests/src/new.cpp (working copy)
@@ -604,6 +604,17 @@
Changes made:
* fix a bug (not filed) that would potentially access an array using
negative index
* add function compute_type_bits to calculate the number of bits in the
value representation of type T.
* add a check that would only define exact width integer type if the
system supports two's compl
> -Original Message-
> From: Martin Sebor [mailto:[EMAIL PROTECTED]
> Sent: Thursday, April 03, 2008 1:02 PM
> To: dev@stdcxx.apache.org
> Subject: Re: svn commit: r644364 - in /stdcxx/trunk:
> src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp
>
...
> __rw_setlocale co
> -Original Message-
> From: Travis Vitek [mailto:[EMAIL PROTECTED]
> Sent: Thursday, April 03, 2008 1:05 PM
> To: dev@stdcxx.apache.org
> Subject: RE: svn commit: r644364 - in /stdcxx/trunk:
> src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp
>
>
>
> >Eric Lemings
>Eric Lemings wrote:
>
>Please peer review the following patch at your earliest convenience.
>
Brad,
I don't think that this patch is going to work. The unnecessary changes
to the __rw_setlocale ctor and dtor will cause new failures.
The __rw_setlocale type is supposed to hold the lock for it
Eric Lemings wrote:
[...]
Please peer review the following patch at your earliest convenience.
-
$ svn diff
Index: src/setlocale.h
===
--- src/setlocale.h (revision 644426)
+++ src/setlocale.h (working copy)
@@ -58,6 +58
> -Original Message-
> From: Eric Lemings
> Sent: Thursday, April 03, 2008 11:12 AM
> To: 'dev@stdcxx.apache.org'
> Subject: RE: svn commit: r644364 - in /stdcxx/trunk:
> src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp
>
>
>
> > -Original Message-
> > From
Travis Vitek wrote:
Martin Sebor wrote:
Travis Vitek wrote:
Right. It seems that for this to be mt-safe with respect to other
library code that calls setlocale(), we would need to lock the
same lock that is used by _RW::__rw_setlocale. If don't use the
same lock it would be possible for t
Martin Sebor wrote:
>
>Travis Vitek wrote:
>>
>>
>> Right. It seems that for this to be mt-safe with respect to other
>> library code that calls setlocale(), we would need to lock the
>> same lock that is used by _RW::__rw_setlocale. If don't use the
>> same lock it would be possible for the
Eric Lemings wrote:
>
>
>file src/setlocale.cpp:
> 83 // acquire global per-process lock
> 84 __rw_setlocale_mutex._C_acquire ();
> 85
> 86 // retrieve previous locale name and check if it is already set
> 87 const char* const curname = ::setlocale (cat, 0);
>
>The mutex doesn't
file src/setlocale.cpp:
83 // acquire global per-process lock
84 __rw_setlocale_mutex._C_acquire ();
85
86 // retrieve previous locale name and check if it is already set
87 const char* const curname = ::setlocale (cat, 0);
The mutex doesn't need to be locked just to read the
> -Original Message-
> From: Martin Sebor [mailto:[EMAIL PROTECTED]
> Sent: Thursday, April 03, 2008 11:06 AM
> To: dev@stdcxx.apache.org
> Subject: Re: svn commit: r644364 - in /stdcxx/trunk:
> src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp
>
> Travis Vitek wrote:
Travis Vitek wrote:
-Original Message-
From: Martin Sebor [mailto:[EMAIL PROTECTED]
Sent: Thursday, April 03, 2008 8:55 AM
To: dev@stdcxx.apache.org
Subject: Re: svn commit: r644364 - in /stdcxx/trunk:
src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp
[EMAIL PROTEC
>-Original Message-
>From: Martin Sebor [mailto:[EMAIL PROTECTED]
>Sent: Thursday, April 03, 2008 8:55 AM
>To: dev@stdcxx.apache.org
>Subject: Re: svn commit: r644364 - in /stdcxx/trunk:
>src/locale_global.cpp tests/localization/22.locale.statics.mt.cpp
>
>[EMAIL PROTECTED] wrote:
>> A
[EMAIL PROTECTED] wrote:
Author: elemings
Date: Thu Apr 3 08:32:56 2008
New Revision: 644364
URL: http://svn.apache.org/viewvc?rev=644364&view=rev
Log:
2008-04-03 Eric Lemings <[EMAIL PROTECTED]>
STDCXX-811
* src/locale_global.cpp (std::locale::global): Replace call to
21 matches
Mail list logo
