Re: svn commit: r650698 - /stdcxx/branches/4.2.x/tests/src/cmdopt.cpp

2008-04-23 Thread Martin Sebor
Eric Lemings wrote: Rather than having malloc() function calls scattered throughout the test driver, I was wondering if a conventional malloc() wrapper wouldn't take care of a lot of this error checking and null pointer dereference warnings. A conventional Unix malloc() wrapper checks the retu

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Martin Sebor
Farid Zaripov wrote: From: Travis Vitek [mailto:[EMAIL PROTECTED] To: dev@stdcxx.apache.org Suject: RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp With just a quick review, this change looks a bit suspicious. The respective overloads for type double are all defined within conditional

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Martin Sebor
Travis Vitek wrote: Thanks for the careful review! Eric Lemings wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Author: faridz Date: Wed Apr 23 08:20:07 2008 New Revision: 650902 URL: http://svn.apache.org/viewvc?rev=650902&view=rev Log: 2008-04-2

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Farid Zaripov
> From: Travis Vitek [mailto:[EMAIL PROTECTED] > To: dev@stdcxx.apache.org > Suject: RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp >>With just a quick review, this change looks a bit suspicious. The >>respective overloads for type double are all defined within >>conditional-compile dire

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Travis Vitek
>Travis Vitek wrote: > >The overloads on double are in platform specific #ifdef blocks because >they have platform specific code in them (_finite, finite, >isfinite). At >least that is the only reason I see for it. So I don't really see the >overloads on float and double outside of platform spe

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Travis Vitek
> Eric Lemings wrote: > > >> -Original Message- >> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >> >> Author: faridz >> Date: Wed Apr 23 08:20:07 2008 >> New Revision: 650902 >> >> URL: http://svn.apache.org/viewvc?rev=650902&view=rev >> Log: >> 2008-04-23 Farid Zaripov <[EMAIL

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Eric Lemings
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Wednesday, April 23, 2008 9:21 AM > To: [EMAIL PROTECTED] > Subject: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp > > Author: faridz > Date: Wed Apr 23 08:20:07 2008 > New Revision: 650902 > > URL:

Re: errors compiling 22.locale.synopsis.cpp

2008-04-23 Thread Martin Sebor
Eric Lemings wrote: Interesting. I'll fix it pronto. NBD. The other tests have been failing too (and we'll need to fix them at some point in the near future) but this error looks new to me. In general though, do these compilers expect templates and specializations to not have a storage cla

RE: errors compiling 22.locale.synopsis.cpp

2008-04-23 Thread Eric Lemings
> -Original Message- > From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor > Sent: Wednesday, April 23, 2008 11:03 AM > To: dev@stdcxx.apache.org > Subject: errors compiling 22.locale.synopsis.cpp > > The new test fails to compile with most compilers, including IBM >

RE: errors compiling 22.locale.synopsis.cpp

2008-04-23 Thread Eric Lemings
Interesting. I'll fix it pronto. In general though, do these compilers expect templates and specializations to not have a storage class? Brad. > -Original Message- > From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor > Sent: Wednesday, April 23, 2008 11:03 AM > To:

Re: nightly build failures

2008-04-23 Thread Martin Sebor
Scott Zhong wrote: Aix-5.3-ppc, one of the machine has become unstable. Hpux 11.23, build timed out due to massively long duration. Linux_suse-9.1-amd64 11s, please take a look at this one Martin. I'm a step ahead of you! ;-) I actually noticed the compilation errors yesterday and checked in

nightly build failures

2008-04-23 Thread Scott Zhong
Aix-5.3-ppc, one of the machine has become unstable. Hpux 11.23, build timed out due to massively long duration. Linux_suse-9.1-amd64 11s, please take a look at this one Martin.

Re: svn commit: r650933 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Martin Sebor
Farid Zaripov wrote: From: Martin Sebor от имени Martin Sebor To: dev@stdcxx.apache.org Subject: Re: svn commit: r650933 - /stdcxx/trunk/src/num_put.cpp URL: http://svn.apache.org/viewvc?rev=650933&view=rev Log: 2008-04-23 Farid Zaripov <[EMAIL PROTECTED]> STDCXX-880 * src/num

Re: svn commit: r650933 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Farid Zaripov
> From: Martin Sebor от имени Martin Sebor > To: dev@stdcxx.apache.org > Subject: Re: svn commit: r650933 - /stdcxx/trunk/src/num_put.cpp > >> URL: http://svn.apache.org/viewvc?rev=650933&view=rev >> Log: >> 2008-04-23 Farid Zaripov <[EMAIL PROTECTED]> >> >> STDCXX-880 >> * src/nu

errors compiling 22.locale.synopsis.cpp

2008-04-23 Thread Martin Sebor
The new test fails to compile with most compilers, including IBM XLC++, Sun C++, MSVC, and HP aCC. It fails to link with Intel C++. Here's the aCC error: aCC -c -I$(TOPDIR)/include -I$(BUILDDIR)/include -I$(TOPDIR)/tests/include -AA +O2 +w +W392,655,684,818,819,849 +W2193,2236,2261,2340

Re: svn commit: r650933 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Martin Sebor
[EMAIL PROTECTED] wrote: Author: faridz Date: Wed Apr 23 09:25:44 2008 New Revision: 650933 URL: http://svn.apache.org/viewvc?rev=650933&view=rev Log: 2008-04-23 Farid Zaripov <[EMAIL PROTECTED]> STDCXX-880 * src/num_put.cpp [_RWSTD_DBL_SIZE == _RWSTD_LDBL_SIZE]: Call doub

RE: Binary compatibility test results for Sun C++ 5.8 on Solaris 8 and 10 platforms

2008-04-23 Thread Eric Lemings
> -Original Message- > From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor > Sent: Wednesday, April 23, 2008 9:10 AM > To: dev@stdcxx.apache.org > Subject: Re: Binary compatibility test results for Sun C++ > 5.8 on Solaris 8 and 10 platforms > ... > > It might all b

Re: Binary compatibility test results for Sun C++ 5.8 on Solaris 8 and 10 platforms

2008-04-23 Thread Martin Sebor
Eric Lemings wrote: -Original Message- From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor Sent: Tuesday, April 22, 2008 5:49 PM To: dev@stdcxx.apache.org Subject: Re: Binary compatibility test results for Sun C++ 5.8 on Solaris 8 and 10 platforms Eric Lemings wro

RE: svn commit: r650698 - /stdcxx/branches/4.2.x/tests/src/cmdopt.cpp

2008-04-23 Thread Eric Lemings
Rather than having malloc() function calls scattered throughout the test driver, I was wondering if a conventional malloc() wrapper wouldn't take care of a lot of this error checking and null pointer dereference warnings. A conventional Unix malloc() wrapper checks the return value and just prin

RE: Binary compatibility test results for Sun C++ 5.8 on Solaris 8 and 10 platforms

2008-04-23 Thread Eric Lemings
> -Original Message- > From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor > Sent: Tuesday, April 22, 2008 5:49 PM > To: dev@stdcxx.apache.org > Subject: Re: Binary compatibility test results for Sun C++ > 5.8 on Solaris 8 and 10 platforms > > Eric Lemings wrote: > >