[GitHub] storm pull request: STORM-488: Exit with 254 error code if storm C...

2014-10-04 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/278#issuecomment-57908996 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-488) storm CLI tool reports zero exit code on error scenario

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159177#comment-14159177 ] ASF GitHub Bot commented on STORM-488: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-10-04 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/279#discussion_r18430077 --- Diff: storm-core/src/clj/backtype/storm/testing.clj --- @@ -187,7 +187,9 @@ ;; on windows, the host process still holds lock on the logfile

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159185#comment-14159185 ] ASF GitHub Bot commented on STORM-492: -- Github user harshach commented on a diff in th

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-10-04 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/279#issuecomment-57910263 @HeartSaVioR overall this looks good to me and works as expected. Please add a note to DEVELOPER.md under "Build the code and run the tests" on setting the test-timeou

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159189#comment-14159189 ] ASF GitHub Bot commented on STORM-492: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-517: Adding JAVA_SERVICE_NAME to bin/sto...

2014-10-04 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/281#issuecomment-57910632 @solarce any reason not to pass this value from nimbus , supervisor etc methods in storm command. Having it as environment variable is another step for user to enable

[jira] [Commented] (STORM-517) Support for "-Dservice=" in bin/storm, via JAVA_SERVICE_NAME environment variable

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159195#comment-14159195 ] ASF GitHub Bot commented on STORM-517: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-499

2014-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-499) Document and clean up shaded dependncy resolution with maven

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159202#comment-14159202 ] ASF GitHub Bot commented on STORM-499: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-10-04 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/279#discussion_r18430254 --- Diff: storm-core/src/clj/backtype/storm/testing.clj --- @@ -187,7 +187,9 @@ ;; on windows, the host process still holds lock on the logfile

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159209#comment-14159209 ] ASF GitHub Bot commented on STORM-492: -- Github user HeartSaVioR commented on a diff in

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-10-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/279#issuecomment-57912017 @harshach I've reflected your suggestion. Thanks for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-213: fixed NullPointerException

2014-10-04 Thread wurstmeister
Github user wurstmeister commented on the pull request: https://github.com/apache/storm/pull/207#issuecomment-57912008 As far as I can tell this is just a static environment dump and does not mean that we start a new zookeeper server, see ([ZooKeeperServer] (https://svn.apache.org/rep

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159216#comment-14159216 ] ASF GitHub Bot commented on STORM-492: -- Github user HeartSaVioR commented on the pull

[jira] [Commented] (STORM-213) Decouple In-Process ZooKeeper from LocalCluster

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159215#comment-14159215 ] ASF GitHub Bot commented on STORM-213: -- Github user wurstmeister commented on the pull

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-10-04 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/279#issuecomment-57913104 @HeartSaVioR Thanks for the quick turn around. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159227#comment-14159227 ] ASF GitHub Bot commented on STORM-492: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-517: Adding JAVA_SERVICE_NAME to bin/sto...

2014-10-04 Thread nathanmarz
Github user nathanmarz commented on the pull request: https://github.com/apache/storm/pull/281#issuecomment-57917519 -1 I've never heard of this environment variable before. What is it used for? Also, you can get these options added to the Java processes already by ma

[jira] [Commented] (STORM-517) Support for "-Dservice=" in bin/storm, via JAVA_SERVICE_NAME environment variable

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159276#comment-14159276 ] ASF GitHub Bot commented on STORM-517: -- Github user nathanmarz commented on the pull r

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2014-10-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-57924831 @revans2 @ptgoetz Could you take a look, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159397#comment-14159397 ] ASF GitHub Bot commented on STORM-487: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2014-10-04 Thread ChitturiPadma
Github user ChitturiPadma commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-57925935 I have tried this earlier. It runs the nimbus and supervisors without any issues and topology could be submitted without any issues. But when we try to kill the top

[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159418#comment-14159418 ] ASF GitHub Bot commented on STORM-487: -- Github user ChitturiPadma commented on the pul

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2014-10-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-57926268 @ChitturiPadma Thanks for sharing experience. I'll test on it. Btw, does storm.cmd runs normally with this scenario? --- If your project is set up for it, you

[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2014-10-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159424#comment-14159424 ] ASF GitHub Bot commented on STORM-487: -- Github user HeartSaVioR commented on the pull

tcp socket spout

2014-10-04 Thread clay teahouse
Hi, Is there a tcp socket spout out there? thanks, Clay