[GitHub] storm pull request: [STORM-442] multilang ShellBolt/ShellSpout die...

2014-11-05 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/305#issuecomment-61774651 @clockfly I think it is not a good idea to kill sub process. Because when we catch a exception, we do not know whether sub process is still running. kill pid may

[jira] [Commented] (STORM-442) multilang ShellBolt/ShellSpout die() can be hang when Exception happened

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197882#comment-14197882 ] ASF GitHub Bot commented on STORM-442: -- Github user dashengju commented on the pull

[jira] [Created] (STORM-548) Receive Thread Shutdown hook should connect to local hostname but not localhost

2014-11-05 Thread caofangkun (JIRA)
caofangkun created STORM-548: Summary: Receive Thread Shutdown hook should connect to local hostname but not localhost Key: STORM-548 URL: https://issues.apache.org/jira/browse/STORM-548 Project: Apache

[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...

2014-11-05 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/307 STORM-548:Receive Thread Shutdown hook should connect to local-hostname ... backtype.storm.messaging.loader#launch-receive-thread! kill-socket should connect to local hostname but not

[jira] [Commented] (STORM-548) Receive Thread Shutdown hook should connect to local hostname but not localhost

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197930#comment-14197930 ] ASF GitHub Bot commented on STORM-548: -- GitHub user caofangkun opened a pull request:

[jira] [Commented] (STORM-547) Build Problem(s)

2014-11-05 Thread David Laxer (JIRA)
[ https://issues.apache.org/jira/browse/STORM-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198292#comment-14198292 ] David Laxer commented on STORM-547: --- 1. If I run: mvn clean package without -DskipTests,

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-11-05 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-61803120 ``` High Availability test test scenario: 4 machine A,B,C,D, 4 worker, 1 worker on each machine test case1(STORM-404): on machine A, kill worker. A

[jira] [Commented] (STORM-547) Build Problem(s)

2014-11-05 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198441#comment-14198441 ] Sriharsha Chintalapani commented on STORM-547: -- [~dbl001] if you are still

[jira] [Commented] (STORM-547) Build Problem(s)

2014-11-05 Thread David Laxer (JIRA)
[ https://issues.apache.org/jira/browse/STORM-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198546#comment-14198546 ] David Laxer commented on STORM-547: --- I did. 1. I increased it by a factor of 10 - same

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198562#comment-14198562 ] ASF GitHub Bot commented on STORM-492: -- Github user harshach commented on the pull

[jira] [Reopened] (STORM-492) Test timeout should be configurable

2014-11-05 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reopened STORM-492: -- Test timeout should be configurable ---

[jira] [Commented] (STORM-547) Build Problem(s)

2014-11-05 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198569#comment-14198569 ] Sriharsha Chintalapani commented on STORM-547: -- [~dbl001] looks like the

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-11-05 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/279#issuecomment-61831975 @clockfly this patch doesn't work. running this mvn clean install -DSTORM_TEST_TIMEOUT_MS=3 (let [timeout (System/getProperty STORM_TEST_TIMEOUT_MS)] the

[jira] [Commented] (STORM-547) Build Problem(s)

2014-11-05 Thread David Laxer (JIRA)
[ https://issues.apache.org/jira/browse/STORM-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198586#comment-14198586 ] David Laxer commented on STORM-547: --- Ok. This is what the current code looks like

[jira] [Commented] (STORM-547) Build Problem(s)

2014-11-05 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198612#comment-14198612 ] Sriharsha Chintalapani commented on STORM-547: -- [~dbl001] PR went into the

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198795#comment-14198795 ] ASF GitHub Bot commented on STORM-492: -- Github user ptgoetz commented on the pull

[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/298#issuecomment-61857797 -1 The storm platform itself does not require any native libraries, and the config option should be sufficient. --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61860848 -1 I agree with @HeartSaVioR that if we want an implementation of `ISpoutWaitStrategy` that takes into account the `streak` parameter, it should be a separate

[jira] [Commented] (STORM-378) SleepSpoutWaitStrategy.emptyEmit should use the variable streak

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198850#comment-14198850 ] ASF GitHub Bot commented on STORM-378: -- Github user ptgoetz commented on the pull

[jira] [Commented] (STORM-548) Receive Thread Shutdown hook should connect to local hostname but not localhost

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199100#comment-14199100 ] ASF GitHub Bot commented on STORM-548: -- Github user ptgoetz commented on the pull

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61883299 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-537) A worker reconnects infinitely to another dead worker

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199112#comment-14199112 ] ASF GitHub Bot commented on STORM-537: -- Github user ptgoetz commented on the pull

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-11-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/279#issuecomment-61885540 @ptgoetz @harshach @clockfly I did confused about it at that time. Sorry about my mistake. ;( I'll update it and post new PR. Regarding revert plan, actually

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199142#comment-14199142 ] ASF GitHub Bot commented on STORM-492: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-492: Fixed bug from tracked-wait / Added...

2014-11-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/279#issuecomment-61893230 I re-read my comments, and I found I've mistaken with talking to @ptgoetz . Actually I prefer JVM property, not system environment. Maybe I was confusing about

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199245#comment-14199245 ] ASF GitHub Bot commented on STORM-492: -- Github user HeartSaVioR commented on the pull

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199255#comment-14199255 ] ASF GitHub Bot commented on STORM-492: -- GitHub user HeartSaVioR opened a pull request:

[GitHub] storm pull request: STORM-492 with reverting previous merge

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/308#issuecomment-61897392 Thanks @HeartSaVioR. No need to apologize, we all make mistakes. The important part is that we have a community to review and catch them. When we do. :) I'm fine

[GitHub] storm pull request: STORM-492 with reverting previous merge

2014-11-05 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/308#issuecomment-61898945 Thanks for the quick fix. This looks good to me +1 on merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199316#comment-14199316 ] ASF GitHub Bot commented on STORM-492: -- Github user harshach commented on the pull

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2014-11-05 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-61908678 @revans2 @ptgoetz Hello. Any updates on it? From some JIRA issues we already talked that it will be better to have 'unified' storm script. So when my

[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199470#comment-14199470 ] ASF GitHub Bot commented on STORM-487: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-61919968 @HeartSaVioR sorry for the delay. I will test and reply when I have the chance. I would encourage others to do the same as well. --- If your project is set up for it,

[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199687#comment-14199687 ] ASF GitHub Bot commented on STORM-487: -- Github user ptgoetz commented on the pull

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-05 Thread clockfly
Github user clockfly commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61921292 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-537) A worker reconnects infinitely to another dead worker

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199698#comment-14199698 ] ASF GitHub Bot commented on STORM-537: -- Github user clockfly commented on the pull

[jira] [Commented] (STORM-537) A worker reconnects infinitely to another dead worker

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199722#comment-14199722 ] ASF GitHub Bot commented on STORM-537: -- Github user ptgoetz commented on the pull

[GitHub] storm pull request: [STORM-537] A worker reconnects infinitely to ...

2014-11-05 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/304#issuecomment-61927140 @Sergeant007 thanks for the patch. Is there anything changed in storm-core/test/clj/backtype/storm/messaging/netty_unit_test.clj. It looks to me from the PR the content

[jira] [Commented] (STORM-492) Test timeout should be configurable

2014-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199859#comment-14199859 ] ASF GitHub Bot commented on STORM-492: -- Github user HeartSaVioR commented on the pull