[GitHub] storm pull request: use generics when implementing TupleToKafkaMap...

2014-12-12 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/345#issuecomment-66866253 +1. I think this is small enough to not have a jira but I will let the committers decide. --- If your project is set up for it, you can reply to this email and h

[jira] [Created] (STORM-590) KafkaSpout should use kafka consumer api

2014-12-12 Thread Kai Sasaki (JIRA)
Kai Sasaki created STORM-590: Summary: KafkaSpout should use kafka consumer api Key: STORM-590 URL: https://issues.apache.org/jira/browse/STORM-590 Project: Apache Storm Issue Type: Improvement

[jira] [Commented] (STORM-391) KafkaSpout to await for the topic

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245103#comment-14245103 ] ASF GitHub Bot commented on STORM-391: -- Github user Lewuathe commented on the pull req

[GitHub] storm pull request: [STORM-391] KafkaSpout to await for the topic

2014-12-12 Thread Lewuathe
Github user Lewuathe commented on the pull request: https://github.com/apache/storm/pull/338#issuecomment-66860765 @ptgoetz OK. I'll raise new ticket for changing I/F between kafka and kafka-spout. Thank you! --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (STORM-512) KafkaBolt doesn't handle ticks properly

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245078#comment-14245078 ] ASF GitHub Bot commented on STORM-512: -- Github user nathanmarz commented on the pull r

[GitHub] storm pull request: STORM-512 KafkaBolt doesn't handle ticks prope...

2014-12-12 Thread nathanmarz
Github user nathanmarz commented on the pull request: https://github.com/apache/storm/pull/275#issuecomment-66858418 I view tick tuples as being built on top of the core ideas of streams and tuples, not as fundamentally intertwined with them. So let's keep them separate and have this

[GitHub] storm pull request: use generics when implementing TupleToKafkaMap...

2014-12-12 Thread norbertpotocki
GitHub user norbertpotocki opened a pull request: https://github.com/apache/storm/pull/345 use generics when implementing TupleToKafkaMapper in FieldNameBasedTuple.. - use generics when implementing TupleToKafkaMapper in FieldNameBasedTupleToKafkaMapper It fixes unchecked a

[jira] [Commented] (STORM-495) Add delayed retries to KafkaSpout

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244798#comment-14244798 ] ASF GitHub Bot commented on STORM-495: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-495: KafkaSpout retries with exponential...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/254#issuecomment-66837722 +1 (again). Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (STORM-329) Add Option to Config Message handling strategy when connection timeout

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244790#comment-14244790 ] ASF GitHub Bot commented on STORM-329: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-66836806 @tedxia This pull request has merge conflicts, would you mind syncing up with the master branch? @nathanmarz There's been a considerable amount of discussion since

[GitHub] storm pull request: STORM-577:supervisor heartbeat and handle ev...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/332#issuecomment-66833294 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Commented] (STORM-583) Add spout and bolt implementation for Azure Eventhubs

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244755#comment-14244755 ] ASF GitHub Bot commented on STORM-583: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-583: Initiali check-in for storm-eventhu...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/336#issuecomment-66832916 I would support pulling this in, but we need additional committers to approve it, and one or more to volunteer as sponsor(s). As @revans2 mentioned, this is a siza

[jira] [Commented] (STORM-583) Add spout and bolt implementation for Azure Eventhubs

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244748#comment-14244748 ] ASF GitHub Bot commented on STORM-583: -- Github user ptgoetz commented on a diff in the

[GitHub] storm pull request: STORM-583: Initiali check-in for storm-eventhu...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/336#discussion_r21771427 --- Diff: external/storm-eventhubs/pom.xml --- @@ -0,0 +1,107 @@ + --- End diff -- Need apache license header. --- If your project is set up

[jira] [Commented] (STORM-585) Performance issue in none grouping

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244737#comment-14244737 ] ASF GitHub Bot commented on STORM-585: -- Github user ptgoetz commented on the pull requ

[jira] [Commented] (STORM-391) KafkaSpout to await for the topic

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244734#comment-14244734 ] ASF GitHub Bot commented on STORM-391: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: Performance improvement: Fix for https://issue...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/343#issuecomment-66830696 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] storm pull request: [STORM-391] KafkaSpout to await for the topic

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/338#issuecomment-66830619 @Lewuathe Here is the exception: https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/common/UnknownTopicOrPartitionException.scala I'd rather go t

[GitHub] storm pull request: typo

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/333#issuecomment-66829256 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Commented] (STORM-586) Trident kafka spout fails instead of updating offset when kafka offset is out of range.

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244718#comment-14244718 ] ASF GitHub Bot commented on STORM-586: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-586: TridentKafkaEmitter should catch up...

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/339#issuecomment-66829121 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Commented] (STORM-544) Some documents from website are outdated

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244713#comment-14244713 ] ASF GitHub Bot commented on STORM-544: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-544 Fix outdated documents

2014-12-12 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/340#issuecomment-66828662 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] storm pull request: Storm-444: Moving AutoHDFS to storm-hdfs and A...

2014-12-12 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/344#issuecomment-66816680 Tested with both storm-hdfs and storm-hbase bolts in a secure cluster and was able to leverage tokens. Also tested storm-hbase token expiration and auto renewal b

[GitHub] storm pull request: Storm-444: Moving AutoHDFS to storm-hdfs and A...

2014-12-12 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/storm/pull/344 Storm-444: Moving AutoHDFS to storm-hdfs and AutoHBase to storm-hbase. Added code to leverage delegation tokens in storm-hdfs and storm-hbase bolts/states. You can merge this pull request

[jira] [Commented] (STORM-512) KafkaBolt doesn't handle ticks properly

2014-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243863#comment-14243863 ] ASF GitHub Bot commented on STORM-512: -- Github user nielsbasjes commented on the pull

[GitHub] storm pull request: STORM-512 KafkaBolt doesn't handle ticks prope...

2014-12-12 Thread nielsbasjes
Github user nielsbasjes commented on the pull request: https://github.com/apache/storm/pull/275#issuecomment-66744560 @nathanmarz Why not there? To me it seemed the most logical place. This Tuple interface is one of the core types of Storm and so are the ticks. As you can see f