[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260862#comment-14260862 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68334616 @darionyaphet I also think providing Jedis instance could be enough for many users cause Jedis is already easy to use. So we can start from this case.

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260855#comment-14260855 ] ASF GitHub Bot commented on STORM-609: -- Github user darionyaphet commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread darionyaphet
Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68334201 Redis have a lot of function could do anything I have meet in my work . It's hard to cover all pices of it and also needn't . You could just provide a jedis instance

[jira] [Commented] (STORM-329) Add Option to Config Message handling strategy when connection timeout

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260853#comment-14260853 ] ASF GitHub Bot commented on STORM-329: -- Github user tedxia commented on the pull reque

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-12-29 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-68334058 @nathanmarz will you have a look at this, thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260831#comment-14260831 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68332013 Here're data types and commands I'm trying to support at first time. Type | Read | Write --- | --- | --- STRING | GET (key) | SET (key, valu

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260798#comment-14260798 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68330414 @darionyaphet Hello. For spout, it isn't acceptable for reliable data source because during failure it'll lose some tuples. (Actually Redis cannot act as r

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260731#comment-14260731 ] ASF GitHub Bot commented on STORM-609: -- Github user darionyaphet commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread darionyaphet
Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68327749 redis publish/subscribe is supported ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260708#comment-14260708 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68325672 @dashengju Thanks for concerning! I'll share a sketch about what it looks like (maybe similar to storm-hbase) and what types it can support. --- If your project i

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260706#comment-14260706 ] ASF GitHub Bot commented on STORM-609: -- Github user dashengju commented on the pull re

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68325551 @HeartSaVioR , ok , you can responsible for core storm bolt. And I will add more data types for trident state and unit tests. next time commit, I will add

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260689#comment-14260689 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68324513 My sketch would be similar to storm-hbase, but because of various Redis data types, supporting types needs design before implementing. --- If your project is set up f

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260683#comment-14260683 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68324419 @dashengju Oh, actually I'm sketching features for supporting core storm bolt. Could you wait for me to share sketches and let me implement it, or do you want your

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260676#comment-14260676 ] ASF GitHub Bot commented on STORM-609: -- Github user dashengju commented on the pull re

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68324052 @harshach , @Parth-Brahmbhatt , @HeartSaVioR I have implemented a few functions in current PR. As @HeartSaVioR says, it's better to collaborate with each other

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260650#comment-14260650 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68322020 @dashengju Hey, it's better to collaborate with you by requesting PR to merge. I posted small PR to your fork just now. --- If your project is set up for it, you

[jira] [Commented] (STORM-611) worker-launcher.c contains extra "break"s

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260546#comment-14260546 ] ASF GitHub Bot commented on STORM-611: -- Github user harshach commented on the pull req

[GitHub] storm pull request: [STORM-611] Remove extra "break"s

2014-12-29 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/367#issuecomment-68315677 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260536#comment-14260536 ] ASF GitHub Bot commented on STORM-609: -- Github user Parth-Brahmbhatt commented on the

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68314612 Any reason to only provide implementation for trident? Do you plan to add support for core storm bolt? --- If your project is set up for it, you can reply to thi

[jira] [Commented] (STORM-610) worker-launcher doesn't check return value of fts_close while setting up a directory

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260532#comment-14260532 ] ASF GitHub Bot commented on STORM-610: -- Github user Parth-Brahmbhatt commented on the

[GitHub] storm pull request: [STORM-610] Check the return value of fts_clos...

2014-12-29 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/366#issuecomment-68314302 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[jira] [Commented] (STORM-613) Fix wrong getOffset return value

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260528#comment-14260528 ] ASF GitHub Bot commented on STORM-613: -- Github user Parth-Brahmbhatt commented on the

[jira] [Commented] (STORM-611) worker-launcher.c contains extra "break"s

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260530#comment-14260530 ] ASF GitHub Bot commented on STORM-611: -- Github user Parth-Brahmbhatt commented on the

[GitHub] storm pull request: [STORM-611] Remove extra "break"s

2014-12-29 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/367#issuecomment-68314135 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2014-12-29 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/369#issuecomment-68314022 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260168#comment-14260168 ] ASF GitHub Bot commented on STORM-609: -- Github user harshach commented on the pull req

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68267817 @dashengju thanks for sharing this. I would like to see unit tests on the code. --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Commented] (STORM-612) configure.ac sets the google groups account as a contact address

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260167#comment-14260167 ] ASF GitHub Bot commented on STORM-612: -- Github user harshach commented on the pull req

[jira] [Commented] (STORM-613) Fix wrong getOffset return value

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260165#comment-14260165 ] ASF GitHub Bot commented on STORM-613: -- Github user harshach commented on the pull req

[jira] [Issue Comment Deleted] (STORM-612) configure.ac sets the google groups account as a contact address

2014-12-29 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-612: - Comment: was deleted (was: +1) > configure.ac sets the google groups account as a

[jira] [Commented] (STORM-612) configure.ac sets the google groups account as a contact address

2014-12-29 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260166#comment-14260166 ] Sriharsha Chintalapani commented on STORM-612: -- +1 > configure.ac sets the go

[GitHub] storm pull request: [STORM-612] Update the contact address in conf...

2014-12-29 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/368#issuecomment-68267673 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2014-12-29 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/369#issuecomment-68267623 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-609) add storm-redis to storm external

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259980#comment-14259980 ] ASF GitHub Bot commented on STORM-609: -- Github user dashengju commented on the pull re

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2014-12-29 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-68244243 @darionyaphet , I think storm-redis can support redis and redis-cluster both. we can also add redis-sharding solution to trident state. @HeartSaVioR , yes, I t

[jira] [Commented] (STORM-613) Fix wrong getOffset return value

2014-12-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259960#comment-14259960 ] ASF GitHub Bot commented on STORM-613: -- GitHub user tedxia opened a pull request:

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2014-12-29 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/369 STORM-613: Fix wrong getOffset return value When judge getOffset return value, use 0 not NO_OFFSET as invalid offset return value. You can merge this pull request into a Git repository by running:

[jira] [Created] (STORM-613) Fix wrong getOffset return value

2014-12-29 Thread xiajun (JIRA)
xiajun created STORM-613: Summary: Fix wrong getOffset return value Key: STORM-613 URL: https://issues.apache.org/jira/browse/STORM-613 Project: Apache Storm Issue Type: Bug Components: sto