[jira] [Commented] (STORM-996) netty-unit-tests/test-batch demonstrates out-of-order delivery

2015-08-30 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14722708#comment-14722708 ] Derek Dagit commented on STORM-996: --- If I enable the debugging statement that logs how ma

[GitHub] storm pull request: [storm-elasticsearch] Expose TransportClient c...

2015-08-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/707#issuecomment-136217248 Overall looks fine. I left some comments, most of things are about license comment. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] storm pull request: [storm-elasticsearch] Expose TransportClient c...

2015-08-30 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/707#discussion_r38277663 --- Diff: external/storm-elasticsearch/README.md --- @@ -84,6 +84,7 @@ Provided components (Bolt, State) takes in EsConfig as a constructor arg. |---

[GitHub] storm pull request: [storm-elasticsearch] Expose TransportClient c...

2015-08-30 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/707#discussion_r38277650 --- Diff: external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsConfigTest.java --- @@ -0,0 +1,54 @@ +package org.apache.

[GitHub] storm pull request: [storm-elasticsearch] Expose TransportClient c...

2015-08-30 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/707#discussion_r38277647 --- Diff: external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/SniffSettings.java --- @@ -0,0 +1,5 @@ +package org.apache.

[GitHub] storm pull request: [storm-elasticsearch] Expose TransportClient c...

2015-08-30 Thread alexpanov
Github user alexpanov commented on the pull request: https://github.com/apache/storm/pull/707#issuecomment-136209485 @harshach Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] storm pull request: add cgroup function that can limit cpu share o...

2015-08-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/667#issuecomment-136175840 @caishize please file a JIRA here https://issues.apache.org/jira/browse/STORM . I haven't taken a close look at the changes but does any of these changes interfere with

[jira] [Closed] (STORM-524) Please create a DOAP file for your TLP

2015-08-30 Thread Rick Kellogg (JIRA)
[ https://issues.apache.org/jira/browse/STORM-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rick Kellogg closed STORM-524. -- Confirmed doap_storm.rdf file is present. Closing issue. > Please create a DOAP file for your TLP > ---

[jira] [Closed] (STORM-547) Build Problem(s)

2015-08-30 Thread Rick Kellogg (JIRA)
[ https://issues.apache.org/jira/browse/STORM-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rick Kellogg closed STORM-547. -- > Build Problem(s) > > > Key: STORM-547 > URL: https://issue

[jira] [Updated] (STORM-996) netty-unit-tests/test-batch demonstrates out-of-order delivery

2015-08-30 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Dagit updated STORM-996: -- Attachment: storm-996-OrderedDownstreamThreadPoolExecutor-failed.txt.bz2 assertions failed from test-repo

[jira] [Commented] (STORM-996) netty-unit-tests/test-batch demonstrates out-of-order delivery

2015-08-30 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721639#comment-14721639 ] Derek Dagit commented on STORM-996: --- Following up briefly: I wanted to see if the nature

[jira] [Commented] (STORM-969) HDFS Bolt can end up in an unrecoverable state

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721557#comment-14721557 ] ASF GitHub Bot commented on STORM-969: -- Github user harshach commented on a diff in th

[GitHub] storm pull request: STORM-969: HDFS Bolt can end up in an unrecove...

2015-08-30 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/664#discussion_r38272576 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java --- @@ -88,35 +99,94 @@ public void doPrepare(Map conf, TopologyContext

[jira] [Commented] (STORM-828) HdfsBolt takes a lot of configuration, need good defaults

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721550#comment-14721550 ] ASF GitHub Bot commented on STORM-828: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-828 HdfsBolt takes a lot of configuratio...

2015-08-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/668#issuecomment-136152413 @redsanket why we need CSVBolt and TSVBolt when there is DelimitedRecordFormat which users can configure --- If your project is set up for it, you can reply to this ema

[jira] [Commented] (STORM-997) Add support for user specified UGI - (UserGroupInformation) for storm hdfs connector

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721547#comment-14721547 ] ASF GitHub Bot commented on STORM-997: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-997: Add proxy user functionality for st...

2015-08-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/692#issuecomment-136152260 @priyank5485 we need to add this trident as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1012) Shade Jackson dependency

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721545#comment-14721545 ] ASF GitHub Bot commented on STORM-1012: --- Github user asfgit closed the pull request

[GitHub] storm pull request: STORM-1012: Shading jackson.

2015-08-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-855) Add tuple batching

2015-08-30 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721538#comment-14721538 ] Matthias J. Sax commented on STORM-855: --- There are some additional results in the PR

[jira] [Commented] (STORM-1013) [storm-elasticsearch] Expose TransportClient configuration Map to EsConfig

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721535#comment-14721535 ] ASF GitHub Bot commented on STORM-1013: --- Github user harshach commented on the pull

[GitHub] storm pull request: Fix STORM-1013

2015-08-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/707#issuecomment-136151454 @alexpanov can you also fix the PR title to JIRA title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (STORM-1013) [storm-elasticsearch] Expose TransportClient configuration Map to EsConfig

2015-08-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721476#comment-14721476 ] ASF GitHub Bot commented on STORM-1013: --- Github user alexpanov commented on the pull

[GitHub] storm pull request: Fix STORM-1013

2015-08-30 Thread alexpanov
Github user alexpanov commented on the pull request: https://github.com/apache/storm/pull/707#issuecomment-136124914 @HeartSaVioR 1. No problem. Will do. 2. Done. 3. I used ES Preconditions instead. It's already in the classpath anyway. I also updated documentation