[GitHub] storm pull request #:

2016-06-09 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/commit/0b54767e246d4619cd9f40931b54947da38d317d#commitcomment-17815802 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[jira] [Commented] (STORM-1771) HiveState should flushAndClose before closing old or idle Hive connections

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323720#comment-15323720 ] ASF GitHub Bot commented on STORM-1771: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1467: STORM-1771. HiveState should flushAndClose before closing...

2016-06-09 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1467 There was a compilation issue with this patch. I fixed it with this commit: 0b54767 Please review. If there are any objections I can revert. --- If your project is set up for it, you can reply t

[jira] [Updated] (STORM-1897) re-pattern file-path-separator problem with windows, breaks logviewer

2016-06-09 Thread gareth smith (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gareth smith updated STORM-1897: Description: re-pattern file-path-separator will cause errors in windows... more specifically

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323390#comment-15323390 ] ASF GitHub Bot commented on STORM-1136: --- Github user abellina commented on a diff in

[GitHub] storm pull request #1451: STORM-1136: Command line module to return kafka sp...

2016-06-09 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/storm/pull/1451#discussion_r66524810 --- Diff: storm-core/src/ui/public/topology.html --- @@ -384,8 +389,51 @@ Topology resources $('#topology-configuration [data-toggle="toolti

[jira] [Resolved] (STORM-1884) In RedisKeyValueState.prepareCommit keys in pendingPrepare should have priority over pendingCommit

2016-06-09 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1884. Resolution: Fixed Fix Version/s: 1.1.0 1.0.2 2.0

[GitHub] storm pull request #1471: STORM-1865: update command line client document

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1471 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1884) In RedisKeyValueState.prepareCommit keys in pendingPrepare should have priority over pendingCommit

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323332#comment-15323332 ] ASF GitHub Bot commented on STORM-1884: --- Github user asfgit closed the pull request

[GitHub] storm pull request #1464: STORM-1884: Prioritize pendingPrepare over pending...

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1771) HiveState should flushAndClose before closing old or idle Hive connections

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323334#comment-15323334 ] ASF GitHub Bot commented on STORM-1771: --- Github user asfgit closed the pull request

[GitHub] storm pull request #1467: STORM-1771. HiveState should flushAndClose before ...

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1874) Update Logger access permissions

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323331#comment-15323331 ] ASF GitHub Bot commented on STORM-1874: --- Github user asfgit closed the pull request

[jira] [Commented] (STORM-1865) update command line client document

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1532#comment-1532 ] ASF GitHub Bot commented on STORM-1865: --- Github user asfgit closed the pull request

[GitHub] storm pull request #1456: [STORM-1874]Update logger private permissions

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #1153: [STORM-1575] fix TwitterSampleSpout NPE on close

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1575) TwitterSampleSpout throws NPE on close

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323329#comment-15323329 ] ASF GitHub Bot commented on STORM-1575: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-1575) TwitterSampleSpout throws NPE on close

2016-06-09 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1575. Resolution: Fixed Fix Version/s: 1.1.0 1.0.2 2.0

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323284#comment-15323284 ] ASF GitHub Bot commented on STORM-1136: --- Github user harshach commented on the issue

[GitHub] storm issue #1451: STORM-1136: Command line module to return kafka spout off...

2016-06-09 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1451 sitll +1. @abellina can you address @priyank5485 response. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[jira] [Resolved] (STORM-1874) Update Logger access permissions

2016-06-09 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1874. Resolution: Fixed Fix Version/s: 1.1.0 1.0.2 2.0

[jira] [Resolved] (STORM-1865) update command line client document

2016-06-09 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1865. Resolution: Fixed Fix Version/s: 1.1.0 1.0.2 2.0

[jira] [Resolved] (STORM-1771) HiveState should flushAndClose before closing old or idle Hive connections

2016-06-09 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1771. Resolution: Fixed Fix Version/s: 2.0.0 Merged to master, 1.x-branch and 1.0.x-branch.

[jira] [Commented] (STORM-1882) Expose TextFileReader public

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323203#comment-15323203 ] ASF GitHub Bot commented on STORM-1882: --- Github user asfgit closed the pull request

[GitHub] storm pull request #1461: [STORM-1882] Expose TextFileReader public

2016-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1461 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1771) HiveState should flushAndClose before closing old or idle Hive connections

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323190#comment-15323190 ] ASF GitHub Bot commented on STORM-1771: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1467: STORM-1771. HiveState should flushAndClose before closing...

2016-06-09 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1467 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Resolved] (STORM-1882) Expose TextFileReader public

2016-06-09 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1882. Resolution: Fixed Fix Version/s: 1.1.0 1.0.2 2.0

[GitHub] storm issue #1331: STORM-1705: Cap number of retries for a failed message

2016-06-09 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1331 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (STORM-1705) Cap on number of retries for a failed message in kafka spout

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323160#comment-15323160 ] ASF GitHub Bot commented on STORM-1705: --- Github user ptgoetz commented on the issue:

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323137#comment-15323137 ] ASF GitHub Bot commented on STORM-1136: --- Github user priyank5485 commented on the is

[GitHub] storm issue #1451: STORM-1136: Command line module to return kafka spout off...

2016-06-09 Thread priyank5485
Github user priyank5485 commented on the issue: https://github.com/apache/storm/pull/1451 @abellina I have added a comment for that div. As far as renaming it to topology-spout-stats is concerned I prefer the current name since right below that div there is a div showing stats for the

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323104#comment-15323104 ] ASF GitHub Bot commented on STORM-1136: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1451: STORM-1136: Command line module to return kafka sp...

2016-06-09 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1451#discussion_r66499861 --- Diff: storm-core/src/ui/public/topology.html --- @@ -384,8 +389,51 @@ Topology resources $('#topology-configuration [data-toggle="too

[jira] [Commented] (STORM-1898) MAX_BATCH_SIZE_CONF not working in Trident storm Spout

2016-06-09 Thread Narendra Bidari (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323099#comment-15323099 ] Narendra Bidari commented on STORM-1898: [~rev...@viaserv.com][~priyank780] : any

[jira] [Created] (STORM-1898) MAX_BATCH_SIZE_CONF not working in Trident storm Spout

2016-06-09 Thread Narendra Bidari (JIRA)
Narendra Bidari created STORM-1898: -- Summary: MAX_BATCH_SIZE_CONF not working in Trident storm Spout Key: STORM-1898 URL: https://issues.apache.org/jira/browse/STORM-1898 Project: Apache Storm

[jira] [Commented] (STORM-1723) Introduce ClusterMetricsConsumer

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322748#comment-15322748 ] ASF GitHub Bot commented on STORM-1723: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-1723) Introduce ClusterMetricsConsumer

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322749#comment-15322749 ] ASF GitHub Bot commented on STORM-1723: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1460: STORM-1723 Introduce ClusterMetricsConsumer

2016-06-09 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1460#discussion_r66468084 --- Diff: storm-core/src/jvm/org/apache/storm/metric/LoggingClusterMetricsConsumer.java --- @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Softwar

[GitHub] storm pull request #1460: STORM-1723 Introduce ClusterMetricsConsumer

2016-06-09 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1460#discussion_r66468117 --- Diff: storm-core/src/jvm/org/apache/storm/metric/LoggingClusterMetricsConsumer.java --- @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Softwar

[jira] [Commented] (STORM-1723) Introduce ClusterMetricsConsumer

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322747#comment-15322747 ] ASF GitHub Bot commented on STORM-1723: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1460: STORM-1723 Introduce ClusterMetricsConsumer

2016-06-09 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1460#discussion_r66467936 --- Diff: storm-core/src/jvm/org/apache/storm/metric/ClusterMetricsConsumerExecutor.java --- @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Softwa

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322733#comment-15322733 ] ASF GitHub Bot commented on STORM-1136: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1451: STORM-1136: Command line module to return kafka sp...

2016-06-09 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1451#discussion_r66466516 --- Diff: storm-core/src/ui/public/topology.html --- @@ -384,8 +389,51 @@ Topology resources $('#topology-configuration [data-toggle="toolti

[jira] [Created] (STORM-1897) re-pattern file-path-separator problem with windows, breaks logviewer

2016-06-09 Thread gareth smith (JIRA)
gareth smith created STORM-1897: --- Summary: re-pattern file-path-separator problem with windows, breaks logviewer Key: STORM-1897 URL: https://issues.apache.org/jira/browse/STORM-1897 Project: Apache Sto

[jira] [Updated] (STORM-1876) Provide option to build storm-kafka against different kafka clients

2016-06-09 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal updated STORM-1876: Component/s: storm-kafka > Provide option to build storm-kafka against different kafka clien

[jira] [Created] (STORM-1896) HdfsSpout remove duplicated code

2016-06-09 Thread darion yaphet (JIRA)
darion yaphet created STORM-1896: Summary: HdfsSpout remove duplicated code Key: STORM-1896 URL: https://issues.apache.org/jira/browse/STORM-1896 Project: Apache Storm Issue Type: Improvement

[jira] [Commented] (STORM-1896) HdfsSpout remove duplicated code

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322666#comment-15322666 ] ASF GitHub Bot commented on STORM-1896: --- GitHub user darionyaphet opened a pull requ

[GitHub] storm pull request #1478: [STORM-1896] HdfsSpout remove duplicated code

2016-06-09 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1478 [STORM-1896] HdfsSpout remove duplicated code [STORM-1896](https://issues.apache.org/jira/browse/STORM-1896) remove duplicated code in HdfsSpout open() You can merge this pull request

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322652#comment-15322652 ] ASF GitHub Bot commented on STORM-1895: --- Github user abhishekagarwal87 commented on

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1477 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322582#comment-15322582 ] ASF GitHub Bot commented on STORM-1895: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR Thanks ~~ I have update commit message to JIRA title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322607#comment-15322607 ] ASF GitHub Bot commented on STORM-1895: --- Github user darionyaphet commented on the i

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR Thanks commit message same with JIRA title maybe better :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322600#comment-15322600 ] ASF GitHub Bot commented on STORM-1895: --- GitHub user darionyaphet reopened a pull re

[GitHub] storm pull request #1477: [STORM-1895] Blob Store replication-factor argumen...

2016-06-09 Thread darionyaphet
GitHub user darionyaphet reopened a pull request: https://github.com/apache/storm/pull/1477 [STORM-1895] Blob Store replication-factor argument [STORM-1895](https://issues.apache.org/jira/browse/STORM-1895) Storm command line argument --repl-fctr have update to replication-f

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 You can normally reopen your pull request, but AFAIK, if you delete your branch and push your changes, you can't reopen pull request. --- If your project is set up for it, you can reply to this

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322596#comment-15322596 ] ASF GitHub Bot commented on STORM-1895: --- Github user HeartSaVioR commented on the is

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322590#comment-15322590 ] ASF GitHub Bot commented on STORM-1895: --- Github user darionyaphet commented on the i

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR just a miss operation .. btw I couldn't reopen this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 @darionyaphet FYI: You don't need to close your pull request. You can `git rebase -i HEAD~1` and modify `pick` to `reword` and save & exit, and modify your commit message for last commit. Af

[GitHub] storm pull request #1477: [STORM-1895] Blob Store replication-factor argumen...

2016-06-09 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322576#comment-15322576 ] ASF GitHub Bot commented on STORM-1895: --- Github user darionyaphet commented on the i

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322575#comment-15322575 ] ASF GitHub Bot commented on STORM-1895: --- Github user darionyaphet closed the pull re

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322572#comment-15322572 ] ASF GitHub Bot commented on STORM-1895: --- Github user HeartSaVioR commented on the is

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 @darionyaphet Yes, or `STORM-1895: blobstore replication-factor argument` as title and `replace repl-fctr with replication-factor` as description is also fine for me. --- If your project is set

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322569#comment-15322569 ] ASF GitHub Bot commented on STORM-1895: --- Github user darionyaphet commented on the i

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @abhishekagarwal87 Should I update commit message to `STORM-1895 : replace repl-fctr with replication-factor` ? --- If your project is set up for it, you can reply to this email and have you

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322560#comment-15322560 ] ASF GitHub Bot commented on STORM-1895: --- Github user satishd commented on the issue:

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1477 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1477 @darionyaphet can you add jira id in the commit. Looks good otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322551#comment-15322551 ] ASF GitHub Bot commented on STORM-1895: --- Github user abhishekagarwal87 commented on

[jira] [Updated] (STORM-1876) Provide option to build storm-kafka against different kafka clients

2016-06-09 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal updated STORM-1876: Summary: Provide option to build storm-kafka against different kafka clients (was: Add docu

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322537#comment-15322537 ] ASF GitHub Bot commented on STORM-1136: --- Github user abellina commented on the issue

[GitHub] storm issue #1451: STORM-1136: Command line module to return kafka spout off...

2016-06-09 Thread abellina
Github user abellina commented on the issue: https://github.com/apache/storm/pull/1451 @priyank5485 Yes I see the tables don't get populated if lag responses are empty, but we still end up with the div markup on the page. It seems that this may be an area where other spouts could put

[jira] [Commented] (STORM-1705) Cap on number of retries for a failed message in kafka spout

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322534#comment-15322534 ] ASF GitHub Bot commented on STORM-1705: --- Github user abhishekagarwal87 commented on

[GitHub] storm issue #1331: STORM-1705: Cap number of retries for a failed message

2016-06-09 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1331 I have taken care of comments and added documentation in storm-kafka readme. Please review the documentation as well. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322520#comment-15322520 ] ASF GitHub Bot commented on STORM-1136: --- Github user abellina commented on a diff in

[GitHub] storm pull request #1451: STORM-1136: Command line module to return kafka sp...

2016-06-09 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/storm/pull/1451#discussion_r66442673 --- Diff: storm-core/src/ui/public/topology.html --- @@ -384,8 +389,51 @@ Topology resources $('#topology-configuration [data-toggle="toolti

[jira] [Closed] (STORM-1717) Support Redis INRC , INRCBY and INRCBYFLOAT

2016-06-09 Thread darion yaphet (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] darion yaphet closed STORM-1717. Resolution: Won't Fix > Support Redis INRC , INRCBY and INRCBYFLOAT > --

[jira] [Commented] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322452#comment-15322452 ] ASF GitHub Bot commented on STORM-1895: --- GitHub user darionyaphet opened a pull requ

[GitHub] storm pull request #1477: [STORM-1895] Blob Store replication-factor argumen...

2016-06-09 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1477 [STORM-1895] Blob Store replication-factor argument [STORM-1895](https://issues.apache.org/jira/browse/STORM-1895) Storm command line argument --repl-fctr have update to replication-fac

[jira] [Commented] (STORM-1136) Provide a bin script to check consumer lag from KafkaSpout to Kafka topic offsets and integrate with storm ui

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322450#comment-15322450 ] ASF GitHub Bot commented on STORM-1136: --- Github user abellina commented on a diff in

[GitHub] storm pull request #1451: STORM-1136: Command line module to return kafka sp...

2016-06-09 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/storm/pull/1451#discussion_r66435002 --- Diff: storm-core/src/ui/public/topology.html --- @@ -384,8 +389,51 @@ Topology resources $('#topology-configuration [data-toggle="toolti

[jira] [Created] (STORM-1895) blobstore replication-factor argument

2016-06-09 Thread darion yaphet (JIRA)
darion yaphet created STORM-1895: Summary: blobstore replication-factor argument Key: STORM-1895 URL: https://issues.apache.org/jira/browse/STORM-1895 Project: Apache Storm Issue Type: Bug

[jira] [Created] (STORM-1894) storm-redis does not support a Redis cluster

2016-06-09 Thread Daniel Klessing (JIRA)
Daniel Klessing created STORM-1894: -- Summary: storm-redis does not support a Redis cluster Key: STORM-1894 URL: https://issues.apache.org/jira/browse/STORM-1894 Project: Apache Storm Issue T

[jira] [Updated] (STORM-1894) storm-redis does not support a Redis cluster for state saving

2016-06-09 Thread Daniel Klessing (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Klessing updated STORM-1894: --- Summary: storm-redis does not support a Redis cluster for state saving (was: storm-redis does

[jira] [Commented] (STORM-1705) Cap on number of retries for a failed message in kafka spout

2016-06-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1532#comment-1532 ] ASF GitHub Bot commented on STORM-1705: --- Github user abhishekagarwal87 commented on

[GitHub] storm issue #1331: STORM-1705: Cap number of retries for a failed message

2016-06-09 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1331 Thanks @ptgoetz and @HeartSaVioR . One thing I missed in my implementation is how to pass any additional configuration to failedMsgRetryManager. I can either add an extra HashMap or pass st

[jira] [Commented] (STORM-1873) Reemit late tuples in windowed mode

2016-06-09 Thread Balazs Kossovics (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322182#comment-15322182 ] Balazs Kossovics commented on STORM-1873: - Do you have an approximate date in mind