[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395130#comment-15395130 ] ASF GitHub Bot commented on STORM-1979: --- Github user arunmahadevan commented on a di

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72387042 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamState.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Ap

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394940#comment-15394940 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394939#comment-15394939 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72371043 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamStateUpdater.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72370968 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/bolt/DruidBeamBolt.java --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Sof

[GitHub] storm pull request #1587: [STORM-1991] Support auto.commit.interval in Kafka...

2016-07-26 Thread darionyaphet
Github user darionyaphet closed the pull request at: https://github.com/apache/storm/pull/1587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (STORM-1991) Support auto.commit.interval in Kafka Client

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394931#comment-15394931 ] ASF GitHub Bot commented on STORM-1991: --- Github user darionyaphet closed the pull re

[jira] [Commented] (STORM-2007) DRPC requests that take a long time to process fail with 500 error code

2016-07-26 Thread Manu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394861#comment-15394861 ] Manu Zhang commented on STORM-2007: --- [~ppoulosk], which version of storm are you seeing

[jira] [Commented] (STORM-2006) Storm metrics feature improvement: support per-worker level metrics aggregation

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394756#comment-15394756 ] ASF GitHub Bot commented on STORM-2006: --- Github user HeartSaVioR commented on a diff

[GitHub] storm pull request #1595: STORM-2006 Storm metrics feature improvement: supp...

2016-07-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1595#discussion_r72355902 --- Diff: conf/defaults.yaml --- @@ -259,6 +259,10 @@ topology.disruptor.batch.size: 100 topology.disruptor.batch.timeout.millis: 1 topology.disa

[jira] [Commented] (STORM-2008) kafka jars must be part of the storm-kafka topology

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394739#comment-15394739 ] ASF GitHub Bot commented on STORM-2008: --- Github user raghavgautam closed the pull re

[GitHub] storm pull request #1596: STORM-2008: kafka jars must be part of the storm-k...

2016-07-26 Thread raghavgautam
Github user raghavgautam closed the pull request at: https://github.com/apache/storm/pull/1596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Resolved] (STORM-2008) kafka jars must be part of the storm-kafka topology

2016-07-26 Thread Raghav Kumar Gautam (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghav Kumar Gautam resolved STORM-2008. Resolution: Invalid Looks this this was a conscious decision by community. > kafka

[jira] [Commented] (STORM-2008) kafka jars must be part of the storm-kafka topology

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394716#comment-15394716 ] ASF GitHub Bot commented on STORM-2008: --- GitHub user raghavgautam opened a pull requ

[GitHub] storm pull request #1596: STORM-2008:

2016-07-26 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1596 STORM-2008: This is for solving following exception that we see when we try to run TridentKafkaWordCount topology. `` Exception in thread "main" java.lang.NoClassDefFoundError: ka

[jira] [Updated] (STORM-2008) kafka jars must be part of the storm-kafka topology

2016-07-26 Thread Raghav Kumar Gautam (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghav Kumar Gautam updated STORM-2008: --- Description: As of now the dependency is present but it's scope is provided, this is

[jira] [Updated] (STORM-2008) kafka jars must be part of the storm-kafka topology

2016-07-26 Thread Raghav Kumar Gautam (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghav Kumar Gautam updated STORM-2008: --- Summary: kafka jars must be part of the storm-kafka topology (was: storm-kafka module

[jira] [Created] (STORM-2008) storm-kafka module must depend on kafka

2016-07-26 Thread Raghav Kumar Gautam (JIRA)
Raghav Kumar Gautam created STORM-2008: -- Summary: storm-kafka module must depend on kafka Key: STORM-2008 URL: https://issues.apache.org/jira/browse/STORM-2008 Project: Apache Storm Issu

[jira] [Commented] (STORM-2006) Storm metrics feature improvement: support per-worker level metrics aggregation

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394710#comment-15394710 ] ASF GitHub Bot commented on STORM-2006: --- Github user HeartSaVioR commented on a diff

[GitHub] storm pull request #1595: STORM-2006 Storm metrics feature improvement: supp...

2016-07-26 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1595#discussion_r72352692 --- Diff: conf/defaults.yaml --- @@ -259,6 +259,10 @@ topology.disruptor.batch.size: 100 topology.disruptor.batch.timeout.millis: 1 topology.disa

[jira] [Commented] (STORM-1991) Support auto.commit.interval in Kafka Client

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394577#comment-15394577 ] ASF GitHub Bot commented on STORM-1991: --- Github user hmcl commented on the issue:

[GitHub] storm issue #1587: [STORM-1991] Support auto.commit.interval in Kafka Client

2016-07-26 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1587 @darionyaphet this kafka spout does not use zookeeper as the new Kafka API writes the offsets to a topic rather than to zookeeper. As I mentioned in the initial comment, this change is not necessary. Fu

[VOTE] Release Apache Storm 1.0.2 (rc4)

2016-07-26 Thread P. Taylor Goetz
This is a call to vote on releasing Apache Storm 1.0.2 (rc4) Full list of changes in this release: https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=c9768c154166b6217ec7bffc4a9aa73e90f2339d The tag/commit to be voted upon is v1.0.2: https://git-wip-us.apache.org

[jira] [Commented] (STORM-2006) Storm metrics feature improvement: support per-worker level metrics aggregation

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394330#comment-15394330 ] ASF GitHub Bot commented on STORM-2006: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-2006) Storm metrics feature improvement: support per-worker level metrics aggregation

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394331#comment-15394331 ] ASF GitHub Bot commented on STORM-2006: --- Github user harshach commented on the issue

[GitHub] storm issue #1595: STORM-2006 Storm metrics feature improvement: support per...

2016-07-26 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1595 +1 . Minor nit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394328#comment-15394328 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on the is

[GitHub] storm pull request #1595: STORM-2006 Storm metrics feature improvement: supp...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1595#discussion_r72313373 --- Diff: conf/defaults.yaml --- @@ -259,6 +259,10 @@ topology.disruptor.batch.size: 100 topology.disruptor.batch.timeout.millis: 1 topology.disable

[GitHub] storm issue #1586: STORM-1839: Storm spout implementation for Amazon Kinesis...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on the issue: https://github.com/apache/storm/pull/1586 @harshach Thanks for the review. I have addressed your comments and pushed a commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394256#comment-15394256 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72306421 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ZkInfo.java --- @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache S

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394248#comment-15394248 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72306731 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ZkInfo.java --- @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache S

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394246#comment-15394246 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72306241 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394242#comment-15394242 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72305621 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamState.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394238#comment-15394238 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72305457 --- Diff: external/storm-kinesis/README.md --- @@ -0,0 +1,139 @@ +#Storm Kinesis Spout +Provides core storm spout for consuming data from a stream

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394235#comment-15394235 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72305349 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394228#comment-15394228 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394230#comment-15394230 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72305189 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72305132 --- Diff: external/storm-druid/src/test/java/org/apache/storm/druid/SampleDruidBeamFactoryImpl.java --- @@ -0,0 +1,116 @@ +/** + * Licensed to the A

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394226#comment-15394226 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72304984 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamState.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394224#comment-15394224 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72304830 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamState.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394225#comment-15394225 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72304747 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamState.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394220#comment-15394220 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72304436 --- Diff: external/storm-druid/pom.xml --- @@ -0,0 +1,88 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.

[GitHub] storm pull request #1583: STORM-1979: Storm Druid Connector implementation.

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1583#discussion_r72303978 --- Diff: external/storm-druid/src/main/java/org/apache/storm/druid/bolt/DruidBeamBolt.java --- @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Sof

[jira] [Commented] (STORM-1979) Storm Druid Connector

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394215#comment-15394215 ] ASF GitHub Bot commented on STORM-1979: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72303034 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisConnectionInfo.java --- @@ -0,0 +1,137 @@ +/** + * Licensed

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394209#comment-15394209 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394210#comment-15394210 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72302997 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisConnectionInfo.java --- @@ -0,0 +1,137 @@ +/** + * Licensed

[GitHub] storm issue #1586: STORM-1839: Storm spout implementation for Amazon Kinesis...

2016-07-26 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1586 @priyank5485 looks great!. Mostly nit-picks. I'll go over the retry handle one more time and add any comments if needed. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394187#comment-15394187 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on the issue

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394185#comment-15394185 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394182#comment-15394182 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72300622 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ZkInfo.java --- @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache Soft

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72300543 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ZkInfo.java --- @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache Soft

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394164#comment-15394164 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72299262 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394156#comment-15394156 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394158#comment-15394158 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72298893 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394152#comment-15394152 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72298863 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72298716 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394134#comment-15394134 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394137#comment-15394137 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72297573 --- Diff: external/storm-kinesis/README.md --- @@ -0,0 +1,139 @@ +#Storm Kinesis Spout +Provides core storm spout for consuming data from a stream in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72296861 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394132#comment-15394132 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72296990 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394128#comment-15394128 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394130#comment-15394130 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72296389 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72296325 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisRecordsManager.java --- @@ -0,0 +1,566 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394116#comment-15394116 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72294716 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisConnectionInfo.java --- @@ -0,0 +1,137 @@ +/** + * Licensed to

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394112#comment-15394112 ] ASF GitHub Bot commented on STORM-1839: --- Github user harshach commented on a diff in

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72294493 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/KinesisConnectionInfo.java --- @@ -0,0 +1,137 @@ +/** + * Licensed to

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72291643 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ExponentialBackoffRetrier.java --- @@ -0,0 +1,164 @@ +/** + * Licen

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394096#comment-15394096 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72292758 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ExponentialBackoffRetrier.java --- @@ -0,0 +1,164 @@ +/** + * Licen

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394091#comment-15394091 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72292144 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ExponentialBackoffRetrier.java --- @@ -0,0 +1,164 @@ +/** + * Licen

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394088#comment-15394088 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72291939 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ExponentialBackoffRetrier.java --- @@ -0,0 +1,164 @@ +/** + * Licen

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394087#comment-15394087 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72291774 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ExponentialBackoffRetrier.java --- @@ -0,0 +1,164 @@ +/** + * Licen

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394083#comment-15394083 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[jira] [Commented] (STORM-1839) Kinesis Spout

2016-07-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394086#comment-15394086 ] ASF GitHub Bot commented on STORM-1839: --- Github user priyank5485 commented on a diff

[GitHub] storm pull request #1586: STORM-1839: Storm spout implementation for Amazon ...

2016-07-26 Thread priyank5485
Github user priyank5485 commented on a diff in the pull request: https://github.com/apache/storm/pull/1586#discussion_r72291464 --- Diff: external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/Config.java --- @@ -0,0 +1,166 @@ +/** + * Licensed to the Apache S

  1   2   >