Re: storm-jms

2016-08-25 Thread S G
Got it. Thanks a lot Taylor ! On Thu, Aug 25, 2016 at 4:34 PM, P. Taylor Goetz wrote: > It's on central now: > > http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22storm-jms%22 > > -Taylor > > > On Aug 25, 2016, at 7:04 PM, S G wrote: > > > > I dont see it yet on > > https://mvnrepository.com/ar

[jira] [Created] (STORM-2057) Support JOIN statement in Storm SQL

2016-08-25 Thread Jungtaek Lim (JIRA)
Jungtaek Lim created STORM-2057: --- Summary: Support JOIN statement in Storm SQL Key: STORM-2057 URL: https://issues.apache.org/jira/browse/STORM-2057 Project: Apache Storm Issue Type: New Featur

[jira] [Updated] (STORM-2056) Bugs in logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: 1. Incorrect url for prev,first,last,next buttons when viewing daemon logs vi

Re: storm-jms

2016-08-25 Thread P. Taylor Goetz
It's on central now: http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22storm-jms%22 -Taylor > On Aug 25, 2016, at 7:04 PM, S G wrote: > > I dont see it yet on > https://mvnrepository.com/artifact/com.github.ptgoetz/storm-jms > Does it take a lot of time to reflect the change? > >> On Thu, Aug

Re: storm-jms

2016-08-25 Thread S G
I dont see it yet on https://mvnrepository.com/artifact/com.github.ptgoetz/storm-jms Does it take a lot of time to reflect the change? On Thu, Aug 25, 2016 at 1:38 PM, P. Taylor Goetz wrote: > Bits are on their way to maven central. > > > com.github.ptgoetz > storm-jms >

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76334398 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76334407 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm issue #1642: DO NOT MERGE: Please review STORM-2018: Supervisor V2.

2016-08-25 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1642 @harshach @knusbaum I think I addressed all of your review comments along with upmerging to the latest master. I still have a bit more to do, mostly with writing a replacement for supervisor_test.cl

Re: Details about the Storm Scheduler

2016-08-25 Thread Roshan Naik
Indeed. Since Bobby was pointing out that CPU consumption monitoring is impractical at a component level... My suggestion was merely intended as a next best alternative. -roshan From: Nathan Leung mailto:ncle...@gmail.com>> Date: Wednesday, August 24, 2016 at 7:24 AM To: "dev@storm.apache.org

Re: storm-jms

2016-08-25 Thread P. Taylor Goetz
Bits are on their way to maven central. com.github.ptgoetz storm-jms 1.0.2 -Taylor > On Aug 25, 2016, at 2:32 PM, S G wrote: > > Thanks a lot Taylor ! > Waiting to get the next storm-jms > > On Thu, Aug 25, 2016 at 10:52 AM, P. Taylor Goetz wrote: > >> Hi SG, >> >

Package name changes for 3rd party storm dependencies

2016-08-25 Thread S G
Hi, Our project is planning to upgrade storm from 0.10.0 to 1.0.2 We use a couple of 3rd party storm dependencies like storm-jms, https://github.com/HolmesNL/kafka-spout etc. Some of these projects have plans to upgrade soon to 1.0.2 but some do not have it on their roadmap. What is the best str

[jira] [Updated] (STORM-2056) Bugs in logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: 1. Incorrect url for prev,first,last,next buttons when viewing daemon logs vi

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76309477 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -17,135 +17,541 @@ */ package org.apache.storm.daemon.superv

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76309388 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation (A

[jira] [Updated] (STORM-2056) Bugs in logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: 1. Incorrect url for prev,first,last,next buttons when viewing daemon logs vi

[GitHub] storm issue #1649: STORM-2052: Kafka Spout - New Client API - Performance Im...

2016-08-25 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1649 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76308994 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation (A

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76308561 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76308272 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fou

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-08-25 Thread P. Taylor Goetz
I didn’t mean to imply that the code donation would come with automatic committership. I would expect the SQE developers to engage with the Storm community and show merit before being invited to become committers. If for some reason that didn’t happen, we would always have the option of not doin

[jira] [Updated] (STORM-2056) Bugs in logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: 1. Incorrect url for prev,first,last,next buttons when viewing daemon logs vi

[jira] [Updated] (STORM-2056) Bugs in logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Priority: Major (was: Minor) > Bugs in logviewer > - > >

[jira] [Updated] (STORM-2056) Bugs in logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Summary: Bugs in logviewer (was: Incorrect url for prev,first,last,next buttons when view

[jira] [Updated] (STORM-2056) Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: Incorrect url for prev,first,last,next buttons when viewing daemon logs via

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76303019 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] storm issue #1649: STORM-2052: Kafka Spout - New Client API - Performance Im...

2016-08-25 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1649 @harshach Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[jira] [Updated] (STORM-2052) Kafka Spout New Client API - Log Improvements and Parameter Tuning for Better Performance

2016-08-25 Thread Hugo Louro (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hugo Louro updated STORM-2052: -- Summary: Kafka Spout New Client API - Log Improvements and Parameter Tuning for Better Performance (was

Re: storm-jms

2016-08-25 Thread S G
Thanks a lot Taylor ! Waiting to get the next storm-jms On Thu, Aug 25, 2016 at 10:52 AM, P. Taylor Goetz wrote: > Hi SG, > > Yes, that is possible. I need to track down some contributors and get > ICLAS, and go through the IP clearance process before that can happen. > > In the meantime, I will

[jira] [Updated] (STORM-2056) Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: Example: http://storm.cluster.com:8000/log?file=nimbus.log&start=0&length=51

[jira] [Updated] (STORM-2056) Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: Example: http://storm.cluster.com:8000/log?file=scheduler.log&start=0&length

[jira] [Updated] (STORM-2056) Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: Example: http://storm.cluster.com:8000/log?file=scheduler.log&start=0&length

[jira] [Updated] (STORM-2056) Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: Example: http://storm.cluster.com:8000/log?file=nimbus.log&start=0&length=51

[jira] [Updated] (STORM-2056) Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Jerry Peng updated STORM-2056: - Description: Example: http://storm.cluster.com:8000/log?file=scheduler.log&start=0&length

[jira] [Created] (STORM-2056) Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer

2016-08-25 Thread Boyang Jerry Peng (JIRA)
Boyang Jerry Peng created STORM-2056: Summary: Incorrect url for prev,first,last,next buttons when viewing daemon logs via logviewer Key: STORM-2056 URL: https://issues.apache.org/jira/browse/STORM-2056

[jira] [Updated] (STORM-2052) Kafka Spout - New Client API - Log Improvements and Parameter Tuning for Better Performance

2016-08-25 Thread Hugo Louro (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hugo Louro updated STORM-2052: -- Summary: Kafka Spout - New Client API - Log Improvements and Parameter Tuning for Better Performance (w

Re: storm-jms

2016-08-25 Thread P. Taylor Goetz
Hi SG, Yes, that is possible. I need to track down some contributors and get ICLAS, and go through the IP clearance process before that can happen. In the meantime, I will update the project to use the latest version of Storm and release it to maven central. -Taylor > On Aug 25, 2016, at 1:03

[GitHub] storm issue #1649: STORM-2052: Kafka Spout - New Client API - Performance Im...

2016-08-25 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1649 @hmcl we cherry-pick the entire JIRA into other branches. It doesn't make sense to cherry-pick partial commits of a JIRA for releases. So squash the commits into one as they are all related to this

storm-jms

2016-08-25 Thread S G
Hi, It seems that https://github.com/ptgoetz/storm-jms is running 0.9.3 version of storm. Any chance that it can be added to storm/external and kept up-to-date with latest releases of storm? Thanks SG

[GitHub] storm issue #1649: STORM-2052: Kafka Spout - New Client API - Performance Im...

2016-08-25 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1649 can you also fix the JIRA title . Given that these are default config changes and not really performance fixes in the code. --- If your project is set up for it, you can reply to this email and hav

[GitHub] storm pull request #1649: STORM-2052: Kafka Spout - New Client API - Perform...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1649#discussion_r76279827 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -221,7 +224,22 @@ private boolean commit() {

[GitHub] storm issue #1649: STORM-2052: Kafka Spout - New Client API - Performance Im...

2016-08-25 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1649 @hmcl all the commit title as the same text "Kafka Spout - New Client API - Performance Improvements" --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1649: STORM-2052: Kafka Spout - New Client API - Performance Im...

2016-08-25 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1649 @harshach I can squash the commits, but I left these three commits on purpose. Each commit is a logical groping. One is docs, one is the default values, and one is the logging changes. They all have the

[GitHub] storm pull request #1649: STORM-2052: Kafka Spout - New Client API - Perform...

2016-08-25 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1649#discussion_r76275357 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -221,7 +224,22 @@ private boolean commit() { }

[GitHub] storm issue #1642: DO NOT MERGE: Please review STORM-2018: Supervisor V2.

2016-08-25 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1642 @revans2 gave a first pass. In terms of readability this looks great. Left minor comments and would like to see supervisor.lanuch() command broken down to smaller pieces if possible and some docs a

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76274105 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -17,135 +17,541 @@ */ package org.apache.storm.daemon.super

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76273872 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] storm issue #838: [STORM-885] Heartbeat Server (Pacemaker)

2016-08-25 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/838 @knusbaum please file a JIRA and make sure that we do that soon. Did you do that work or was it @redsanket ? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76272537 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76272495 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] storm issue #838: [STORM-885] Heartbeat Server (Pacemaker)

2016-08-25 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/838 @revans2 It looks like the HA/load balancing stuff didn't get pushed back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76271453 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270332 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76271101 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270910 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270667 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270530 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76269608 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software Fo

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-08-25 Thread Jungtaek Lim
Yes that's why I'm emphasizing more about potential contributors instead of SQE codebase. I skimmed the codebase, and couldn't find notable features compared to Storm SQL. TODOs for Storm SQL also seems to be a TODO of SQE. Since I recently pushed some features so I might be biased. I'd be appreci

[jira] [Commented] (STORM-1446) Compile the Calcite logical plan to Storm physical plan

2016-08-25 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436979#comment-15436979 ] Jungtaek Lim commented on STORM-1446: - Just posted a question to Calcite dev@ list to

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76245840 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -17,135 +17,541 @@ */ package org.apache.storm.daemon.superv

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76245649 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,417 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] storm issue #838: [STORM-885] Heartbeat Server (Pacemaker)

2016-08-25 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/838 @knusbaum can you please take a look at what we have internally and be sure that the fail over/load balancing features all got merged in to open source? If it is all in then we probably need some bet

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-08-25 Thread Bobby Evans
I agree that committership should not come form a code donation, but on the other hand a code donation needs to have a community with it to be viable. That is the one thing that makes slightly nervous here. https://github.com/jwplayer/SQE/pulse https://github.com/jwplayer/SQE/graphs/contributors

[jira] [Resolved] (STORM-2050) [storm-sql] Support User Defined Aggregate Function for Trident mode

2016-08-25 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-2050. - Resolution: Fixed Fix Version/s: 1.1.0 2.0.0 Merged into master and 1.x-

[GitHub] storm pull request #1643: STORM-2050 [storm-sql] Support User Defined Aggreg...

2016-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1643 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #1643: STORM-2050 [storm-sql] Support User Defined Aggregate Fun...

2016-08-25 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1643 @arunmahadevan Thanks for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[jira] [Commented] (STORM-2028) Exceptions in JDBCClient are hidden by subsequent SQL-Exception in close()

2016-08-25 Thread Rick Moritz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436749#comment-15436749 ] Rick Moritz commented on STORM-2028: Upon inspection, something like the following met

[GitHub] storm issue #1643: STORM-2050 [storm-sql] Support User Defined Aggregate Fun...

2016-08-25 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1643 +1 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

Re: [DISCUSS] Accept JW Player SQE Code Donation

2016-08-25 Thread Jungtaek Lim
I'd postpone to talk about committership a bit later after they show active contributions. Personally I don't like associating code donation and committership but it's just me. Storm SQL (or SQL feature for all projects) has lots of places for contributions so they can be eventually invited like ot

[jira] [Comment Edited] (STORM-1444) Support EXPLAIN statement in StormSQL

2016-08-25 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436500#comment-15436500 ] Jungtaek Lim edited comment on STORM-1444 at 8/25/16 8:39 AM: --

[jira] [Commented] (STORM-1444) Support EXPLAIN statement in StormSQL

2016-08-25 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436500#comment-15436500 ] Jungtaek Lim commented on STORM-1444: - Since we construct TridentTopology to submit to