[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89674302 --- Diff: storm-core/src/jvm/org/apache/storm/nimbus/NimbusInfo.java --- @@ -49,17 +51,17 @@ public static NimbusInfo parse(String nimbusInfo) { }

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89673963 --- Diff: storm-core/src/jvm/org/apache/storm/cluster/IStormClusterState.java --- @@ -117,10 +128,60 @@ public ErrorInfo lastError(String stormId,

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89674891 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1672,11 +1672,12 @@ public void uncaughtException(Thread thread, Throwable thrown) {

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89673824 --- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java --- @@ -304,6 +307,41 @@ public void readBlobTo(String key, OutputStream out, Subject who)

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89672579 --- Diff: storm-core/src/clj/org/apache/storm/testing.clj --- @@ -171,7 +172,56 @@ ;; local dir is always overridden in maps ;; can customize the superv

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89674443 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java --- @@ -167,15 +175,21 @@ public static IPrincipalToLocal GetPrincipalToLocalPlugin(M

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89672804 --- Diff: storm-core/src/clj/org/apache/storm/testing.clj --- @@ -242,11 +297,12 @@ (.stop (:nimbus-thrift-server cluster-map)) (catch E

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89674623 --- Diff: storm-core/src/jvm/org/apache/storm/stats/StatsUtil.java --- @@ -1505,19 +1508,18 @@ public static ComponentPageInfo aggCompExecsStats( * @ret

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89674074 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/nimbus/TopologyStateTransition.java --- @@ -0,0 +1,27 @@ +/** + * Licensed to the Apache Software F

[GitHub] storm pull request #1800: STORM-2217: Make DRPC pure java

2016-11-26 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1800 STORM-2217: Make DRPC pure java This sets up some things for using Jersey for the UI, logviewer, and DRPC. It is not perfect and will probably need some clean up over time as we try to pull in UI

[GitHub] storm issue #1800: STORM-2217: Make DRPC pure java

2016-11-26 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1800 Will rebase soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or