[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

2016-11-28 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Are storm metrics reported through JMX too?

2016-11-28 Thread S G
Hi, I see https://issues.apache.org/jira/browse/STORM-2153 being open for this and a lot of good discussion happening too. There is also a talk for releasing 1.1.0 version soon. So I just wanted to check if any metric related improvements will be available in 1.1.0. It would be great to try out

Fwd: JSON License and Apache Projects

2016-11-28 Thread P. Taylor Goetz
FYI. Official statement from VP Legal regarding use of json.org licensed code. -Taylor > Begin forwarded message: > > From: Jim Jagielski > Subject: JSON License and Apache Projects > Date: November 23, 2016 at 9:08:30 AM EST > To: legal-disc...@apache.org

[GitHub] storm pull request #1804: STORM-2222: Repeated NPEs thrown in nimbus if reba...

2016-11-28 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/1804 STORM-: Repeated NPEs thrown in nimbus if rebalance fails You can merge this pull request into a Git repository by running: $ git pull https://github.com/knusbaum/incubator-storm

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

2016-11-28 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1470 @kosii thanks for working on this. Will take a look one final time and merge it if it looks fine. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1470: STORM-1886 Extend KeyValueState iface with delete

2016-11-28 Thread kosii
Github user kosii commented on the issue: https://github.com/apache/storm/pull/1470 @arunmahadevan I'm very sorry for disappearing for such a long time. I addressed all the comments, I also fixed the race condition in my last commit --- If your project is set up for it, you can

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

2016-11-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1783 +1 the code looks fine to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1783: STORM-2204 Adding caching capabilities in HBaseLookupBolt

2016-11-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1783 @HeartSaVioR I also am find with Caffeine and even Caffeine on 1.x (assuming it is off by default) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89806015 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java --- @@ -1672,11 +1672,12 @@ public void uncaughtException(Thread thread, Throwable thrown) {

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89805725 --- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj --- @@ -963,11 +963,11 @@ "uptimeSeconds" uptime "host" host "port"

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89789081 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AuthUtils.java --- @@ -167,15 +175,21 @@ public static IPrincipalToLocal

[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

2016-11-28 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1744#discussion_r89782717 --- Diff: storm-core/src/clj/org/apache/storm/testing.clj --- @@ -242,11 +297,12 @@ (.stop (:nimbus-thrift-server cluster-map))

[GitHub] storm issue #1789: STORM-2209: Update documents adding new integration for s...

2016-11-28 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1789 I created https://github.com/apache/storm/pull/1802 for 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #1802: STORM-2209: 1.x-branch Update documents adding new...

2016-11-28 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/1802 STORM-2209: 1.x-branch Update documents adding new integration for some external systems This PR is STORM-2209 for 1.x-branch. PR for master branch has been merged. You can merge this pull

[GitHub] storm issue #1800: STORM-2217: Make DRPC pure java

2016-11-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1800 Rebased the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm pull request #1801: STORM-2220 Added config key support in Cassandra b...

2016-11-28 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1801#discussion_r89748591 --- Diff: external/storm-cassandra/src/main/java/org/apache/storm/cassandra/bolt/BaseCassandraBolt.java --- @@ -92,6 +94,8 @@ public void prepare(Map