Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1823
Thanks @marblejenka Merged into 1.x-branch and cherry-picked to master
branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1823
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user csivaguru commented on the issue:
https://github.com/apache/storm/pull/1816
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1823
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ikashperskyi commented on the issue:
https://github.com/apache/storm/pull/1822
Now that I think about it we are currently returning a single value tuple
with a map so it would make sense to return a pair instead.
@HeartSaVioR @wurstmeister @vesense @asmaier guys
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1821
@hmcl I'd be happy to add comments explaining the propagation. Calling
`close()` isn't enough. When the Kafka exception is thrown, the thread
interrupt state is cleared (same behavior as the Java
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1821
@srdo I think I understand what you mean. However, I think that the
cleanest way to do this is to catch kafka's InterruptException, and call the
Spout's `close()` method. If it is an error from which
Github user ikashperskyi commented on the issue:
https://github.com/apache/storm/pull/1822
@wurstmeister could you advise if this is a bug or why did we go with only
one field if it's not?
@HeartSaVioR this would go into the next major release so I would worry
about
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
@srdo as part of backporting this to 1.x I am going to need to make a
change to not use Function directly, because it is only in java 8. So to
maintain compatibility between 1.x and 2.x I am going
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1821
I went ahead and replaced the interrupts with `throw new
RuntimeException(new InterruptedException());`, that way the executor stops
immediately instead of waiting for next check in the async loop.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1823
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1821
@srdo [Kafka's
InterruptException](https://kafka.apache.org/090/javadoc/org/apache/kafka/common/errors/InterruptException.html)
is a RuntimeException, otherwise the code wouldn't even compile without
12 matches
Mail list logo
