Re: Twitter4j dependency (can't release Apache Storm)

2017-01-04 Thread Jungtaek Lim
It would be better to initiate a new thread for that, since it's not related to this thread. - Jungtaek Lim (HeartSaVioR) 2017년 1월 5일 (목) 오후 1:46, S G 님이 작성: Should we consider upgrading some versions in our pom.xml also?

Re: Twitter4j dependency (can't release Apache Storm)

2017-01-04 Thread S G
Should we consider upgrading some versions in our pom.xml also? https://github.com/apache/storm/blob/master/pom.xml#L265 Some versions we use and the latest are: zookeeper - 3.4.6 --> 3.4.9 jackson - 2.6.3 --> 2.8.5 kryo - 3.0.3 --> 4.0.0 avro - 1.7.7 --> 1.8.1 Thanks SG On Wed, Jan 4, 2017

Re: [DISCUSS] Release Storm 1.1.0

2017-01-04 Thread Jungtaek Lim
Recently we receive some requests regarding release Storm 1.0.3, so would like to bump this again. Given that blocker issues for Storm 1.1.0 are also blocker for 1.0.3, I'd like to ask a favor of taking care of 'open' / 'in progress' issues on 1.1.0 epic.

Re: Twitter4j dependency (can't release Apache Storm)

2017-01-04 Thread Jungtaek Lim
FYI: I picked this up. - Issue: STORM-2276 - PR for master: https://github.com/apache/storm/pull/1858 - PR for 1.x branch: https://github.com/apache/storm/pull/1859 - PR for 1.0.x branch: https://github.com/apache/storm/pull/1860 Let's review

[GitHub] storm pull request #1860: STORM-2276 Remove twitter4j usages due to license ...

2017-01-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1860 STORM-2276 Remove twitter4j usages due to license issue (1.0.x) Please refer the issue for the detail. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #1859: STORM-2276 Remove twitter4j usages due to license ...

2017-01-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1859 STORM-2276 Remove twitter4j usages due to license issue (1.x) Please refer the issue for the detail. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #1858: STORM-2276 Remove twitter4j usages due to license ...

2017-01-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1858 STORM-2276 Remove twitter4j usages due to license issue (JSON.org is catalog X) Please refer the [issue](http://issues.apache.org/jira/browse/STORM-2276) for the detail. You can merge this

[GitHub] storm issue #1851: STORM-2270 Kafka spout should consume from latest when ZK...

2017-01-04 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/1851 @HeartSaVioR thx, i have changed the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2017-01-04 Thread mazhechao
Github user mazhechao commented on the issue: https://github.com/apache/storm/pull/1136 Thats great. I hope this pull request can be accepted and released soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #1851: Kafka spout should consume from latest when ZK partition ...

2017-01-04 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/1851 @danny0405 : thanks for the adjustment! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1854: STORM-2272: don't leak simulated time

2017-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1854 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1857: STORM-2275: Nimbus crashed during state transition of top...

2017-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1857 Nice finding. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #1851: Kafka spout should consume from latest when ZK partition ...

2017-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1851 Please change the PR's title to add a prefix "STORM-2270" so that it can be automatically linked. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1851: Kafka spout should consume from latest when ZK partition ...

2017-01-04 Thread danny0405
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/1851 @erikdw thx for your nice review, i have change the style ^_^ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

2017-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1810 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1810: STORM-2204 Adding Bolt side caching for HBase Lookup Bolt...

2017-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1810 Master branch of storm-hbase still has guava as dependency even we use Caffeine, since hbase-server depends on Guava 16.0.1. So this patch doesn't add new guava dependency. I'll merge this.

[GitHub] storm issue #1835: STORM-2236: Kafka Spout with manual partition management.

2017-01-04 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1835 Hi, all: All commits have been squashed into one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm issue #1845: Create DRPC client printer class reusable for local and r...

2017-01-04 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1845 JIRA? Rationale? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm pull request #1857: STORM-2275: Nimbus crashed during state transition...

2017-01-04 Thread raghavgautam
GitHub user raghavgautam opened a pull request: https://github.com/apache/storm/pull/1857 STORM-2275: Nimbus crashed during state transition of topology You can merge this pull request into a Git repository by running: $ git pull https://github.com/raghavgautam/storm master

[GitHub] storm issue #1855: PMMLPredictorBolt - Handle duplicate output and predicted...

2017-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1855 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1856: PMMLPredictorBolt - Handle duplicate output and predicted...

2017-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1856 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1845: Create DRPC client printer class reusable for local and r...

2017-01-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1845 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1844: STORM-2265: Incorrectly Serialized JSON in TransactionalS...

2017-01-04 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1844 @HeartSaVioR I agree with you. Let's merge [STORM-2264](https://github.com/apache/storm/pull/1853) and keep this open to explore a more compelling fix. If we find out that the work around the Stream

[GitHub] storm issue #1853: STORM-2264 OpaqueTridentKafkaSpout failing after STORM-22...

2017-01-04 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1853 +1 @HeartSaVioR [STORM-2265](https://github.com/apache/storm/pull/1844) is a duplicate of this that I found independently. We can go ahead and merge this (revert) fix. We can keep STORM-2265 open

[GitHub] storm issue #1845: Create DRPC client printer class reusable for local and r...

2017-01-04 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1845 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94649177 --- Diff: storm-core/test/jvm/org/apache/storm/scheduler/blacklist/TestBlacklistScheduler.java --- @@ -0,0 +1,336 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94665415 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94661600 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94675511 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94665531 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94678615 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/DefaultBlacklistStrategy.java --- @@ -0,0 +1,149 @@ +/** + * Licensed

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94677722 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94675703 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94668925 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94668597 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94677987 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94678822 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/IBlacklistStrategy.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94668464 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,252 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #1856: PMMLPredictorBolt - Handle duplicate output and predicted...

2017-01-04 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1856 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94678786 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/strategies/IBlacklistStrategy.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94665652 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java --- @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #1856: PMMLPredictorBolt - Handle duplicate output and predicted...

2017-01-04 Thread csivaguru
Github user csivaguru commented on the issue: https://github.com/apache/storm/pull/1856 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1674: STORM-2083: Blacklist scheduler

2017-01-04 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1674#discussion_r94675699 --- Diff: storm-core/src/jvm/org/apache/storm/scheduler/blacklist/CircularBuffer.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1856: PMMLPredictorBolt - Handle duplicate output and pr...

2017-01-04 Thread hmcl
GitHub user hmcl opened a pull request: https://github.com/apache/storm/pull/1856 PMMLPredictorBolt - Handle duplicate output and predicted fields Backport to 1.x-branch You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm issue #1855: PMMLPredictorBolt - Handle duplicate output and predicted...

2017-01-04 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1855 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1855: PMMLPredictorBolt - Handle duplicate output and predicted...

2017-01-04 Thread csivaguru
Github user csivaguru commented on the issue: https://github.com/apache/storm/pull/1855 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm pull request #1855: PMMLPredictorBolt - Handle duplicate output and pr...

2017-01-04 Thread hmcl
GitHub user hmcl opened a pull request: https://github.com/apache/storm/pull/1855 PMMLPredictorBolt - Handle duplicate output and predicted fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/hmcl/storm-apache

[GitHub] storm pull request #1854: STORM-2272: don't leak simulated time

2017-01-04 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1854 STORM-2272: don't leak simulated time You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-2272 Alternatively you can

[GitHub] storm pull request #1793: STORM-2214: add in cacheing of the Login

2017-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1793: STORM-2214: add in cacheing of the Login

2017-01-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1793 I also wanted to say we have been running with this in prod for a while now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #1793: STORM-2214: add in cacheing of the Login

2017-01-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1793 @harshach the issue is that when there are lots of supervisors the load placed on the KDC is a lot higher than it is for a similar number of Hadoop nodes. Each new Login will contact the KDC and

[GitHub] storm issue #1136: [STORM-1565] Multi-Lang Performance Improvements

2017-01-04 Thread dan-blanchard
Github user dan-blanchard commented on the issue: https://github.com/apache/storm/pull/1136 > Will MessagePackSerializer solve this problem? It will if this code is updated to use the latest version of the `msgpack-core` library. As I mentioned in a previous comment:

[GitHub] storm pull request #1853: STORM-2264 OpaqueTridentKafkaSpout failing after S...

2017-01-04 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/1853 STORM-2264 OpaqueTridentKafkaSpout failing after STORM-2216 * use JSONValue.parse() instead of JSONValue.parseWithException() in TransactionState * this just rolls back to previous,

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-04 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1131 @jianbzhou thanks for your suggested fix and for the summary of changes. I think that the best way to go about incorporating your changes is to create a JIRA with summary along the lines "Kafka Spout

Re: ever seen the netty message_queue grow (seemingly) infinitely?

2017-01-04 Thread Jungtaek Lim
May you already know about this, please also note that count of metrics tuples are linear with overall task count. Higher parallelism puts more pressure to the metrics bolt. I guess Taylor and Alessandro have been working on metrics v2. Unless we finish metrics v2, we can just reduce the load

Re: ever seen the netty message_queue grow (seemingly) infinitely?

2017-01-04 Thread Bobby Evans
Yes you are right that will not help.  The best you can do now is to increase the number of MetricsConsumer instances that you have.  You can do this when you register the metrics consumer. conf.registerMetricsConsumer(NoOpMetricsConsumer.class, 3); The default is 1, but we have see with very

[GitHub] storm pull request #1852: [STORM-2271] ClosedByInterruptException should be ...

2017-01-04 Thread redsanket
GitHub user redsanket opened a pull request: https://github.com/apache/storm/pull/1852 [STORM-2271] ClosedByInterruptException should be handled in few cases and removing a confusing debug statement You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request #1849: STORM-2267 Use user's local maven repo. directory ...

2017-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1849 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #1837: [STORM-2254] Provide Socket time out for nimbus th...

2017-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-04 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/1131 > Btw, I just send the latest code to you via email. @jianbzhou: can you please clarify the "you" in this statement? > we have communicated via email for a while and going forward

[GitHub] storm pull request #1851: Kafka spout should consume from latest when ZK par...

2017-01-04 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/1851#discussion_r94543681 --- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/PartitionManager.java --- @@ -199,7 +199,12 @@ private void fill() { try {