[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1891 @harshach Even auto commit is enabled, the acked tuples can not be removed from emitted sets. Here is the calling sequence when ack is disabled: 1. outputCollector.emit(msgId) 1.1 sp

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r97536386 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/streams/BranchExample.java --- @@ -0,0 +1,72 @@ +/** + * Licensed to the Apac

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r97536518 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/streams/GroupByKeyAndWindowExample.java --- @@ -0,0 +1,109 @@ +/** + * Licens

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r97536479 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/streams/GroupByKeyAndWindowExample.java --- @@ -0,0 +1,109 @@ +/** + * Licens

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r97537762 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the

[GitHub] storm issue #1693: [STORM-1961] Stream api for storm core use cases

Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/1693 @revans2 thanks for taking the time to review. >I really would like to see how triggers and exactly once processing might fit into this. Not that we need it right now, but just that I w

[GitHub] storm pull request #1892: remove unused import in module kafkaclient

GitHub user pczb opened a pull request: https://github.com/apache/storm/pull/1892 remove unused import in module kafkaclient just remove some unused import and all tests passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/pczb/

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r97565415 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 @harshach I am happy to once I get a +1 on #1808 too. It has almost identical code, but is for master. --- If your project is set up for it, you can reply to this email and have your reply appear o

Re: Local BlobStore and Nimbus H/A

I just skimmed the blobstore code, and some questions about the implementation. I'd be really appreciated if someone understanding BlobStore answers below questions. (Questions are based on current 1.x branch, but I think master branch is similar.) 1. In get-version-for-key, it always create KeySe

[GitHub] storm pull request #1693: [STORM-1961] Stream api for storm core use cases

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1693#discussion_r97597172 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/streams/TypedTupleExample.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the

[GitHub] storm issue #1808: STORM-2225: change spout config to be simpler.

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1808 There are still a few files with tabs mixed in to spaces, so autoformatting all the files might be good. I also still don't really understand why the KafkaSpoutConfig builder needs to support setting a

[GitHub] storm issue #1832: STORM-2250: Kafka Spout Refactoring to Increase Modularit...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/1832 @hmcl Renamed. I'll wait until https://github.com/apache/storm/pull/1808 has been merged to fix conflicts here, since it's likely there's some overlap --- If your project is set up for it, you can repl

[GitHub] storm issue #1845: STORM-2320: DRPC client printer class reusable for local ...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1845 +1 thanks for the update @hmcl --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: Fw: Re: Local BlobStore and Nimbus H/A

(adding missed dev@) Thanks Sanket to answer questions. Following up questions inline. Thanks, Jungtaek Lim (HeartSaVioR) 2017년 1월 25일 (수) 오전 3:13, Sanket Chintapalli 님이 작성: > > Questions related to blobstore > > 1. In get-version-for-key, it always create KeySequenceNumber instance so > synch