Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1897
@jnioche
Yes I also think you can replace StormRunner with ConfigurableTopology.
Btw, there're lots of topologies so you might want to only apply some of
them. If that's the case please
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1897
Thanks @HeartSaVioR. Good idea, I'll have a look at the topology classes in
storm-starter. Just came across the
(StormRunner)[https://github.com/apache/storm/blob/master/examples/storm-starter/src/jv
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1902
@hmcl overall looks good to me. Left few questions. @hmcl has some good
points around the topic names.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98594395
--- Diff: pom.xml ---
@@ -267,7 +267,7 @@
kafka_2.10
-0.10.0.0
+0.10.1.1
--- End diff --
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98593964
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -47,70 +33,111 @@
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98593892
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -47,70 +33,111 @@
impo
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@harshach @hmcl
Then we should add available topologies in README for each modules to since
users don't know which topologies are available.
---
If your project is set up for it, you can re
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98593325
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -47,70 +33,111 @@
import
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1898
I'm +1 given that you tested this manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1901
+1 Nice catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98588501
--- Diff:
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/trident/TridentKafkaClientWordCountNamedTopics.java
---
@@ -107,8 +11
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98589751
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -47,70 +33,111 @@
impo
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98588817
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutBatchMetadata.java
---
@@ -74,8 +74,8 @@ public
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98591458
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -161,31 +187,84 @@ private
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98590853
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutOpaqueCoordinator.java
---
@@ -57,8 +57,8 @@ pu
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98591120
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutTopicPartition.java
---
@@ -43,7 +43,7 @@ publi
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98590830
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutOpaque.java
---
@@ -79,8 +72,8 @@ public Fields
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98588609
--- Diff:
examples/storm-kafka-examples/src/main/java/org/apache/storm/kafka/trident/LocalSubmitter.java
---
@@ -43,10 +43,15 @@ public static LocalSubmi
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98590052
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
---
@@ -196,8 +275,8 @@ public voi
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98590758
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutManager.java
---
@@ -107,9 +90,25 @@ Fields get
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98588677
--- Diff:
examples/storm-kafka-examples/src/main/java/org/apache/storm/kafka/trident/TridentKafkaWordCount.java
---
@@ -95,7 +95,8 @@ public static void
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1902#discussion_r98588416
--- Diff:
examples/storm-kafka-client-examples/src/main/java/org/apache/storm/kafka/trident/TridentKafkaClientWordCountNamedTopics.java
---
@@ -107,8 +11
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1868
@revans2
Seems like the commit for JDK 7 is removed so Travis CI shows compile error
on JDK 7. Could you address this?
---
If your project is set up for it, you can reply to this email and
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1808
Thanks for the great work and patience. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1897
@jnioche
Thanks for the contribution. It looks good.
Btw, it would be great if we apply ConfigurableTopology to all of topology
implementations on example directory or at least storm-star
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1808
@revans2 this is perfect. These 4 commits make it much easier to track
down. I confused the way GitHub truncates the messages - my bad.
+1
---
If your project is set up for it, you can reply t
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1868
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1868
This branch is also in sync with #1808 now tabs are removed and code is
squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
@hmcl github like to truncate long messages.
```
$ git log STORM-2225
commit c9f9348e3de0917020a8c903f4c9d026b7dc6204
Author: Robert (Bobby) Evans
Date: Tue Nov 29 21:39:26
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1808
Thanks @revans2. Can you please just amend the commit log
[messages](https://github.com/apache/storm/pull/1808/commits) as I believe they
do not really reflect the changes in this patch. One of the mess
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1808
Everyone,
Sorry this took so long. I kept getting pulled off on critical issues. I
have rebased/squashed everything (except the code revert) and also fixed the
issue with tabs vs spaces.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1899
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1893
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1895
Thanks @harshach for reviewing. I also created PR (#1903) for 1.x (and
possibly 1.0.x) branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1894
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1903
STORM-2323 (1.x) Precondition for Leader Nimbus should check all topology
blobs and also corresponding dependencies
* change the precondition for leader Nimbus
** it should have all active t
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1899
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/1902
STORM-2281: Running Multiple Kafka Spouts (Trident) Throws Illegal State
Exception
To review this PR please review only the commit that has STORM-2281. It is
currently sitting on top of the multiple c
38 matches
Mail list logo
