Github user kamleshbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/1949#discussion_r102148450
--- Diff: storm-core/test/jvm/org/apache/storm/LocalStateTest.java ---
@@ -0,0 +1,54 @@
+package org.apache.storm;
+
+import org.apache.storm
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1949
STORM-1290: port backtype.storm.local-state-test to java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm master
Alterna
Github user lukess commented on the issue:
https://github.com/apache/storm/pull/1935
Yes, because of 2343 I'm still using storm-kafka in production to
communicate with Kafka 0.10.1.1 (so I got 2361 issue too). After 2343 fixed I
have to verify KAFKA-4405 too before bump Kafka 0.10.2.0
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1945#discussion_r102143718
--- Diff: docs/Stream-API.md ---
@@ -0,0 +1,473 @@
+---
+title: Stream API Overview
+layout: documentation
+documentation: true
+---
+
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1945#discussion_r102143480
--- Diff: docs/Stream-API.md ---
@@ -0,0 +1,473 @@
+---
+title: Stream API Overview
+layout: documentation
+documentation: true
+---
+
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1945#discussion_r102142501
--- Diff: docs/Stream-API.md ---
@@ -0,0 +1,473 @@
+---
+title: Stream API Overview
+layout: documentation
+documentation: true
+---
+
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1945#discussion_r102142060
--- Diff: docs/Stream-API.md ---
@@ -0,0 +1,473 @@
+---
+title: Stream API Overview
+layout: documentation
+documentation: true
+---
+
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1935
2361 is for the older Kafka spout (storm-kafka instead of
storm-kafka-client), and 2343 is a bug in the spout code, not the Kafka client.
I agree that we should get this branch merged though :)
---
If
Github user kamleshbhatt closed the pull request at:
https://github.com/apache/storm/pull/1948
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user kamleshbhatt opened a pull request:
https://github.com/apache/storm/pull/1948
Update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamleshbhatt/storm master
Alternatively you can review and apply these changes as t
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR Squashed into one commit. Commit sha is
7cc1bdbea562a48aa09cc6dc7fd29edd5bd4eb10
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user lukess commented on the issue:
https://github.com/apache/storm/pull/1935
@srdo exactly! I'm testing the 0.10.1.1, and found some issues like
STORM-2361, STORM-2343, and KAFKA-4405... already. I think bump kafka client
version is very important for high level API.
---
If
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1945
Sure. :) Just would like to remind the bylaw for documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/1945
@HeartSaVioR better to wait for 1-2 days to give a chance for others to
review as this is not really urgent to push in short time to be part of some
release. :)
I will review this PR by today.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1947
+1 given that you've tested it manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1946
+1 given that you've tested it manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1945
+1 Nice explanation.
Since it's documentation you don't need to get +1 and even don't need to
wait for 24hr. Or we can wait for more eyes. It's up to you.
---
If your project is set up
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1939
+1
@pasalkarsachin1 Could you squash commits into one? Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1947
STORM-2326 Upgrade log4j and slf4j for branch 1.x
See #1946 for 1.0.x equivalent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DigitalPeb
GitHub user jnioche opened a pull request:
https://github.com/apache/storm/pull/1946
STORM-2326 Upgrade log4j and slf4j for branch 1.0.x
Compiled and packaged with
```
mvn clean install -DskipTests=true
cd storm-dist/binary && mvn package
```
Works fine
Github user jnioche commented on the issue:
https://github.com/apache/storm/pull/1900
FYI this is fixed in the following version of log4j, see
https://blogs.apache.org/logging/entry/log4j-2-8-released.
I will test with 2.8 and open a new PR
---
If your project is set up for it,
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1945
[STORM-2367] Documentation for streams API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-2367
Alternatively y
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1939
@HeartSaVioR I have updated code as per your comment :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
@HeartSaVioR
> For point 2 I suggest adding shortcut, not removing previous one.
Providing FQDN is not easiest way to do so we can make some implementations
taking precedence and su
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101994430
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void updateSta
Github user pasalkarsachin1 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101993619
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void updat
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101977581
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -75,20 +75,29 @@ public void prepare(Pr
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101973797
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void updateSta
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101976534
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -75,20 +75,29 @@ public void prepare(Pr
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101974017
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void updateSta
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101977245
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -75,20 +75,29 @@ public void prepare(Pr
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101976272
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void updateSta
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1939#discussion_r101978059
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -98,14 +107,19 @@ public void updateSta
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1942
@pasalkarsachin1
> For point 2, I have various implementations in mind to add to open source
one of them is implemented by megha10 for ZipTextFileReader another can be
anySepratorReader
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
> The current FileReader implementation is expected to have constructor
with a specific signature, which cannot be enforced at compile time. IMO, this
should also be fixed along with this pat
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1942
For points made by @HeartSaVioR
For point 2, I have various implementations in mind to add to open source
one of them is implemented by megha10 for ZipTextFileReader another can be
Sorry but personally I'd rather not look back to 0.x version lines. If
you're just getting started with development, please pick master branch
(for 2.0.0) or 1.x-branch (for 1.1.0).
Thanks,
Jungtaek Lim (HeartSaVioR)
2017년 2월 18일 (토) 오전 2:14, 昨夜渡轮上 <374277...@qq.com>님이 작성:
> Hello, I am tancheng
37 matches
Mail list logo
