Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2037
Hello,@HeartSaVioR
This is the new PR for STORM-2363,I made a change based on your
suggestion.Now, we can pass that value from caller of CommonStats, we avoid
reading storm config file again
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2037
[STORM-2363] Provide configuration to set the number of RollingWindow
[https://issues.apache.org/jira/browse/STORM-2363?filter=-2](url)
Users can set the number of RollingWindow which applied
Github user hmcl closed the pull request at:
https://github.com/apache/storm/pull/1831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2036
+1, nice catch.
Here's the master version, for reference
https://github.com/apache/storm/pull/1932.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
+1 it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
I filed STORM-2447 and STORM-2448 to allow for us to separate out the
classpath and make the change transparent for end users.
---
If your project is set up for it, you can reply to this email and h
GitHub user nicom opened a pull request:
https://github.com/apache/storm/pull/2036
[DEV-2440] Prevent KafkaSpout from hanging under certain Kafka failure
scenarios
Issue: https://issues.apache.org/jira/browse/STORM-2440
You can merge this pull request into a Git repository by runni
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
I am +1 for the general concept. I need to finish going through the code,
but I am probably going to do it outside of github because the patch is so
huge.
As a side note git used to use a
Github user cutd closed the pull request at:
https://github.com/apache/storm/pull/1807
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1950
@arunmahadevan
We could save
- cost of serde. on KV pair
- another serde. for String to byte[] while sending/receiving from/to Redis
- traffic/space of Redis since base64 converts
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1950
@HeartSaVioR what is the motivation for using binary instead of string type
? Is this mainly for performance ? I will review this sometime next week.
---
If your project is set up for it, you
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1970#discussion_r109123032
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueState.java
---
@@ -0,0 +1,399 @@
+/*
+ * Licensed to th
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1970
@arunmahadevan
OK I can change the implementation to store KV to each row. Will update the
patch and let you know.
---
If your project is set up for it, you can reply to this email and have
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1950
@arunmahadevan
Please take a look when you have some time. Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1970#discussion_r109118403
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/state/HBaseKeyValueState.java
---
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/1943
@HeartSaVioR
OK!I will try to find a more appropriate way.Thanks for your advice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2034
I googled about `git mv` and some SO article claims `git mv` is just a
shorthand of `delete and create`. Unfortunately there seems no way to reduce
the diff.
---
If your project is set up for i
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1943#discussion_r109111617
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2342,6 +2342,9 @@
@isPositiveNumber
public static String STORM_CGROUP_
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1943#discussion_r109112216
--- Diff: storm-core/src/jvm/org/apache/storm/stats/CommonStats.java ---
@@ -23,10 +23,11 @@
import org.apache.storm.metric.api.IMetric;
import
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1831
@hmcl
We applied opposite approach for this. Could you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/2024
Any comments are welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/storm/pull/2035
[STORM-2442]modify the Usage Examples in storm-kafka-client's README.md
[https://issues.apache.org/jira/browse/STORM-2442](url)
The Usage Example in storm-kafka-client's README.md is Incorrec
22 matches
Mail list logo
