Re: [DISCUSS] - Reconcile Multiple SECURITY.md Files in Master and 1.x-Branch

2017-04-03 Thread Jungtaek Lim
Yeah they're duplicated docs and we have lots of duplicated docs indeed. The issue is that someone would find the document from source directory, and others would find the document from website. IMHO they may need to be in both directories, but not ideal indeed, since I also saw that they're not

[DISCUSS] - Reconcile Multiple SECURITY.md Files in Master and 1.x-Branch

2017-04-03 Thread Hugo Da Cruz Louro
Hi, I noticed that we have two SECURITY.md files with different contents in both Master and 1.x-branch. Master https://github.com/apache/storm/blob/master/SECURITY.md https://github.com/apache/storm/blob/master/docs/SECURITY.md 1.x-branch

[GitHub] storm pull request #2038: STORM-2450: Write resources into correct local dir...

2017-04-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2038 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1924: STORM-2343: New Kafka spout can stop emitting tuples if m...

2017-04-03 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1924 @HeartSaVioR @hmcl Do you guys have time to take another look? (again, very sorry about the number of times I've declared this "done") --- If your project is set up for it, you can reply to this email

[GitHub] storm pull request #2041: STORM-2452: Storm Metric classes are not thread sa...

2017-04-03 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/2041 STORM-2452: Storm Metric classes are not thread safe Synchronizing metrics methods You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm issue #2038: STORM-2450: Write resources into correct local directory

2017-04-03 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2038 @HeartSaVioR it actually took me way too long beating my head against it thinking I broke the thing as part of trying to make local mode transparent. --- If your project is set up for it, you can

[GitHub] storm issue #2032: [STORM-2093] Fix permissions in multi-tenant, secure mode

2017-04-03 Thread ppoulosk
Github user ppoulosk commented on the issue: https://github.com/apache/storm/pull/2032 Thanks, @HeartSaVioR. Pushed fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request #2036: [STORM-2440] Prevent KafkaSpout from hanging under...

2017-04-03 Thread nicom
Github user nicom commented on a diff in the pull request: https://github.com/apache/storm/pull/2036#discussion_r109373858 --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj --- @@ -267,9 +267,11 @@ ((:report-error <>) error)

[GitHub] storm pull request #2036: [STORM-2440] Prevent KafkaSpout from hanging under...

2017-04-03 Thread nicom
GitHub user nicom reopened a pull request: https://github.com/apache/storm/pull/2036 [STORM-2440] Prevent KafkaSpout from hanging under certain Kafka failure scenarios Issue: https://issues.apache.org/jira/browse/STORM-2440 You can merge this pull request into a Git repository by

[GitHub] storm issue #2036: [STORM-2440] Prevent KafkaSpout from hanging under certai...

2017-04-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2036 @nicom #1932 just addressed it for master branch so this PR is still valid. Could you double check my review comment and reopen / address? --- If your project is set up for it, you can

[GitHub] storm issue #2036: [DEV-2440] Prevent KafkaSpout from hanging under certain ...

2017-04-03 Thread nicom
Github user nicom commented on the issue: https://github.com/apache/storm/pull/2036 I just found out that this is a duplicate of #1932 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #2036: [DEV-2440] Prevent KafkaSpout from hanging under c...

2017-04-03 Thread nicom
Github user nicom closed the pull request at: https://github.com/apache/storm/pull/2036 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2040: STORM-2451: windows storm.cmd does not set log4j2 config ...

2017-04-03 Thread alexlehm
Github user alexlehm commented on the issue: https://github.com/apache/storm/pull/2040 yes, i am using the modified start script now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #2039: fix md formatting for windows storm.local.dir exam...

2017-04-03 Thread alexlehm
Github user alexlehm commented on a diff in the pull request: https://github.com/apache/storm/pull/2039#discussion_r109349013 --- Diff: docs/Setting-up-a-Storm-cluster.md --- @@ -58,11 +58,12 @@ If the port that your Zookeeper cluster uses is different than the default, you