[GitHub] storm issue #2053: [STORM-2455] Expose the window start and end timestamp in...

2017-04-11 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/2053 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] storm pull request #2061: STORM-2469: fix integration-test dependencies issu...

2017-04-11 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/2061 STORM-2469: fix integration-test dependencies issue This is the hot fix for integration-test dependencies issue * add storm-server. since __the ExclamationTopology depends on LocalCluster__

RE: Apache Storm/JStorm Runner(s) for Apache Beam

2017-04-11 Thread 刘键(Basti Liu)
Hi Taylor, It is glad to see your opinion. After the open source of Beam, there are a lot of interests in Beam from our internal users in Alibaba and other companies in China, which promotes us to provide the support of JStorm runner. But since the implementation of Storm runner is out of date

Fwd: Distribution of workers across cluster with Resource Aware Scheduler

2017-04-11 Thread Pracheer Agarwal
-- Forwarded message -- From: Pracheer Agarwal Date: Tue, Apr 11, 2017 at 9:07 AM Subject: Distribution of workers across cluster with Resource Aware Scheduler To: u...@storm.apache.org Hi All, We are in the process of migrating to storm version 1.0.3. The pattern that we observ

[GitHub] storm issue #2058: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...

2017-04-11 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2058 @vesense Yes,you are right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #2058: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...

2017-04-11 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/2058 I guess the change is a copy from http://storm.apache.org/releases/1.1.0/SECURITY.html "Storm Kerberos Configuration" section. Overall looks good to me. --- If your project is set up for it, yo

[GitHub] storm issue #2057: [STORM-2465] modify storm-redis's READEME.md and update s...

2017-04-11 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2057 Hi, @vesense how are you? I am sorry to bother you again.Would you help me to merge it?Thanks for your help these days. --- If your project is set up for it, you can reply to this email and

[GitHub] storm issue #2056: [STORM-2464] update storm-mongodb.md

2017-04-11 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2056 Hi, @vesense how are you? I am sorry to bother you again.Would you help me to merge it?Thanks for your help these days. --- If your project is set up for it, you can reply to this email and

[GitHub] storm issue #2056: [STORM-2464] update storm-mongodb.md

2017-04-11 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/2056 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2057: [STORM-2465] modify storm-redis's READEME.md and update s...

2017-04-11 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/2057 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2059: STORM-2463: fix DRPCTest.testDequeueAfterTimeout test fai...

2017-04-11 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/2059 @revans2 100ms dosen't work, but 1s works well. 500ms sometimes still get failure. I changed the value to 1s. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] storm issue #2053: [STORM-2455] Expose the window start and end timestamp in...

2017-04-11 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2053 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2026: STORM-2371: Replace existing AMQP eventhub client with th...

2017-04-11 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2026 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #2054: STORM-2462 Adding regex mapper to KerberosPrincipa...

2017-04-11 Thread ambud
Github user ambud commented on a diff in the pull request: https://github.com/apache/storm/pull/2054#discussion_r110977694 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java --- @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2054: STORM-2462 Adding regex mapper to KerberosPrincipa...

2017-04-11 Thread ambud
Github user ambud commented on a diff in the pull request: https://github.com/apache/storm/pull/2054#discussion_r110976923 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java --- @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #2028: Fix headers

2017-04-11 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2028 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-11 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2060 Only the last commit is the one to look at. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request #2060: STORM-2468: Remove clojure from storm-client

2017-04-11 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2060 STORM-2468: Remove clojure from storm-client This is based off STORM-2447 You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm

[GitHub] storm issue #2032: [STORM-2093] Fix permissions in multi-tenant, secure mode

2017-04-11 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2032 @ppoulosk Sadly with the latest refactoring of the code `SupervisorUtils.processLauncherAndWait` is not on the classpath for storm-core any more. It is a part of storm-server. You may need to do so

[GitHub] storm issue #2032: [STORM-2093] Fix permissions in multi-tenant, secure mode

2017-04-11 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2032 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #2054: STORM-2462 Adding regex mapper to KerberosPrincipa...

2017-04-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2054#discussion_r110968429 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java --- @@ -0,0 +1,56 @@ +/** + * Licensed to the Apach

[GitHub] storm pull request #2054: STORM-2462 Adding regex mapper to KerberosPrincipa...

2017-04-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2054#discussion_r110968735 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java --- @@ -0,0 +1,56 @@ +/** + * Licensed to the Apach

[GitHub] storm pull request #2054: STORM-2462 Adding regex mapper to KerberosPrincipa...

2017-04-11 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2054#discussion_r110967560 --- Diff: storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java --- @@ -0,0 +1,56 @@ +/** + * Licensed to the Apach

[GitHub] storm issue #2029: STORM-2379: update for Elasticsearch 2.

2017-04-11 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2029 Thanks @hmcc. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm issue #2047: STORM-2447: add in storm local to avoid having server on ...

2017-04-11 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2047 @HeartSaVioR could you please take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] storm issue #2056: [STORM-2464] update storm-mongodb.md

2017-04-11 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2056 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2055: [STORM-2467] Use explicit charset when decoding from arra...

2017-04-11 Thread marcust
Github user marcust commented on the issue: https://github.com/apache/storm/pull/2055 @srdo Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2055: Use explicit charset when decoding from array backed buff...

2017-04-11 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2055 Nice find. The change LGTM. You should create an issue for this at https://issues.apache.org/jira/browse/STORM so the bugfix gets tracked. Then rename this PR and the commit message to include the issue

Re: Apache Storm/JStorm Runner(s) for Apache Beam

2017-04-11 Thread Kenneth Knowles
Hi Taylor, Thanks immensely for taking the time to write such rich detail. I have a lot to learn about the relationship between Storm and JStorm as software and as communities. Your final note I can immediately agree with and reinforce. The fruits of this endeavor should reside in the Beam reposi

Re: Apache Storm/JStorm Runner(s) for Apache Beam

2017-04-11 Thread Pei HE
Hi Taylor, I am very glad to see the interests in pushing forward Beam Storm runner. However, I cannot convince myself the benefits of having one runner to support all. Beam have three types of users: pipeline writers, library writers, and runner implementers. I can see pros vs cons as following

[GitHub] storm pull request #2059: STORM-2463: fix DRPCTest.testDequeueAfterTimeout t...

2017-04-11 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/2059 STORM-2463: fix DRPCTest.testDequeueAfterTimeout test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-2463 Alternat

[GitHub] storm pull request #2058: [STORM-2466] The example of jaas.conf in jaas_kerb...

2017-04-11 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2058 [STORM-2466] The example of jaas.conf in jaas_kerberos.conf should give more details [https://issues.apache.org/jira/browse/STORM-2466](url) This documentation lacks several section such as

[GitHub] storm pull request #2057: [STORM-2465] modify storm-redis's READEME.md and u...

2017-04-11 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2057 [STORM-2465] modify storm-redis's READEME.md and update storm-redis.md [https://issues.apache.org/jira/browse/STORM-2465](url) There is a lack of "$" in the module of storm-redis's READEME.md

[GitHub] storm pull request #2056: [STORM-2464] update storm-mongodb.md

2017-04-11 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2056 [STORM-2464] update storm-mongodb.md [https://issues.apache.org/jira/browse/STORM-2464](url) storm-mongodb.md is out of date.For example,there is a new method in MongoMapper,but there isn't

[GitHub] storm pull request #2046: STORM-2458: Kafka Spout should allow hooking up cu...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2046 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2048: [STORM-2461] modify storm-hdfs's READEME.md and up...

2017-04-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2055: Use explicit charset when decoding from array back...

2017-04-11 Thread marcust
GitHub user marcust opened a pull request: https://github.com/apache/storm/pull/2055 Use explicit charset when decoding from array backed buffer We had the case that this broke encoding for us because it used the default system locale. Given the fact that this code uses an explic

[GitHub] storm pull request #2053: [STORM-2455] Expose the window start and end times...

2017-04-11 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2053#discussion_r110835582 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/Window.java --- @@ -47,9 +47,17 @@ List getExpired(); /** - *

[GitHub] storm pull request #2053: [STORM-2455] Expose the window start and end times...

2017-04-11 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2053#discussion_r110830274 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/Window.java --- @@ -47,9 +47,17 @@ List getExpired(); /** - * If pro