[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build

2017-04-27 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/storm/pull/2093 Due to new checkstyle warnings, size of build log file exceeded 4mb limit. Error from build "The log length has exceeded the limit of 4 MB (this usually means that the test suite is rai

[GitHub] storm pull request #2093: STORM-2495:Integrate checkstyle check during build

2017-04-27 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/storm/pull/2093 STORM-2495:Integrate checkstyle check during build Integrated checkstyle in maven validate phase.Added google java style check You can merge this pull request into a Git repository by running:

[GitHub] storm pull request #2083: STORM-2421: support lists of childopts in DaemonCo...

2017-04-27 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2083#discussion_r113841362 --- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java --- @@ -313,6 +315,34 @@ public static File getWorkerDirFromRoot(String logRoot, Strin

[GitHub] storm pull request #2088: [STORM-2486] Prevent cd from printing target direc...

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2049: STORM-2448: Add in Storm and JDK versions when submitting...

2017-04-27 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2049 @ptgoetz @HeartSaVioR ping again. This should give us the ability to do a rolling upgrade from 1.x to 2.x --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [VOTE] Java Code Style Standard for Apache Storm.

2017-04-27 Thread Satish Duggana
[1] Google Java Style Guide [2] Hadoop style which is described as java but with 2 spaces instead of 4. [3] Sun Java Code Conventions

[GitHub] storm pull request #2060: STORM-2468: Remove clojure from storm-client

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2086: STORM-2491: Adding extra Cassandra configuration paramete...

2017-04-27 Thread tandrup
Github user tandrup commented on the issue: https://github.com/apache/storm/pull/2086 @harshach I've added the new configs to the existing README list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Need Help

2017-04-27 Thread Kamal Bhatt
Hello, I am a developer interested to work on Storm tasks based on Java Streaming API and/or supporting storm as a runtime for apache beam. I have some experience working in Storm project like translating clojure tests to java and Admin Command. Could someone from the group working on these t

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-27 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2060 +1 Sorry for the delayed review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-27 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2060 Missed the previous request. This all looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

Re: [VOTE] Java Code Style Standard for Apache Storm.

2017-04-27 Thread Kyle Nusbaum
[1] Google Java Style Guide [2] Sun Java Code Conventions [3] HBase style (sorry all I cou

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-27 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2060 @HeartSaVioR @ptgoetz If you have time to take a look I would appreciate it. It looks like @knusbaum might be a bit too busy to take a look in a timely manor. --- If your project is set up for it,

[GitHub] storm pull request #2091: fix typo in storm-client pom file: kyro -> kryo

2017-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2091 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2081: [STORM-2482] Refactor the Storm auto credential pl...

2017-04-27 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2081#discussion_r113686981 --- Diff: docs/storm-hbase.md --- @@ -56,22 +56,43 @@ The approach described above requires that all potential worker hosts have "stor multiple to

[GitHub] storm pull request #2081: [STORM-2482] Refactor the Storm auto credential pl...

2017-04-27 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2081#discussion_r113686513 --- Diff: docs/SECURITY.md --- @@ -423,16 +423,18 @@ nimbus.impersonation.acl: ### Automatic Credentials Push and Renewal Individual top

[GitHub] storm pull request #2081: [STORM-2482] Refactor the Storm auto credential pl...

2017-04-27 Thread omkreddy
Github user omkreddy commented on a diff in the pull request: https://github.com/apache/storm/pull/2081#discussion_r113670700 --- Diff: external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractAutoCreds.java --- @@ -0,0 +1,250 @@ +/** + * Licensed to the Apac

[GitHub] storm pull request #2081: [STORM-2482] Refactor the Storm auto credential pl...

2017-04-27 Thread omkreddy
Github user omkreddy commented on a diff in the pull request: https://github.com/apache/storm/pull/2081#discussion_r113671063 --- Diff: external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractAutoCreds.java --- @@ -0,0 +1,250 @@ +/** + * Licensed to the Apac

[GitHub] storm pull request #2081: [STORM-2482] Refactor the Storm auto credential pl...

2017-04-27 Thread omkreddy
Github user omkreddy commented on a diff in the pull request: https://github.com/apache/storm/pull/2081#discussion_r113670746 --- Diff: external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractAutoCreds.java --- @@ -0,0 +1,250 @@ +/** + * Licensed to the Apac

Re: [VOTE] Java Code Style Standard for Apache Storm.

2017-04-27 Thread Julien Nioche
Non-binding : [1 ] Google Java Style Guide On 26 April 2017 at 19:50, Bobby Evans wrote: > We would like to adopt a code style standard for Apache Storm. Please > rank the following with 1 being the most desired and 4 being the least > desired (5 if you have a write in choice). This is not an