[GitHub] storm pull request #2099: STORM-2482: [WIP] Auto populate Hive Credentials

2017-05-04 Thread omkreddy
GitHub user omkreddy opened a pull request: https://github.com/apache/storm/pull/2099 STORM-2482: [WIP] Auto populate Hive Credentials You can merge this pull request into a Git repository by running: $ git pull https://github.com/omkreddy/storm AutoHiveNewBranch Alternative

Re: [VOTE] Java Code Style Standard for Apache Storm.

2017-05-04 Thread Bobby Evans
Thanks to everyone that voted. Of the 10 people that voted 8 voted for google as their first choice.  1 voted for Hadoop and 1 voted for a modified form of Google. With that I think google wins.  I will start by merging in the checkstyle pull request for google https://github.com/apache/storm/pu

[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build

2017-05-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2093 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] storm pull request #2093: STORM-2495:Integrate checkstyle check during build

2017-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2093 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2097: [STORM-2482] Refactor the Storm auto credential plugins t...

2017-05-04 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2097 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #2098: STORM-2499: Add Serialization plugin for EventHub ...

2017-05-04 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/2098#discussion_r114821502 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/BinaryEventDataSystemPropertiesScheme.java --- @@ -0,0 +1,51 @@

[GitHub] storm pull request #2098: STORM-2499: Add Serialization plugin for EventHub ...

2017-05-04 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/2098#discussion_r114825627 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/BinaryEventDataSystemPropertiesScheme.java --- @@ -0,0 +1,51 @@

[GitHub] storm pull request #2098: STORM-2499: Add Serialization plugin for EventHub ...

2017-05-04 Thread SreeramGarlapati
Github user SreeramGarlapati commented on a diff in the pull request: https://github.com/apache/storm/pull/2098#discussion_r114826039 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/FieldConstants.java --- @@ -23,5 +23,6 @@ public static fi

[GitHub] storm issue #1044: STORM-1464: Support multiple file outputs

2017-05-04 Thread ryanpersaud
Github user ryanpersaud commented on the issue: https://github.com/apache/storm/pull/1044 Now you've piqued my curiosity - what is it that you don't like about rotation actions? Writers are only stored in the writers map, so once they are removed, there is no way for FSDataOu

[GitHub] storm issue #2096: [STORM-2498] Fix Download Full File link in 1.x branch

2017-05-04 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2096 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2078: Add support for configuring memory load and cpu load in F...

2017-05-04 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2078 This looks good to me, but I'm pretty sure we've frozen features on 1.0.x-branch. It would be better to put it on 1.x-branch, and needs to go into master for 2.x as well. --- If your project is se

[GitHub] storm pull request #2098: STORM-2499: Add Serialization plugin for EventHub ...

2017-05-04 Thread rban1
Github user rban1 commented on a diff in the pull request: https://github.com/apache/storm/pull/2098#discussion_r114857534 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/BinaryEventDataSystemPropertiesScheme.java --- @@ -0,0 +1,51 @@ +package

[GitHub] storm pull request #2098: STORM-2499: Add Serialization plugin for EventHub ...

2017-05-04 Thread rban1
Github user rban1 commented on a diff in the pull request: https://github.com/apache/storm/pull/2098#discussion_r114857665 --- Diff: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/FieldConstants.java --- @@ -23,5 +23,6 @@ public static final String

[GitHub] storm pull request #2100: STORM-2503: Fix lgtm.com alerts on equality and co...

2017-05-04 Thread adityasharad
GitHub user adityasharad opened a pull request: https://github.com/apache/storm/pull/2100 STORM-2503: Fix lgtm.com alerts on equality and comparison operations. This PR addresses STORM-2503, by fixing a number of alerts found by lgtm.com at https://lgtm.com/projects/g/apache/storm/a

[GitHub] storm pull request #2094: [STORM-2191] shorten classpaths by using wildcards

2017-05-04 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/2094#discussion_r114897599 --- Diff: docs/Setting-up-a-Storm-cluster.md --- @@ -102,9 +102,9 @@ The time to allow any given healthcheck script to run before it is marked failed sto

[GitHub] storm pull request #2094: [STORM-2191] shorten classpaths by using wildcards

2017-05-04 Thread erikdw
Github user erikdw commented on a diff in the pull request: https://github.com/apache/storm/pull/2094#discussion_r114898011 --- Diff: docs/Setting-up-a-Storm-cluster.md --- @@ -102,9 +102,9 @@ The time to allow any given healthcheck script to run before it is marked failed sto