[GitHub] storm pull request #2092: STORM-2493: update documents to reflect the change...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2092 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2049: STORM-2448: Add in Storm and JDK versions when submitting...

2017-05-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2049 @kishorvpatil @knusbaum Could you two take a look at this and also the patches for 1.x etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #2072: STORM-2477: Add generics to Config types

2017-05-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2072 @ptgoetz @HeartSaVioR if either of you could take a look at this I would appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm issue #2100: STORM-2503: Fix lgtm.com alerts on equality and compariso...

2017-05-15 Thread adityasharad
Github user adityasharad commented on the issue: https://github.com/apache/storm/pull/2100 Thank you both! @harshach - I have squashed my commits into one as requested. @revans2 - I have merged your PR into this branch, so the commit is now included to resolve the test failure.

[GitHub] storm pull request #2109: STORM-2506: Print mapping between Task ID and Kafk...

2017-05-15 Thread srishtyagrawal
Github user srishtyagrawal commented on a diff in the pull request: https://github.com/apache/storm/pull/2109#discussion_r116602280 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -139,8 +139,8 @@ public void onPartitionsRev

[GitHub] storm pull request #2074: Storm 1290:port backtype.storm.local-state-test to...

2017-05-15 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2074#discussion_r116600864 --- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java --- @@ -0,0 +1,61 @@ +package org.apache.storm; + +import org.apache.co

[GitHub] storm pull request #2074: Storm 1290:port backtype.storm.local-state-test to...

2017-05-15 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2074#discussion_r116601117 --- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java --- @@ -0,0 +1,61 @@ +package org.apache.storm; + +import org.apache.co

[GitHub] storm issue #2100: STORM-2503: Fix lgtm.com alerts on equality and compariso...

2017-05-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2100 @adityasharad I put up https://github.com/adityasharad/storm/pull/1 to your repo that should fix the failing test. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] storm issue #2100: STORM-2503: Fix lgtm.com alerts on equality and compariso...

2017-05-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2100 @adityasharad so the test itself was testing for the wrong behavior, and when you fixed it the test stated to fail. I will try to make a pull request to your repo with a fix for the test. P

[GitHub] storm issue #2117: STORM-2515: Fix most checkstyle violations in storm-kafka...

2017-05-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2117 If someone wants to take a stab at writing the last bit of javadoc, and renaming the methods in KafkaSpoutConfig is fine, we could get rid of the last few warnings. --- If your project is set up for i

[GitHub] storm pull request #2117: STORM-2515: Fix most checkstyle violations in stor...

2017-05-15 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2117 STORM-2515: Fix most checkstyle violations in storm-kafka-client Most of the remaining violations are a couple of methods missing javadocs in the Trident code, which I don't feel familiar enough with T

[GitHub] storm issue #2100: STORM-2503: Fix lgtm.com alerts on equality and compariso...

2017-05-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2100 @adityasharad Some of the tests are failing now specifically TestDefaultResourceAwareStrategy. I'll try and spend some time looking into it to see if I can see why it is failing, because the

[GitHub] storm issue #2111: Fix minor typos in storm-hdfs and storm-hbase docs that s...

2017-05-15 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2111 Thanks, @arunmahadevan I merged this in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] storm pull request #2111: Fix minor typos in storm-hdfs and storm-hbase docs...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2114: STORM-2511: Submitting a topology with name contai...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2114 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2103: (1.x) STORM-2496 Dependency artifacts should be up...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2102: STORM-2496 Dependency artifacts should be uploaded...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2112: [STORM-2510] update checkstyle configuration to lo...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2099: STORM-2501: Auto populate Hive Credentials

2017-05-15 Thread omkreddy
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/2099 @HeartSaVioR @harshach @arunmahadevan Pl review the PR. AutoHive Code contacts with Hive MetaStore to create the tokens. These tokens will be passed to workers. Since Hive depends on HDF

Re: Confusing documentation for Trident State Management

2017-05-15 Thread Bobby Evans
First of all I am not an expert on trident.  I understand it at a high level, but I have not done too much with the internals of it.  And yes we are all in agreement that the documentation for trident is quite bad.  It was something that Nathan finished just before he left Twitter so a lot of th

[GitHub] storm issue #2112: [STORM-2510] update checkstyle configuration to lower vio...

2017-05-15 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2112 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: NullPointerException seen in 1.1.0

2017-05-15 Thread Bobby Evans
Yes retry would be the most logical way to work around this.  The code is kind of odd in that there are two separate locations in ZK for this information.  Leader election simply stores who the leader is at `/leader-lock`, but the information about all of the nimbus instances that are alive is s