[GitHub] storm issue #2169: [STORM-2563] Remove the workaround to handle missing UGI....

2017-06-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2169 +1 We've been setting `hadoop.version` as 2.6.1 for a long period so if it's an workaround for lower version, we could remove it. But it would be better to wait for @revans2 to review this as

[GitHub] storm issue #2163: STORM-2553: Add support for password in JedisCluster

2017-06-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2163 @vyan Please squash commits into one after addressing my comment. Thanks in advance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] storm pull request #2163: STORM-2553: Add support for password in JedisClust...

2017-06-20 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2163#discussion_r123164663 --- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/config/JedisClusterConfig.java --- @@ -45,6 +45,26 @@ * @param node

[GitHub] storm pull request #2170: [STORM-2564] We should provide a template for stor...

2017-06-20 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2170 [STORM-2564] We should provide a template for storm-cluster-auth.yaml [https://issues.apache.org/jira/browse/STORM-2564](https://issues.apache.org/jira/browse/STORM-2564) As the configuratio

[GitHub] storm pull request #2169: [STORM-2563] Remove the workaround to handle missi...

2017-06-20 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/2169 [STORM-2563] Remove the workaround to handle missing UGI.loginUserFromSubject https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/security/auth/kerberos/Aut

[GitHub] storm issue #2168: STORM-2562: Use stronger key size than default for blow f...

2017-06-20 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2168 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] storm issue #2167: STORM-2562: Use stronger key size than default for blow f...

2017-06-20 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2167 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: Use of the KafkaConsumer.subscribe API in the storm-kafka-client spout

2017-06-20 Thread Kristopher Kane
>From the perspective of a user who wraps a config driven product around Storm, the setup of the KafkaSpout, and its configuration, has been a moving target that is hard to track. In addition, the lack of supporting usage examples across the README vs examples/ has also made it difficult. My opini

[GitHub] storm issue #2109: STORM-2506: Print mapping between Task ID and Kafka Parti...

2017-06-20 Thread srishtyagrawal
Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2109 @HeartSaVioR thanks for the approval. I have rebased the changes on top of the latest master branch. Can you please merge this PR? --- If your project is set up for it, you can reply to this

[GitHub] storm pull request #2168: STORM-2562: Use stronger key size than default for...

2017-06-20 Thread priyank5485
GitHub user priyank5485 opened a pull request: https://github.com/apache/storm/pull/2168 STORM-2562: Use stronger key size than default for blow fish key gene… …rator and get rid of stack trace You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] storm pull request #2167: STORM-2562: Use stronger key size than default for...

2017-06-20 Thread priyank5485
GitHub user priyank5485 opened a pull request: https://github.com/apache/storm/pull/2167 STORM-2562: Use stronger key size than default for blow fish key gene… …rator and get rid of stack trace You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] storm pull request #2164: [STORM-2557]: A bug in DisruptorQueue causing seve...

2017-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request #2162: STORM-2449 Ensure same key appears only once in St...

2017-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2164: [STORM-2557]: A bug in DisruptorQueue causing severe unde...

2017-06-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2164 OK. +1 from me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o