Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2171
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2171
@arunmahadevan
Thanks for reviewing. I addressed your review comment.
Could you please take a look again? Thanks!
---
If your project is set up for it, you can reply to this email and h
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2160
Also addressed review comments from 1.x branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2171#discussion_r123429439
--- Diff:
external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java
---
@@ -67,7 +67,7 @@ public static UserProvider
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2171#discussion_r123425272
--- Diff:
external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java
---
@@ -67,7 +67,7 @@ public static UserProvider
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2171#discussion_r123424946
--- Diff:
external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java
---
@@ -67,7 +67,7 @@ public static UserProvid
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2160
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2160
master and 1.x-branch are diverged due to STORM-2556.
Just raised PR for 1.x-branch (#2171) and will rebase the PR.
---
If your project is set up for it, you can reply to this email and have
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2171
(1.x) STORM-2555 handle impersonation properly for HBase delegation token
Please refer [STORM-2555](http://issues.apache.org/jira/browse/STORM-2555)
for more details.
There had been cod
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2032
@ppoulosk @revans2
Ah I missed that processLauncherAndWait is moved to ClientSupervisorUtils,
which resides on storm-client. Since storm-server depends on storm-client,
changing SupervisorUt
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2032
storm-core depends on storm-server, so that would be fine for now. We may
want to address this when we move logviewer into webservice.
---
If your project is set up for it, you can reply to this
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2163
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user vyan commented on the issue:
https://github.com/apache/storm/pull/2163
@HeartSaVioR, thanks for your comments. I have squashed all commits into
one now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2170
@vesense
Could you help me review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2109
@erikdw Nice! Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@HeartSaVioR : I'll try to take a stab later tonight at it. I'll let you
know if I find time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2109
I'll try to resolve the conflict on top of this patch when I have free
time. If someone volunteers and raise a new PR it would be great.
---
If your project is set up for it, you can reply to th
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2109
Not sure, but we may need to have bug fix version soon since there're some
opened pull requests on storm-kafka-client which sound like critical.
---
If your project is set up for it, you can rep
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2149
@adityasharad @revans2
I'm not quite sure why it occurs, but build fails in Travis CI (seemed like
other issues) and also my local.
```
TestDefaultResourceAwareStrategy.testDefa
Github user erikdw commented on the issue:
https://github.com/apache/storm/pull/2109
@HeartSaVioR : thanks a lot! @srishtyagrawal is on leave for a month. Are
there any 1.x releases planned before late July?
---
If your project is set up for it, you can reply to this email and have
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2109
@srishtyagrawal
I merged this to master branch, but seems like there're some conflicts
against 1.x branch. If you want to adopt this to 1.x version line, you may need
to raise a new PR again
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2139
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2159
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2161
@revans2 OK. Got it. Thanks for reviewing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2159
+1. LGTM. As @srdo mentioned earlier, I wish there was a backwards
compatible way to enforce messageId to be serializable. The documentation is
nice and clear, but the same way it happened in here, I do
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2159#discussion_r123357809
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutMessageId.java
---
@@ -21,7 +21,9 @@
import org.apache.kafka.cl
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2169
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user priyank5485 commented on the issue:
https://github.com/apache/storm/pull/2155
+1(NB) given that people prefer keeping the Builder class around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Hi Kris,
I'm sorry the new spout has been so unstable. We should probably have
marked it as an alpha/beta release, instead of just following the Storm
version number.
I agree that we should try to avoid duplicating the Kafka config, and
there's a PR for that here https://github.com/apache/storm/p
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2161
@HeartSaVioR I don't think more generalization is a benefit. My comment
was mostly around making it hadoop specific or truly making it generic.
---
If your project is set up for it, you can reply t
Github user askprasanna commented on the issue:
https://github.com/apache/storm/pull/2159
Makes sense. Will update this PR with the change to make the members
non-transient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2159
I wouldn't mind just squeezing that change into this PR honestly. It's
still related to making the message id serializable, and it's such a tiny
change that it feels like overkill to spin off. Either wa
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2161
@revans2
I renamed abstract classes to have 'Hadoop' on their name.
Btw I don't see other cases to not using Hadoop, hence not sure that
generalization provides some benefits for now. If
Github user askprasanna commented on the issue:
https://github.com/apache/storm/pull/2159
@HeartSaVioR Done.
LMK if you would like another PR for making the members in
KafkaSpoutMessageId non-transient.
---
If your project is set up for it, you can reply to this email and h
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2159
While it will fix runtime issue, since fields are transient, it doesn't
give any values. I think it's still better than getting runtime error, but we
should remove transient if it's not necessary
43 matches
Mail list logo
