[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 Test is failing with RAT issue. ``` [WARNING] Files with unapproved licenses: storm-webapp/src/test/resources/test-3072.log.test storm-webapp/src/test/resources/small-worke

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 Removed WIP though I still need to address checkstyle issues. I think check style violation doesn't hurt review process. --- If your project is set up for it, you can reply to this email and hav

[GitHub] storm issue #2204: (WIP) STORM-1280 port backtype.storm.daemon.logviewer to ...

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 Also fixed the tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2209 @Ethanlm Could you share the screenshot of the changed page? That helps to see the benefit of the patch easily. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] storm pull request #2209: [STORM-2622] Add owner resource summary on storm U...

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2209#discussion_r127377733 --- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java --- @@ -1095,6 +1096,12 @@ public TopologyHistoryInfo getTopologyHistory(String u

[GitHub] storm pull request #2205: Quick Fix: fix storm-cassandra to not exceed curre...

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2205: Quick Fix: fix storm-cassandra to not exceed current max ...

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2205 Since this patch just adds lines and builds against master are all failing, I'd rather just merge this. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] storm issue #2204: (WIP) STORM-1280 port backtype.storm.daemon.logviewer to ...

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 Applied recent change of logviewer and rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #2209: [STORM-2622] Add owner resource summary on storm U...

2017-07-13 Thread Ethanlm
GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2209 [STORM-2622] Add owner resource summary on storm UI At Yahoo, we have a "Owner Summary" section in Storm UI to display the resources a user is using and guaranteed. This work is done by @abellina. I

[GitHub] storm issue #2204: (WIP) STORM-1280 port backtype.storm.daemon.logviewer to ...

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 UPDATE: I also ported logviewer-test.clj to Java. Some tests are failing and I'm looking into it. I still need to apply recent change of logviewer: https://github.com/apache/storm/co

[GitHub] storm issue #2206: STORM-2625: reduce uncommitted count when kafka consumer ...

2017-07-13 Thread WolfeeTJ
Github user WolfeeTJ commented on the issue: https://github.com/apache/storm/pull/2206 @srdo I agree it would be a better solution to maintain uncommitted as per partition basis, it would be much clearer to debug. Thank you very much and looking forward to merging in master or branch

[GitHub] storm issue #2206: STORM-2625: reduce uncommitted count when kafka consumer ...

2017-07-13 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2206 The build error is unrelated to this change, I think the cherry pick of https://github.com/apache/storm/pull/2195/files to 1.1.x-branch broke it. @HeartSaVioR if you get the chance could you take a look

[GitHub] storm pull request #2208: [STORM-2627] The annotation of storm.zookeeper.top...

2017-07-13 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2208 [STORM-2627] The annotation of storm.zookeeper.topology.auth.scheme in Config.java is wrong [https://issues.apache.org/jira/browse/STORM-2627](https://issues.apache.org/jira/browse/STORM-2627)

[GitHub] storm issue #2206: STORM-2625: reduce uncommitted count when kafka consumer ...

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2206 Forgot to mention: Thanks for the contribution. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] storm issue #2206: STORM-2625: reduce uncommitted count when kafka consumer ...

2017-07-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2206 @WolfeeTJ Please craft a pull request against master branch unless the patch is only valid for specific branch(es). --- If your project is set up for it, you can reply to this email and hav

[GitHub] storm pull request #2207: [STORM-2626] Provided a template for drpc-auth-acl...

2017-07-13 Thread liu-zhaokun
GitHub user liu-zhaokun opened a pull request: https://github.com/apache/storm/pull/2207 [STORM-2626] Provided a template for drpc-auth-acl.yaml [https://issues.apache.org/jira/browse/STORM-2626](https://issues.apache.org/jira/browse/STORM-2626) The default value of drpc.au

[GitHub] storm issue #2206: STORM-2625: reduce uncommitted count when kafka consumer ...

2017-07-13 Thread WolfeeTJ
Github user WolfeeTJ commented on the issue: https://github.com/apache/storm/pull/2206 @srdo please help to review. I tested locally it should be working. However during Travis CI build another irrelevant test case failed, I think we could safely ignore it. Please check. Thanks.