[GitHub] storm pull request #2204: STORM-1280 port backtype.storm.daemon.logviewer to...

2017-07-16 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2204#discussion_r127633153 --- Diff: storm-buildtools/storm_checkstyle.xml --- @@ -46,6 +46,9 @@ --> + --- End diff -- I just add allowing

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-16 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 Addressed RAT and checkstyle violation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #2209: [STORM-2622] Add owner resource summary on storm UI

2017-07-16 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/2209 Looks great. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

2017-07-16 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 @vesense I am so sorry to bother you.Do you have time to help me review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] storm issue #2207: [STORM-2626] Provided a template for drpc-auth-acl.yaml

2017-07-16 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2207 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #2208: [STORM-2627] The annotation of storm.zookeeper.topology.a...

2017-07-16 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2208 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-07-16 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 Just FYI: Facebook just removed PATENT file from RocksDB and make RocksDB be dual licenses (GPLv2 and Apache).

[GitHub] storm pull request #2216: Update storm.py to be python3 compatible

2017-07-16 Thread rukaya
GitHub user rukaya opened a pull request: https://github.com/apache/storm/pull/2216 Update storm.py to be python3 compatible Function `emitBolt()` emits a `map`, which is not json serializeble in python3. It should be changed to return a `list` in order to be json serializeble.

[GitHub] storm pull request #2214: STORM-2634: Apply new code style to storm-sql-runt...

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2213: STORM-2633: Apply new code style to storm-sql-redi...

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2212: STORM-2632: Apply new code style to storm-sql-kafk...

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2211: STORM-2631: Apply new code style to storm-sql-mong...

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2210: STORM-2630: Apply new code style to storm-sql-hdfs

2017-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is