Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2241
**Thread Safety and Bolt/Spout Emits:** @HeartSaVioR & @satishd brought up
this topic that is worth discussing in the interest of communicating clearly to
users.
The basic issue is ...
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2241
**FYI:** After rebasing to the latest master I see a drop in peak
throughput from the original ~8.1mill/sec to ~7.2mill/sec. Lots of changes
have come in since the original version of the master
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2218
Thanks for the reviews, squashed and merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2263
+1 again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2263
@HeartSaVioR Thank you.
I rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2181
@tiodollar Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2263
+1
Could you rebase into current master? I recommend you to create a new
branch for each pull request.
---
If your project is set up for it, you can reply to this email and have your
re
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2218
@arunmahadevan
+1 Nice work.
Could you squash the commits into one? You can merge it by yourself, or
please mention me if you want me to merge.
---
If your project is set up for it, you
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2262#discussion_r131789023
--- Diff: storm-client/src/jvm/org/apache/storm/security/auth/AutoSSL.java
---
@@ -133,8 +134,9 @@ public static void deserializeSSLFile(String credsKey,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2262#discussion_r131787411
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -56,25 +56,26 @@ public void executeInsertQuery(String q
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2262#discussion_r131787582
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -106,50 +107,52 @@ public String apply(Column input) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2262#discussion_r131788092
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -179,8 +182,9 @@ public void executeSql(String sql) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2262#discussion_r131788989
--- Diff: storm-client/src/jvm/org/apache/storm/security/auth/AutoSSL.java
---
@@ -100,19 +100,20 @@ public void populateCredentials(Map
credentials) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2262#discussion_r131788473
--- Diff:
flux/flux-core/src/main/java/org/apache/storm/flux/parser/FluxParser.java ---
@@ -96,11 +96,12 @@ private static TopologyDef loadYaml(Yaml yaml
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2262#discussion_r131787609
--- Diff:
external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java
---
@@ -106,50 +107,52 @@ public String apply(Column input) {
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2265
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2267
STORM-2682: Fix issues with null owner on rolling upgrade (1.0.x)
This is the 1.0.x version of #2266 and should probably apply cleanly to
all of the 1.x line of releases.
This prevents doi
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2266
STORM-2682: Fixed issues with null owner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2682
Alternatively you c
Github user roshannaik commented on the pull request:
https://github.com/apache/storm/commit/96ad079354eba2c68a4e9854e14c584043e49e36#commitcomment-23523208
@Ethanlm @revans2 Is it OK to disable this for SystemBolt ? As far as I
can tell, SystemBolt doesn't appear to invoke reportErr
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2262
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131659700
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -380,6 +383,22 @@
return partitionBy(KEY).updateStateByKeyPa
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131659557
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -37,13 +37,16 @@
import org.apache.storm.streams.processors.MergeAgg
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131680183
--- Diff:
storm-client/src/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessor.java
---
@@ -0,0 +1,75 @@
+/**
+ * Licensed to the Ap
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131682043
--- Diff:
storm-client/test/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessorTest.java
---
@@ -0,0 +1,107 @@
+/**
+ * Licensed to
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2233#discussion_r131690416
--- Diff: storm-client/src/jvm/org/apache/storm/streams/PairStream.java ---
@@ -380,6 +383,22 @@
return partitionBy(KEY).updateStateByKeyPa
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2241
FYI: Regarding improving LoadAwareShuffleGrouping, I spent some days and
published my improvement on #2261. From my latest update, compared to current,
#2261 is about 4x faster with single-thread
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2261
I just take opposite approach, pushing updated load mapping when load
updater timer is activated. We no longer need any tricks or optimizations to
reduce checking, and even no need to check updat
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2265
Error in storm-submit-tools: DependencyResolverTest
Should not be related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Thanks for clarifying.
We have not run into an issue were we actually have needed to fix the docs for
an already released version, not saying that it will not happen in the future
though as the docs are not perfect. But updating the docs to describe a
feature that someone is working on is a muc
Maybe I was not clear. I meant removing 'releases' directory from
storm-site repo, not storm repo, given that we have duplicated docs between
twos. If we can get rid of that we can reduce the size greatly, but as I
stated from another thread, it may need to decouple main docs and release
docs.
One
Please don't remove the .md docs from the storm repo. Those docs document the
current build. Things that are common and almost never change we can move to a
separate repo. But things that change from one release to another should stay,
because they show what the current build is like, and hav
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2265
[STORM-2674] catch NoNodeException when IStormClusterState tries to delete
znodes in reportError function
Fix in 1.x-branch.
see https://github.com/apache/storm/pull/2264
You can merge thi
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2264
Sorry, from wrong branch.. Will file a new PR..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user Ethanlm closed the pull request at:
https://github.com/apache/storm/pull/2264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2264
[STORM-2674] catch NoNodeException when IStormClusterState tries to delete
znodes in reportError function
Catch the NoNodeException.
see JIRA: https://issues.apache.org/jira/browse/STORM-26
FYI: I've exported SVN repo of website and pushed to 'asf-site' branch of
GIT repo.
https://github.com/apache/storm-site
Please note that 'content' directory will be used for serving website.
(INFRA guided me to use this directory)
Need to update README.md for the new instruction.
Btw, this is s
GitHub user cluo512 opened a pull request:
https://github.com/apache/storm/pull/2263
STORM-2680 : The switch to turn on-off the cgroup in the doc should be
âstorm.resource.isolation.plugin.enableâ
You can merge this pull request into a Git repository by running:
$ git pu
38 matches
Mail list logo