Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2368
@srdo Made the change you suggested and it works great, thanks. I squashed
the commits and pushed as new version. Have a look.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2368
Looks great, +1
---
GitHub user kevinconaway opened a pull request:
https://github.com/apache/storm/pull/2370
STORM-2775 Update kafkaPartition metrics to match the same format as â¦
â¦kafkaOffset
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevi
Github user kevinconaway commented on the issue:
https://github.com/apache/storm/pull/2370
@HeartSaVioR The build failure appears unrelated to this change. Is the
1.1.x branch unstable?
---
Hi Shawn,
Welcome. I don't believe we have a mentoring program, but someone else can
correct me on that. I have a few suggestions for places to start.
* On the master branch we've enabled checkstyle, and most modules currently
have a large number of violations. Fixing some of these violations
(di
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2370
I think some of the /external modules have flaky tests in 1.x and 1.1.x.
They seem to have been fixed in master.
Is this issue not present on the master branch? If it is you should open a
PR ag
Github user kevinconaway commented on the issue:
https://github.com/apache/storm/pull/2370
@srdo I can make a PR against master. Would you like me to do so now or
wait until this is reviewed?
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2370
It's probably best to do now, I think changes have to be merged to master
before it goes on the other branches.
---
GitHub user kevinconaway opened a pull request:
https://github.com/apache/storm/pull/2371
STORM-2775 (master) Update kafkaPartition metric names
Targeting master for #2370
FYI @srdo
(cherry picked from commit 8db4e90)
You can merge this pull request into a Git re
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2371
The change looks good to me. +1.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2370
I'm not sure if the names may be getting parsed by consumers, so on 1.(1.)x
we might want to make the new names opt-in with a configuration parameter to
avoid breaking changes. What do you think?
---
Github user kevinconaway commented on the issue:
https://github.com/apache/storm/pull/2370
I don't think consumers are parsing them directly. They _do_ get passed on
as is to the target time series reporting system so any dashboards that used
these metrics would "break" (or need to b
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2370
The impact is probably pretty small, but I don't see much harm in returning
both the old and new names for 1.x and 1.1.x. I think it's a good idea.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2371
+1
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2370
I'm also with returning both format.
---
Github user kevinconaway commented on the issue:
https://github.com/apache/storm/pull/2370
Updated to return both formats
---
Github user wangli1426 commented on the issue:
https://github.com/apache/storm/pull/2164
@HeartSaVioR @asfgit It seems that we forgot to add @wendyshusband to the
contributor list.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2164
@wangli1426 It would be great if you could also add me to the contributor
list too LOL
---
18 matches
Mail list logo
