[GitHub] storm issue #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/2400 @revans2 can you elaborate on why EvictionPolicies are no longer needed? ---

[GitHub] storm issue #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread jerrypeng
Github user jerrypeng commented on the issue: https://github.com/apache/storm/pull/2400 @revans2 interesting work! Though the formula used for the DefaultSchedulingPriorityStrategy seems to have a bias towards smaller topologies. For example: Total amount of Resourc

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148923251 --- Diff: docs/Resource_Aware_Scheduler_overview.md --- @@ -303,28 +326,33 @@ To get an idea of how much memory/CPU your topology is actually using you can

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148923218 --- Diff: docs/Resource_Aware_Scheduler_overview.md --- @@ -243,58 +243,81 @@ http://dl.acm.org/citation.cfm?id=2814808 ### Specifying Topology P

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148923188 --- Diff: docs/Resource_Aware_Scheduler_overview.md --- @@ -243,58 +243,81 @@ http://dl.acm.org/citation.cfm?id=2814808 ### Specifying Topology P

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148923121 --- Diff: docs/Resource_Aware_Scheduler_overview.md --- @@ -243,58 +243,81 @@ http://dl.acm.org/citation.cfm?id=2814808 ### Specifying Topology P

[GitHub] storm pull request #2398: STORM-2795: Race in downloading resources can caus...

2017-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2398 ---

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148882086 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148852931 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map conf)

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148852799 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map conf)

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148852532 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map conf)

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148852167 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map conf)

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148851660 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map conf)

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148850943 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map conf)

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148850301 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -62,123 +70,144 @@ public void prepare(Map conf)

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2400#discussion_r148849861 --- Diff: storm-client/pom.xml --- @@ -193,6 +193,10 @@ org.hamcrest java-hamcrest + +

[GitHub] storm pull request #2400: STORM-2792: Remove RAS EvictionPolicy and cleanup

2017-11-03 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/2400 STORM-2792: Remove RAS EvictionPolicy and cleanup You can merge this pull request into a Git repository by running: $ git pull https://github.com/revans2/incubator-storm STORM-2792 Alternat

[GitHub] storm issue #2399: STORM-2793 Track network data metrics

2017-11-03 Thread jmartell7
Github user jmartell7 commented on the issue: https://github.com/apache/storm/pull/2399 Performance didn't seem to be affected by adding the metric. Using ThroughputVsLatency on my MBP (2.3 GHz i7, 16GB RAM) with 35k tuples / sec, 4 workers, 4 splitters, 4 counters, 4 spouts, I saw th

[GitHub] storm issue #2385: STORM-2727: Generic Resource Aware Scheduling

2017-11-03 Thread govind-menon
Github user govind-menon commented on the issue: https://github.com/apache/storm/pull/2385 @HeartSaVioR this PR should cover STORM-2725 (which covers STORM-2727). I apologize for the confusion - I was planning this as several PRs and it snowballed into one big PR. ---

[GitHub] storm pull request #2389: [STORM-2693] Storm heartbeats promotion

2017-11-03 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2389#discussion_r148777617 --- Diff: storm-core/test/jvm/org/apache/storm/nimbus/NimbusHeartbeatsPressureTest.java --- @@ -0,0 +1,208 @@ +package org.apache.storm.nimbus; +

[GitHub] storm pull request #2389: [STORM-2693] Storm heartbeats promotion

2017-11-03 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2389#discussion_r148777382 --- Diff: storm-core/test/jvm/org/apache/storm/nimbus/NimbusHeartbeatsPressureTest.java --- @@ -0,0 +1,208 @@ +package org.apache.storm.nimbus; +

[GitHub] storm pull request #2389: [STORM-2693] Storm heartbeats promotion

2017-11-03 Thread danny0405
Github user danny0405 commented on a diff in the pull request: https://github.com/apache/storm/pull/2389#discussion_r148776617 --- Diff: storm-core/test/jvm/org/apache/storm/nimbus/NimbusHeartbeatsPressureTest.java --- @@ -0,0 +1,208 @@ +package org.apache.storm.nimbus; --