Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2397
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2397
Last commit resolved conflicts.
---
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149523415
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/DefaultResourceAwareStrategy.java
---
@@ -18,93 +18,58
Github user govind-menon commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149511408
--- Diff: storm-client/src/storm.thrift ---
@@ -496,6 +496,8 @@ struct WorkerResources {
3: optional double cpu;
4: optional double
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149483149
--- Diff:
storm-client/src/jvm/org/apache/storm/utils/ShellCommandRunner.java ---
@@ -0,0 +1,63 @@
+/*
+ * Copyright 2017 The Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149483098
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java ---
@@ -135,8 +135,10 @@ protected void setWorkingDirectory(File dir) {
/**
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149482455
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java ---
@@ -432,47 +437,47 @@ private void setTimedOut() {
}
-/**
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149480035
--- Diff:
storm-client/src/jvm/org/apache/storm/utils/ShellCommandRunner.java ---
@@ -0,0 +1,63 @@
+/*
+ * Copyright 2017 The Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149480275
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java ---
@@ -432,47 +437,47 @@ private void setTimedOut() {
}
-
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2403
STORM-2803: Fix leaking threads from Nimbus/TimeCacheMap, slightly refactor
Time to use more final fields, replaced uses of deprecated classes/methods and
added a few tests.
I'll squash once review
Github user dossett commented on the issue:
https://github.com/apache/storm/pull/1044
@fescandell I don't believe there is. Because I was unfamiliar with the
Trident API, I didn't make any similar changes to it.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2400
---
12 matches
Mail list logo
